From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 090C2CFA44F for ; Wed, 23 Oct 2024 16:37:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96DDC6B0092; Wed, 23 Oct 2024 12:37:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91D8B6B009B; Wed, 23 Oct 2024 12:37:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 770656B00A8; Wed, 23 Oct 2024 12:37:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 572976B0092 for ; Wed, 23 Oct 2024 12:37:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 71414140DAE for ; Wed, 23 Oct 2024 16:37:19 +0000 (UTC) X-FDA: 82705422786.29.4F0B93C Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf05.hostedemail.com (Postfix) with ESMTP id 762FA100023 for ; Wed, 23 Oct 2024 16:37:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=kBZIGg2G; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=WhH5MlGK; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729701377; a=rsa-sha256; cv=pass; b=8C3h/50+viUGKqGS4NhWSShwUkUCmMD6JXtbRIDzS014iyP/H6fk1E9YZQsGuKl0HoKwFZ s3m1enkhwp2rWdnmX8bLfOQl5UPemYTLO9/sq6rTGlXKgCGblKRj+UR498SqgeMn/TLxrt HNXGSolkckxYbh+BnxSXUog4kUX4onc= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=kBZIGg2G; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=WhH5MlGK; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729701377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YR5tKqFSs0NvN31HZ7UlLt8IffdQvPM0KO2FWIYKjs0=; b=ORqf2vUsgWmKDEsXLPhW3iW2sBApNsEW1pwMFTP0/zwSQSmS+DAm6Zm6OIqtJ/3+wbxHkU mVRKZMPGNMNZZB/+cKMdYQg6wJUxH6S/yjja9GmTOVePGq1HemPXcwGVlQWDZ8ge6t+Be8 Q83BS7g6EeRFkoX4g6iH2d7W2unnIWs= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49NFfgfO026687; Wed, 23 Oct 2024 16:37:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=YR5tKqFSs0NvN31HZ7 UlLt8IffdQvPM0KO2FWIYKjs0=; b=kBZIGg2G3Vo6ZREndLHHw1TDIMrpbfHvhS cZYlV0Mv84p+QIEPKMrgSY8ZKLBrFJDWyB06fdX5gy2DoiXAV82AwHwHbG/Dky8Q 8TN7wtV6Nz4A97r+m4p1uboxRmxJ4xhyP+XkJL7g/SrMtwIad6/soiYOOazkz985 a4lgRlI8hXm4qGiwWv9NePmOhYdyaQbVflNTt0fyHAwZaK4pE3dDqlPxIXmkv9EZ I42xdxXqcqCKilzwOGWCps3F1Ta4mVYID0u5c8L+d8FURMvswAEFeJn9c1F3ZN1y 6ksOtOCRA/yEgg4SmHkAM2yuf0hLj+zdqvtC5f8KXs9NUYRT8m2A== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c55egg1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Oct 2024 16:37:31 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49NG0WIr025332; Wed, 23 Oct 2024 16:37:30 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42emh9rvjv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Oct 2024 16:37:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VGf5nUdXGo6m6iHJL/zm577tFB9w8QiAJFkZlG3FphWFvc/BkShaP8BSjNvvMeB0wQjSa/4s0hg0ucWLmrD3hpx5sIo1oQ7BAn8VhNogIBLlEEKJkuGsIwaukHeuMVgU8bQ6hdtysr4Ttf2YUUdqDtN8ClIjlyS6+O9o/Vp1LRLke2O3+LLbKU3O1jRX2hS0mjg8mAt9z8C6uBiTkT+5+YJglG8fsvXr0pdflvUUsSk6+7tbcNP8cAxhbsySuwgyWOP8mDZD84mjC738jRPyrp0savHnPXu3iARiqk9+4wJnUJM54JHAoOoCbQuldAILwm0+jIynC0yO+co9am0fwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YR5tKqFSs0NvN31HZ7UlLt8IffdQvPM0KO2FWIYKjs0=; b=X1eiJTmZopfqoFwToz1F2CKGZVUFjF1FBk5Op+Na3MkgrTz3SwmjFBtOz+YZiyw6MmoXoC0SyDodB4keDLQRlde/yODOXKZRGAA+SV0S9YfQnKdzL4zZrXeOSBBqHhPkvgfDS5ku3eFCIn1gPHZ1ju4Pt9vOi0SWZ94ZcB+l2C3gi3rkJO3DMq5G+aSZKQ8fGxDiVItMWQMDyhSB+04fn7xSSPaw6XSB0p0Ih4SKerc5oKDbg2DztMBWkdO2B+Z7qcz8LCDUkzrCvgtB+yd7ZHiKD2EaFS/8quKixWamgeRPybR3R/NEGQILaH/NH/C/E9mLFrEXBYldb3tn7w7EDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YR5tKqFSs0NvN31HZ7UlLt8IffdQvPM0KO2FWIYKjs0=; b=WhH5MlGK8H5zHa8CuVlqzBzqeeIWsuYasaVaAcvursZ4gy/KCmBzWAdySp2v/BV/sLulRPFVIzHbMPM4eV9GHjHgk6VSLs22ja2l/xHb6LMNMe9zI+WNjd+Gh9feWf/jXFj15W2igzi6qSZvLILHSVEXQWGc+ZWTlvd5OxLz0cU= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by DS0PR10MB7901.namprd10.prod.outlook.com (2603:10b6:8:1a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.17; Wed, 23 Oct 2024 16:37:28 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8069.024; Wed, 23 Oct 2024 16:37:28 +0000 Date: Wed, 23 Oct 2024 17:37:25 +0100 From: Lorenzo Stoakes To: "Liam R. Howlett" , Andrew Morton , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu Subject: Re: [PATCH hotfix 6.12 3/8] mm: refactor map_deny_write_exec() Message-ID: <5262b8f4-ba35-4c33-9ae7-acf3f0fae63c@lucifer.local> References: <3de53e7fmsql2t7byzoqonyt7e22bztucjcypykvqiystbalw3@2vwnvh7jcfed> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3de53e7fmsql2t7byzoqonyt7e22bztucjcypykvqiystbalw3@2vwnvh7jcfed> X-ClientProxiedBy: LNXP265CA0002.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::14) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|DS0PR10MB7901:EE_ X-MS-Office365-Filtering-Correlation-Id: abb9bd90-6dd6-4bf8-848e-08dcf380fb42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FNF7owdwUR28hU+UtS8hXk6+gckekfR9qivgsq5GokMXMyZ0kxqUrP8SaVNe?= =?us-ascii?Q?Z/y4ZZ7sYk+eIcKR/Yd4QnYC4dbMQ13b4NkG8vc4hlTakTGY1bx4yAACGjjl?= =?us-ascii?Q?5K4HeOPzH+ZaDBw56+itsFcgqqPQdEBh/zAzc5+/19WrbfNGDRHkoYkEOoI3?= =?us-ascii?Q?RuZUChj6ZvW9YhGZZ5xG/8/YIraFFbeS3Q04a9Zjcq8UvquRQibsiraC5fks?= =?us-ascii?Q?LO4G/l9Bbh1dfi2vIywq703LZen0YvJaqsJS8qjtMjOCJ3A4dLyqKUiyRTlL?= =?us-ascii?Q?f71QTuDoTeUHA0zyHpCGaFt4n6Irywa0xHeJ9muq185M49NdfvygiRHHutxE?= =?us-ascii?Q?1iW58gTanMclkY31MOXxY+bm2pTVjSFoCHJrH44L339HoyMmbvz+TYbIjxq3?= =?us-ascii?Q?h9BOHSnCGqxISr6woN+Tz7kb3TdJvYrC6UcU+fFKz2yhacaO/QV2GOHemtpz?= =?us-ascii?Q?N9gdt5JmqPtN37aemfZnGUH8YsUjVuR3eorn/KhcNuOxpvlBgni/hsMkppos?= =?us-ascii?Q?ny+U7lGYKYYVgJngPvM+qgzVr/h3rvy3Bw8lI2hfie9oDPmGUoMAe2/5zseW?= =?us-ascii?Q?msKG/tfiCCzAG5ZtT2Wtn5j4FM73Wg+9M1D8sGfmt8Bja2Sv2EzY1VxS7OP/?= =?us-ascii?Q?LfozBohApFEP8vF5zNu5jrY7qcvrz+5tzlAyxfuGGBgxnEgdQ2Cz69fI3cqn?= =?us-ascii?Q?+aoVdWj48BWCyJvo1kDPg8WurMOTdwUSVBv0fIE1rpvmxHhG73Kd7XTSZN2Y?= =?us-ascii?Q?OMwUUk1nlAsXEbqvnLGg0eOKXRc+EEl9Q8ItZHS3BjeJt47HgVnpv9XkKzvf?= =?us-ascii?Q?8zHoFpFZMRKc3LctUcCNkb/1kCntvYGS0PkdBehJc3Ing8O+nK7WB4SOtUSF?= =?us-ascii?Q?CjVkFTAcrcUmTsO1ov8AQEhZOHPJLzeeKmvlznD/CaVcyzB8jcqxGTdbw9zz?= =?us-ascii?Q?LnKeqcwpRLLhOrwjOfMG/zwSgCQPeHtPcEcKR1p3CkLPtVjLxxegxkwpOjJi?= =?us-ascii?Q?f85OLSmyZr7vg6cfArwJh858yL9al+gejkpgghcemfDTAV2Ur/QxXStoA7WO?= =?us-ascii?Q?HwZ0ICcgw0U0MuG/ZHx4QVNWAn1p/FT6c6qSeczq2EaweOiI6mh5RhMj9NZc?= =?us-ascii?Q?rrBcKR5jMeGSjdDOGueuH533A71nciuZiXukVB7+1IqYIcPgE7yfnVo+XxsC?= =?us-ascii?Q?iaTq74WoKvxqvgyYMec9lyOAklW/T0FIJ718UMa9eWnUgdf1CuLrBVyGTcYB?= =?us-ascii?Q?uXBUiW0/0NK0afjukpbyZEt+dDcjloL+MkIpxOULb3L3i0CKkBZCrPjJHK6M?= =?us-ascii?Q?6MGxKrEuE2lCyTCS82gVtBbD?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mK0AYlgpL+WSvYWElzQCEd0Zjzw8eaEiAqI96J06U0iYSLgcREyMJJOwe8Jv?= =?us-ascii?Q?o/MF5UTIJ2DX+F7Ayi/L3VXuQMaUIRYU/UfGVihACVPkyLfGwXu+MojcEGXh?= =?us-ascii?Q?wRI6tYmkeGB3WijxV6tPUgHBQ/JJ1Y59yJh07RuOdy8loEVDszUlt7L4MN5q?= =?us-ascii?Q?i0tamPYNvJmhjLHTgscD0Vz9Y4oWReQui2j1eygIK1yKchYlmhRFOJFC/khm?= =?us-ascii?Q?lrDoXGj6pl/RiyUx3FvFAJQWQ4AFDvpZ+uI4zoGNwjiRJmMwWy0AdQWDdlX8?= =?us-ascii?Q?obh+rQ9OK/luForhWE+PqtNzkxzOCiJD7PrsBrSldchzv95MMpqhwkrk02tI?= =?us-ascii?Q?+KuN/5PA/J9VBFVxHTcHQ/L2nOkfbQKzVWs+g1iNUtl8ebycuOCXVTknZVnK?= =?us-ascii?Q?GWNn6zGz4fuYB/i18YSxE3dWL5mYfWgROjTUoT11easl70Kb2rpHjvm6o1GH?= =?us-ascii?Q?Fl3ul92SnOBuNMHncPUO79dCzOks37IsIeujwyJWLRUJhvRJEiHrHGJRQHlp?= =?us-ascii?Q?PjVV+vrtx65qucjxq23ajBq1H4GPGyXSKZweSIYEn2IYCWEmO8W/SogBbfb1?= =?us-ascii?Q?bQ2rh4jte3beEnSynIL/WvmL+01JZet+IM0KbK5bOrpu9ZJp3KReboa1vg8Y?= =?us-ascii?Q?I0ou0J68F52Wwwsww17KEpZRQHDE52B/sXRVB1m1HDbpSNNwxvYdWEAmoKR/?= =?us-ascii?Q?NV6rv7Gi1uxCdCPAmc8EUV1dbsIbQqeUNUFtQnz1Dr0xa44+lxE8kDUOq3zV?= =?us-ascii?Q?wvMIAIWpTABqtuRgMP85l/myyffblTQOvfe/k/26NWn+JO9b1JJ/ndRvjrEb?= =?us-ascii?Q?lyQ5SbznrWw9X7UW0GZDf+ZQoTQgioTJZex5yOhCSUFaDf9yuVz+3LYCHcmy?= =?us-ascii?Q?/26pvfnYRPNTwuH4SWDjp2l77EHRqn3JA7/3z+GGI/iIsn8FPAluVf9b3cuT?= =?us-ascii?Q?iSy4TWFKu1m6RPr2kq+Rw68M9xxCmTW5ebeWghki0KZibbaASm7/HhEgJMR2?= =?us-ascii?Q?qxZNr/p0DEj5LjMoO/VaGjk7QEH0XdbUZL/U/5LV1BsNfmhD5hMWM/G+dGu9?= =?us-ascii?Q?hR70iBO59Yxt/Dt1n0ZH5IrAIDbLjpfrfAIMLvL4Liq4E8RgLuDrJOUj0xbc?= =?us-ascii?Q?gONtVwoavciNLyXDYbmafIX/U7Hg/qN6JWLhdREXX9iRWOIyGIG4GBVff6MV?= =?us-ascii?Q?8x3vFWVIm8jnpoKRvr0Bqo9FAPjcAPxYvjjWWAA/QUQxp7W3YB9OawCR3zE2?= =?us-ascii?Q?VbUbCGmq3UTYZpzmsGkk1cGVhcwpkUE7EH3NGz+pQ92HA4AB1TV/uRjogk4r?= =?us-ascii?Q?2etSg7tM6PmnS0MpK18Pw3+pipSowuI7iXaCBgmudocXv+qtUIetFBv1UGF6?= =?us-ascii?Q?RWMmiwBsoNL027XdaqXTksEifwQHEJH4LCiq6ie/YlhPDqIHC7rESEAU9whz?= =?us-ascii?Q?mOfSM2Xw3MYVGb+AtcJmpGAJiJvB1Wisb1Eit4j8r6a3mPxAFvXrjOfRuH2P?= =?us-ascii?Q?9qHdgB05fLlM6gZMdTYITR9L8LsYY8MvAP0fkYUFjOJqBbzVyPm5a1AQJFIW?= =?us-ascii?Q?G90Y4YGA2xomHUdWa/L7FZiESiMK4nfU2DxRf7xYmWdNOYu4ZnOcQIdbuPAR?= =?us-ascii?Q?ehpg1icUfIoYgcu8SSld71YvNTXuq9NimNrSDh5HLDr1Ycm07eZjnYaX/PXe?= =?us-ascii?Q?gYyxdg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KzPEHNveqwZTBI8witGbWRLI2sM5TFL0MbkhIgV33B7wLY453lxLxaG2DrdfXVR+ZLmqHgJ+lw5Mz70d4/7ab/5fL74YbR/gxaTZibiPpcwpBpOACyxYmClrMAAsI1YN5gW4NjVhNtrFILnDjMtxEE1guW+Nl0juNQYTHO6wssZniZeQnQlDnH02hvmorFRfRkI2Ne1cktLVmKFK5sewgl3N9ZircSyEqfoawrHm5u/wnFFQJcB3EmCVs51/c6LPVmL3E57m05QVI6AUS9vT3lMHWbQd3LmQCG+vUXIfB4m4SWiyCHQPqzXlGW8uj0oIV17g3xm+8q0G2w3/3uhy85RTCWMQDhOPkuXcC0J+3r92qxWYkQU9zTknRKUZOiFh0Wzd0QxO2ABjKAIBBRuXXUlot++ZrUtiMRgj258LHzr3ymAMl/QwITPJ/Q/AIkog/4T2rWFy5i94BVJzy0V5O+AXymKNP5loTSJCK7HE180TRYB7mKDU/XrPKPxsnZs6N8vfBpcEOuUJImd43F8boDZFUOP7Sdi9W34OAv89F8ohCiaCBJg38IgRPQL69dS83RnVIiedCq9myAG72xbVZ3EEZF+1dCU4/tvqRvSDuiw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: abb9bd90-6dd6-4bf8-848e-08dcf380fb42 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2024 16:37:27.9134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Z491Lq/FX/nrXyv3wJBG8mlEVjG62Y14f1SUS+ZjHJ7f803WN8Ntxv30ViTKYFKHICjLm2X00kkMnVr/8KunuLKPVC5/RRq34YkRtOwxCs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7901 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-23_13,2024-10-23_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410230102 X-Proofpoint-ORIG-GUID: COoNC6VcVNgxhPKAC52HZrTJVnGo18Uy X-Proofpoint-GUID: COoNC6VcVNgxhPKAC52HZrTJVnGo18Uy X-Stat-Signature: dbesqugcb439hgezo5om5eb1pr4dgyad X-Rspamd-Queue-Id: 762FA100023 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729701421-549138 X-HE-Meta: U2FsdGVkX19vI2jPLrR35ygW7Y4o7dxlxES9MW5/vnnPN2eY7IKjkCkSFieNj1V/sFXODUwVRbRlWFwS1Zc4qFNAWFarweUkApaXpYlQ+/bVUKtBk6R92G4fZFfd9mayS3Dj80srOwQHI+oNe5sp3HxdxYPUXgmvHJFZJSSw0YMEqV+7sg7gEtyrTLcefIwdxAXrL0AA5KgJBs836FGc5lsAloh1Mk6hfnppqJrGohfxxDJr0gF4HNWmPiEPdGzqUvRAKZ2iljey5j0QG3cfYzZLzGqjD/9jJyZziAUYAwSdakkVCOQ7KUDIkkVWVg3FhZnfPaqmkRJAxl0DvE9EHvAWAzscdtjAbutG/52R5sVFCZf5rJkKTp89YjPI4dincZ04qrGj5a76MwdN0HnBPFhPILILJHGlRuwDuwROuvxhNL23ns4Kvok7DwlLLOX/7+5Y5bRshyQFcd0IbXukKTnxsLjBTBbZ93pU+vlsKR2KHPoWHigbq5JiWIVVhUpRf3MQM2r/NtgIw/jGw2fJPLkEqsEAThMVo5Qp04Woa/eX4S40oRa8OITOY+iAemj0eLrk1V26jzgFrqlfo9XdOEdRfNYpHzd8/2yW/T83UZM//QefazbY5vb3GrPgcMDkLDWulPIMfSG1wZcSfYXW5+Ev2MpcRLLtKv42o8B8t/2cGXXcW6t2u0NVyiQf/n8QIby+QVzHYCrFeXaaBHtP9zD3nTGBCVHt5yndyYFNrLNn6alLcca4H+HJAB9YXDPXJnsV0jNeJGdmj5Fikp7p5Lp3d+dTJL95RanC8JoDXobYQd1V37lsWbjeBYxqkfnx54HfAVU0ZHGQeKPeD6jIQUwaRe38kFRdrxhPscCzzbecUqnPopwMwyfTbUrANCYBvNAsH5P8ymmYBwJt5Pp5GG48JBcvreEoj4cjgLLBIaiu2GVPKym3VrmdIV0RzUp0R3zQfDZb8b49ptfPo5d WxopXMA5 2gXKuy5lVs1JlECQH3oUZ+5f3sIWcmNKT8AaIcQUID5wYjrjeCcDVPbymcn147nRHwMV1FqHAqkv4BC1U3CDvNWdGBaYgYZiJRxH9fsK/ZU00JqU1VUSezVxndL27bUVxUUaOh4ur6JxUaJaYKA938YvymxnrM6RMIeGMw/Fi1/rHXeRszQwYvlQaTmKbKM7SZrlFFl3/LFlRic8QmBeIGGae20iN1ZoE6NvgdhjVvhLodIQ0+dT2DWzPF5wHFPXyvRyXOnIEBe5ZlX5yXCm4exPyVkuOi1m5QJj9JMsDzPHQzkHVf6kBsSob4XcymyH/fTUJoeeCuwZ3P8p3T1gAVX2fQj/f3qisihvSrtosq54TO79Y/w8ngmdf0VxO+MXtgR2Momp5rtrVtc9iYKU6mx3Qr9td5Wxzxub3hYRg/gUATgMMbPG2oZGwOE8VyK+AkgDH4LbPRtULRunddXYzLSXIyPsk1B5plhHuMP7WmHHO8u0fTD+4YHe465Yt9/dXk773Hxh0fbBkXyQ/v7UgXvYF8atfgKhqq6YyKovezuX36G/yAMAfPDkXOLnKpGyZDccQeOOU/bfq9CxH2d5KJfXG1iuKo/7StV3DP9l6rq8JklA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 23, 2024 at 10:30:46AM -0400, Liam R. Howlett wrote: > * Lorenzo Stoakes [241022 16:41]: > > Refactor the map_deny_write_exec() to not unnecessarily require a VMA > > parameter but rather to accept VMA flags parameters, which allows us to use > > this function early in mmap_region() in a subsequent commit. > > > > While we're here, we refactor the function to be more readable and add some > > additional documentation. > > > > Reported-by: Jann Horn > > Fixes: deb0f6562884 ("mm/mmap: undo ->mmap() when arch_validate_flags() fails") > > Cc: stable > > Signed-off-by: Lorenzo Stoakes > > Reviewed-by: Liam R. Howlett Thanks! > > > --- > > include/linux/mman.h | 21 ++++++++++++++++++--- > > mm/mmap.c | 2 +- > > mm/mprotect.c | 2 +- > > 3 files changed, 20 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/mman.h b/include/linux/mman.h > > index bcb201ab7a41..d71f83b821ef 100644 > > --- a/include/linux/mman.h > > +++ b/include/linux/mman.h > > @@ -188,16 +188,31 @@ static inline bool arch_memory_deny_write_exec_supported(void) > > * > > * d) mmap(PROT_READ | PROT_EXEC) > > * mmap(PROT_READ | PROT_EXEC | PROT_BTI) > > nit: the arguments are not in the comments (which is a pre-existing > issue). I add them! ---- | > | > > + * | > > + * This is only applicable if the user has set the Memory-Deny-Write-Execute > > + * (MDWE) protection mask for the current process. > > + * v----|---------------------------------------------------------v > > + * @old specifies the VMA flags the VMA originally possessed, and @new the ones > > + * we propose to set. > > + * > > + * Return: false if proposed change is OK, true if not ok and should be denied. > > */ > > -static inline bool map_deny_write_exec(struct vm_area_struct *vma, unsigned long vm_flags) > > +static inline bool map_deny_write_exec(unsigned long old, unsigned long new) > > Nit: somehow "new" is special in my editor. Also, I'm too lazy to fix > my editor so I'll live with it. Time for a "new" editor! ;) > > > { > > + /* If MDWE is disabled, we have nothing to deny. */ > > if (!test_bit(MMF_HAS_MDWE, ¤t->mm->flags)) > > return false; > > > > - if ((vm_flags & VM_EXEC) && (vm_flags & VM_WRITE)) > > + /* If the new VMA is not executable, we have nothing to deny. */ > > + if (!(new & VM_EXEC)) > > + return false; > > + > > + /* Under MDWE we absolutely do not accept writably executable... */ > > + if (new & VM_WRITE) > > return true; > > > > - if (!(vma->vm_flags & VM_EXEC) && (vm_flags & VM_EXEC)) > > + /* ...nor newly executable VMAs. */ > > + if (!(old & VM_EXEC)) > > return true; > > > > return false; > > diff --git a/mm/mmap.c b/mm/mmap.c > > index d55c58e99a54..66edf0ebba94 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -1508,7 +1508,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > vma_set_anonymous(vma); > > } > > > > - if (map_deny_write_exec(vma, vma->vm_flags)) { > > + if (map_deny_write_exec(vma->vm_flags, vma->vm_flags)) { > > error = -EACCES; > > goto close_and_free_vma; > > } > > diff --git a/mm/mprotect.c b/mm/mprotect.c > > index 0c5d6d06107d..6f450af3252e 100644 > > --- a/mm/mprotect.c > > +++ b/mm/mprotect.c > > @@ -810,7 +810,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > > break; > > } > > > > - if (map_deny_write_exec(vma, newflags)) { > > + if (map_deny_write_exec(vma->vm_flags, newflags)) { > > error = -EACCES; > > break; > > } > > -- > > 2.47.0