From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E49FC433F5 for ; Wed, 20 Apr 2022 06:48:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 895E36B0072; Wed, 20 Apr 2022 02:48:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 846786B0073; Wed, 20 Apr 2022 02:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70E7B6B0075; Wed, 20 Apr 2022 02:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 640496B0072 for ; Wed, 20 Apr 2022 02:48:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3A0662252B for ; Wed, 20 Apr 2022 06:48:38 +0000 (UTC) X-FDA: 79376329116.05.DC97DAB Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf28.hostedemail.com (Postfix) with ESMTP id DD140C0014 for ; Wed, 20 Apr 2022 06:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650437317; x=1681973317; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=mTGwZSM92pTyL2ctMbSS0zhlVkv6R4jcFFbuY+lt9Ug=; b=SQPhxz4SrODYipD4KdgNWn7dg/BSh9Mxor6dTtc3gWP+KU54GpfVXk0z Wc4RpF63K/i/lOb6qlgHwS2mCgGL7M53mfEuDPfOEjRnNkE6ItbSQua7q JE7AgzembCjLPprGZMO6K9i3PigwGrbYojal2leVpUqH0DDFCuiIZkytK 60WkhMswV6utNi8anMXT4tysRiF4rm1Ckpt7NOWCsRLkuMA0emPxVGxqe GByPPNrKNwOY7E+AooxuMgH5ePQ5MxSShEhDigwHeC1GnLLFmcNrzC0SW ndAXUOCB4UFOK8dgPRUh4kdlx7PrIUhnq8Y0b06hSppBkXf12IC56Yb/B Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="245848772" X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="245848772" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 23:48:22 -0700 X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="727366893" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.255.31.199]) ([10.255.31.199]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 23:48:18 -0700 Subject: Re: [kbuild-all] Re: [PATCH] mm/swap: Fix lost swap bits in unuse_pte() To: Miaohe Lin , kernel test robot , Peter Xu Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, david@redhat.com, apopple@nvidia.com, surenb@google.com, minchan@kernel.org, sfr@canb.auug.org.au, rcampbell@nvidia.com, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <202204201313.QYiDBRbL-lkp@intel.com> From: "Chen, Rong A" Message-ID: <52536319-962a-864c-d5a7-5b959aa91f22@intel.com> Date: Wed, 20 Apr 2022 14:48:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SQPhxz4S; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=rong.a.chen@intel.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DD140C0014 X-Stat-Signature: n4hhw3xsyzatcacecdind8cjzkjjkqn1 X-HE-Tag: 1650437315-649051 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/20/2022 2:23 PM, Miaohe Lin wrote: > On 2022/4/20 13:56, kernel test robot wrote: >> Hi Peter, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on hnaz-mm/master] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845 >> base: https://github.com/hnaz/linux-mm master >> config: s390-randconfig-r023-20220420 (https://download.01.org/0day-ci/archive/20220420/202204201313.QYiDBRbL-lkp@intel.com/config) >> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install s390 cross compiling tool for clang build >> # apt-get install binutils-s390x-linux-gnu >> # https://github.com/intel-lab-lkp/linux/commit/355ac3eb45402f7aab25b76af029d4390af05238 >> git remote add linux-review https://github.com/intel-lab-lkp/linux >> git fetch --no-tags linux-review Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845 >> git checkout 355ac3eb45402f7aab25b76af029d4390af05238 >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> > > The variable name is newpte. But it's written as new_pte latter. Many thanks for report! > > BTW: Since this is not a formal patch (no compile tested). Is Reported-by tag still needed? Hi Miaohe, Please ignore the tag, it's only a suggestion, the bot doesn't know the entire picture. Best Regards, Rong Chen > > Thanks! > >> All errors (new ones prefixed by >>): >> >>>> mm/swapfile.c:1824:2: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'? >> new_pte = pte_mkold(mk_pte(page, vma->vm_page_prot)); >> ^~~~~~~ >> newpte >> mm/swapfile.c:1786:14: note: 'newpte' declared here >> pte_t *pte, newpte; >> ^ >> mm/swapfile.c:1826:26: error: use of undeclared identifier 'new_pte' >> pte = pte_mksoft_dirty(new_pte); >> ^ >> mm/swapfile.c:1828:23: error: use of undeclared identifier 'new_pte' >> pte = pte_mkuffd_wp(new_pte); >> ^ >> mm/swapfile.c:1829:36: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'? >> set_pte_at(vma->vm_mm, addr, pte, new_pte); >> ^~~~~~~ >> newpte >> mm/swapfile.c:1786:14: note: 'newpte' declared here >> pte_t *pte, newpte; >> ^ >> 4 errors generated. > ... >> 1839 >> > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org >