From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D04C27C79 for ; Mon, 17 Jun 2024 11:08:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A3CA6B0176; Mon, 17 Jun 2024 07:08:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DF496B0177; Mon, 17 Jun 2024 07:08:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E25B36B0178; Mon, 17 Jun 2024 07:08:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BFB7D6B0176 for ; Mon, 17 Jun 2024 07:08:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 61F6B8163D for ; Mon, 17 Jun 2024 11:08:57 +0000 (UTC) X-FDA: 82240108314.08.7554441 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id F0AC814000C for ; Mon, 17 Jun 2024 11:08:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aA4iOcc4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3xZBSPMl; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="SFC5ENC/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6bt9vuVY; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718622529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YcE9SscqAw6k1EomARF9XYm+AyRMpBjy+86cPLXX7zU=; b=6HchlvCOLRadUqoiPUYDGdkI6Ty4G8lElEw0Jihx5ayQ87v3CcKT/k0u7DozDh46PWme1W 907QHo/lfiThmvEPGuHHO71w4SRS7e4nYDp3bA6zjN/ohVzjnqFQpPTDMV4iaOXnoXgmG5 gaGcUwBQ9h+7qwsrIpk3OJ12Vd68GRw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718622529; a=rsa-sha256; cv=none; b=IozvB6EnKFgCseu+Y+BxmwMRaBD0L9kYTMelQar0gjH5JnT07zwzwxPxqCM25KMiq0oTCd h6I1KYLQcBHfNY2kZhFpqAw2cwklWJCPQIx9buQf5nJNiSKcpL5KE9zTcK7r4xQtbbg4Vt Vk9dQ97nPNtebd+P3plizy7A4pSB4Hk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aA4iOcc4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3xZBSPMl; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="SFC5ENC/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6bt9vuVY; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D2D815C040; Mon, 17 Jun 2024 11:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718622533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YcE9SscqAw6k1EomARF9XYm+AyRMpBjy+86cPLXX7zU=; b=aA4iOcc4DZ60C+JIahr9WARY4NTRn8ky3WQbJDk8vgNfKPB3qe7jpbuhCDUrFO+YRePOhe HEzoZfgx6UidBF/c5LKLkwBt9KLQXYd0xNO8qNnXYPBc3zZeFZByy7Y3aagok/UVfjYmkl 95wAyY4v9RkkILEXOP+Y4cuzknPD4LQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718622533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YcE9SscqAw6k1EomARF9XYm+AyRMpBjy+86cPLXX7zU=; b=3xZBSPMlm4WiqwRcya3SEP7qIPCtoANCB4wH1Zp0CJZO5w3Mn/U0xCTEQ141TZbf0+pSRj I8kwqwzlsTC//iDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718622532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YcE9SscqAw6k1EomARF9XYm+AyRMpBjy+86cPLXX7zU=; b=SFC5ENC/+Fr1rjX+emwTho81VpVQVjv3cwHnVN1FAYWLsqY+SSOakrx57Okh7vhrnpLfs6 W5pxA8VNgZ/6VznLkUSwYRF5JtX+ZPUCGRfYO1DGVOiWnK0SxwtV2Rbo3OFB3AY4jKajCh hWWwJiqGHZI+0zOVoFDYbpfuaK2Wi1M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718622532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YcE9SscqAw6k1EomARF9XYm+AyRMpBjy+86cPLXX7zU=; b=6bt9vuVYI/k7+lPh0mb0xs5R15FUHUM4t559kq7n6sArUQhTMLik2EB7yEzwJOg4JMqHSZ bgsMxwwXcS+pDcDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B5E5813AAA; Mon, 17 Jun 2024 11:08:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rhoBLEQZcGZfFgAAD6G6ig (envelope-from ); Mon, 17 Jun 2024 11:08:52 +0000 Message-ID: <5251cbf9-be70-4a83-97e6-8662427aae68@suse.cz> Date: Mon, 17 Jun 2024 13:08:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] slab: make check_object() more consistent Content-Language: en-US To: Chengming Zhou , "Christoph Lameter (Ampere)" Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Kees Cook References: <20240607-b4-slab-debug-v3-0-bb2a326c4ceb@linux.dev> <20240607-b4-slab-debug-v3-1-bb2a326c4ceb@linux.dev> <63da08b7-7aa3-3fad-55e6-9fc3928a49de@gentwo.org> <8b844d71-01f1-472b-a63a-4c9cdb26e9ef@suse.cz> <7eaee8ce-ad5b-41ea-9eb5-83195f83fd24@suse.cz> <0c0e0892-8410-4a7a-9f12-23b9cc2ef544@linux.dev> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <0c0e0892-8410-4a7a-9f12-23b9cc2ef544@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F0AC814000C X-Stat-Signature: rid3a9ppkgtbnhsrjeckp8o8r4neojcp X-Rspam-User: X-HE-Tag: 1718622534-884530 X-HE-Meta: U2FsdGVkX18s3FXYdO8XOba+xrO0e0SmdUOehLLRvqvEFxUFWAZtVYuBAWqsekFQE8YGXY9GNmgwexPIdqLhb0n8I+oJbGBhhGxsI9Uz/rs3TagOyHXe1r9HlN0M/x6QnMPeF3Q3ttyAcAw0zAuEbQjXU072hcOXJDy1oT+ySQclCQuMgYP6JieQ/T4nmNiiv25G494/PJ6KWnDsOvLJ1wYeLV3KHfsAavMMFS46gO3ETDFDA4Ap3wGr3MywCXDDd00xqFh95lp4e5nV3h43iLe2HDz1/n0geBsIgxngHprQk1NxbtFxlX0T64HyHB9OA46I5gl5rFCqGHrqAQfmCoTYlSpK4hOM/xvt1F915xhcDgwRZo6O5pT4aFS5L5gzeKk5bujO10fRg3QTwLU2LnZUxAahyE7aFk6KkKrexoB4RaVZTTVe1oTCmv4kV3iHpSDdIvn8l/KKYR2upO0l5MD19HdAmMg9HflE0TRh1Nvy7qTMmQLr+h/L6KPNk9UdyFfUhEJy1aJzAFMtPPq5A2mvvcJ4lSca9niBVQBymataBwyz2/J+Z6hAsRHl3cnYY2lihR4u6f9YQB7jvMlztOGRedTREnZ1aukLpguHKOqQb2VOKebrIPymgeN/49fQhaF4oy47abP/D/snGgvnU4dEmzAIpjWYNHYC8ZHeea0LlK+R/OY1HnCN2UMhk747gbdEtvkWL1PwLPtrwuQ/StSFPqH0iKLgAs5+Nq6rt46gkC40gHlWCGYT0EcF2GoewfPNSkXkg56ZPTyIaDpLsUKksrC8EsSsXpAx15o4gyQhzWPoLebQtaRknOLrP3rKqqFz8QHhtLAngklO88ophJAXDIqGTN9iEPmVee92tnlihnAUO0PfWdLjoBYYTGjdRVEKUuNgfPeklD1PoC4AkPsU5ClppFL+banhv53QJNKo+rkToQYVVVdZc5qSaA48K7Wll7HlPfszZAuAF+Y WRwV8/jA 503AAPw/3HNWTIQXUX1YyZezhfNzLg2GhuJizohlpInDa4b+uZnL32gTp3gjvaVU3WhsixbbPnI3KqOMlui24OUKyL/f9Cap8hENMLvQhh07ayzLcXBUnoWjBw0kTTOGQWYEXDE+fDABN32u3vOfuc9EnCzW8DdA3kA1NSLMwy+99QK5qQZFw53DgqiMpF8G74Z+KSP7bTOijANo3YDOf1xcl4CsEAl2mhpQVQw7xov6bO3MGpLHVlXe6/uSWILzhu7X+/e88Loe7DQHuh9okWnzkBu1J5cwavzrislbpGcFAGDep3i9d7UkEsZNEMXECcRH/sLcIC34cx52EHHJlZpa5XAyykxWZ2FYRneahtiQxQlbRpukXEB6vHsoxTUABoJpQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/17/24 12:29 PM, Chengming Zhou wrote: > On 2024/6/17 17:51, Vlastimil Babka wrote: >> On 6/14/24 4:40 AM, Chengming Zhou wrote: >>> On 2024/6/12 06:52, Christoph Lameter (Ampere) wrote: >>> >>> This reminds me that we can't toggle slub_debug options for kmem_cache in runtime, >>> I'm wondering is it useful to be able to enable/disable debug options in runtime? >>> We can implement this feature by using per-slab debug options, so per-slab has >>> independent execution path, in which some slabs with debug options enabled go >>> the slow path, while others can still go fast path. >> >> Many of the debug options change the layout of objects in slabs (i.e. affect >> calculate_sizes()) so it would be very complicated to change things in > Yeah, so each slab in the same kmem_cache can have different layout (caused by > different debug_options enabled), we use these different information to decide > which path each slab should go. > > Then the problem is saving these different layout information for each slab, > which has an unused _mapcount to reuse, can be used as index to find its layout > information in the kmem_cache. > > I haven't thought too much about this, so must be missing something. Yeah it seems very complex with dubious benefits. Possibly would affect fast paths too as we might disable debugging but still have some slabs around that were created with debugging enabled so we'll need to keep doing the checks for them... We'd basically have to keep the "percpu slabs and their fastpaths can't be used" mode for given cache even after the debugging is disabled, and that would already defeat most of the performance benefit. > Thanks. > >> runtime. Also the cache might be merged with other ones if it boots without >> debug... I don't think it would be feasible at all. >> >>> No sure if it's useful in some cases? Maybe KFENCE is enough? Just my random thoughts. >>> >>> Thanks. >>