From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 290EBC4167B for ; Sat, 2 Dec 2023 05:53:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04E308D0082; Sat, 2 Dec 2023 00:53:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F41058D007C; Sat, 2 Dec 2023 00:53:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBB2A8D0082; Sat, 2 Dec 2023 00:53:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C9D528D007C for ; Sat, 2 Dec 2023 00:53:35 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 934E240465 for ; Sat, 2 Dec 2023 05:53:35 +0000 (UTC) X-FDA: 81520811190.29.F61C336 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf25.hostedemail.com (Postfix) with ESMTP id A40E6A0019 for ; Sat, 2 Dec 2023 05:53:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DeaIamhZ; spf=pass (imf25.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701496413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jCRPOdv+OSBaDAjSYHQJOdrd35/mwGfAAGpy6ypFu/U=; b=zakqBsCCt40JrVlg7dOyzMdoXAfN0CLlaOFiFT70mAeH6Yqw2+8AfAyypWyvaU4flKdB9Q b6Xzpef6amaPluw17n2CWDlji1ZPlGPiJj2YCs2NJ0Z90Ytj+eXXxNN7D5oG7ZzSLSdN8+ jegGtfWpwZZCLgboVQQgbxD3bwKT+eE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DeaIamhZ; spf=pass (imf25.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701496413; a=rsa-sha256; cv=none; b=1+CltjCb9+PASLfIIkOC5Ay2WeqyWP5uKJ8q5O7ngzQsooGGq0apBLC5DU/bmbGtpACCjK CixdQ46JYvokVy+BLMfkE379hhRHn1uVXfQsMC/cb5q0W+U1w4Im3LFUEBvKNqhAFcnnSi DefWBUYCoTsswoXEK/nVxWYSeXRLOQA= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d01c45ffebso11436115ad.1 for ; Fri, 01 Dec 2023 21:53:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701496412; x=1702101212; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jCRPOdv+OSBaDAjSYHQJOdrd35/mwGfAAGpy6ypFu/U=; b=DeaIamhZFd/QPZBMos63yWcB4yE0tpO0T4BUVaVx5JDNmMwG1Oar7H9lUmjgiyttj2 sVUUdVu4uHfK9tzLsKwA/HNKTvORIkbFVgWl8CgpZaEbBk9BYNJWpGMJ1plENWD5eRFH 1mzYH0onlbqSyOrp/+1sRq+Ye3J10XbxF7HuRXgHmhCLsBiuPzcc976rUZ9shthcOFR/ Pab33cEs4T+YXiP6YLYMz6e2ZHRbDpaWyywJTlQHQ2LjLaeegiM/MjHjeLKfNIomF6yL Y0jc4rMOa+HxtDyYPIxMd5P4jnpxpQQHL5iWfjgU4gZWhGeqeq1eISgMDwKPYtu8uYzm 9+Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701496412; x=1702101212; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jCRPOdv+OSBaDAjSYHQJOdrd35/mwGfAAGpy6ypFu/U=; b=dUj/8lgaSzWH8Pl1c7STnYuG/4MyylGk7+GfmQEZcQnKN06vqit70C97UplyeOtZ9n xVL/bTgrORJFSaWs5GjVviprMs3Ij84XTDKWJm5N7BaKkRON5Z6BQwjsd1aG/1sLyM1B iNAnbxmVKaxzEsggB6BuhGZEUbWCnomzKcTXR6vTWPIaGGU8lfzaDw0mIoNUXCDYaX/r puYTh8cRmOlqFDwhJ7rTG9voxr+1DCeLBELuTVymrfE3tHvAXdLQTvJ14iDSmCZ9MTn1 dX7akMj3+bJaW50TbVotd4oSxotW5mgM5AqMBy1kg0qnVM/cXg7eDpCpJ5aCg08HIExX NI/Q== X-Gm-Message-State: AOJu0YxnG1MqWYKUBWKLZdwbJKd5pKjwqjYhwYAza9kdsiPJqsppxYpO RNQ9+AdfJFSqLS1T7eXBKWE= X-Google-Smtp-Source: AGHT+IGGj6z2rDhAJOroxjJ73Spkhaw9LeUO+j5FAzbMTsNW53fktbd5lxl+Vi+q76cyep8sG3uh3A== X-Received: by 2002:a17:903:32c1:b0:1d0:6ffd:e2c8 with SMTP id i1-20020a17090332c100b001d06ffde2c8mr814674plr.98.1701496412419; Fri, 01 Dec 2023 21:53:32 -0800 (PST) Received: from [192.168.0.106] ([103.131.18.64]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001cfd2c5ae6fsm2627264plb.25.2023.12.01.21.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Dec 2023 21:53:31 -0800 (PST) Message-ID: <523f0517-fdbf-488b-87d1-f611c97ef810@gmail.com> Date: Sat, 2 Dec 2023 12:53:24 +0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [mm-unstable v4 5/5] mm: memcg: restore subtree stats flushing Content-Language: en-US To: Waiman Long , Yosry Ahmed , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , Domenico Cerasuolo , Attreyee M , Linux Memory Management List , Linux CGroups , Linux Kernel Mailing List References: <20231129032154.3710765-1-yosryahmed@google.com> <20231129032154.3710765-6-yosryahmed@google.com> <436e96d1-29eb-49ec-a463-2ed420757ce8@redhat.com> From: Bagas Sanjaya In-Reply-To: <436e96d1-29eb-49ec-a463-2ed420757ce8@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A40E6A0019 X-Rspam-User: X-Stat-Signature: whhjf11qtxcjw4sbr3zmhku34ybon9mn X-Rspamd-Server: rspam01 X-HE-Tag: 1701496413-128909 X-HE-Meta: U2FsdGVkX1/32F2RMySNLfYjaVuTGXF8aPDQP4rEgiDXGcZPScwt1WuaojhxYYJXJNeXimEGk2HALCOyvaBQ8jlYY5kBtkcM8oaNpdp8SHZBKQhRJbVdXxmEweTWNSbPaWC3aURbvXJA5wOM1azjkrl00K9zYwzoO4Q6zCfuvb27S5TmHbUJUP3F43bA0HPmPDLRJaAP+1efUElP0mR33HAbf+IgHWnTuMbB0JopXEr7bIdMjdI4JvaUNo6amlIGoHGj1Zc2p2BcKSmeuCpR8uieMAbEbw0cR5jWvav/2HYSyK+RAsScJSDgpZPEaDFVPmNeKziD2QlGy7SNShcXldbPkzJMcyOsmUGVdpd2A3/5wsrLN9WbETsLZwc22EJC9zIm8JTuLjvnRCSePgsGRxzuhAuyHwGasqniTA15mHiDdtSowa9ByU8f4iMPztlNBNjx+dT2+On/fxkEBQ9JObR2HTNDEtm7smdCv5o4nmqA1r9jdI5j+daWXlO3KJCqhAu+2K3/WL474Xd9LIyWnKMnpyt/45U8HQtNjt0KbQcbxWQdakBXHUk8afScZ1n8qcnC7RpGzLcwhGufA9HVcIQ3YaIFhnnxJfmAhUwDmOgp8pSot7FO+EV+OvS8LBXYI7EhvyGvz02QlyrZ0PegEDTEnw+Hzc3e10ugyRHUz3fh8Y54QVVlH5UnG+FM6ciATERg/GA+ejskFGKsT3EyefmgR1nI7Rsqw15SpquDVIk3P8k4mMylWcShFKNk3M2vdHAH0lF69a52zCFNmmCCld1diwmNB9QXzXbOrBLej4JmbpnirNrkA9FngKARYsTQgA+S1s6AE3aI/TAPuACgt0X9t9+2DNgibCNPdUB0YayruuAVDih2Z/RqBoTE81vqyVnUs7vnAF5nTx+9IDA5VMXpW/wFuftmM/sWY1pONiDix2diMcbTfzxqgghfPm+H4Q7ZOGAkycK2PL7ky3J vi7u5OYO /I7mHR5QKfrHSFx9VR32Rl1X8zN3jrs9egv2sEj/pv9tjTUriGiD6FohaT/Bx9Zn1U2Njqr9Vymknqcq8edZZFeg/i4sSUCe9bMOMFjywZBoEc6ZFjmIuo4jim41xKoEX0aCNETWzCDveDIXpWGVpRy+4h+9znu49nEcgaq8Rv2m7zjyQghtRX7spiCAtt8V+CKGI6RcPU6io+f9JlH8GVxgwEJgVf+we+fRcS5y8jQD6BKUA4wdnnspZUdorcPfT1sqJO8r35yGltijSzzMhvOwWkR87tHoisyzhBVoGoSYQdLM+dK8Nsks0o4nRv1U7z65jvKoDCx6hlhp3TEJnGehY1cbILoeKrzcqXTWt8f60DVkeSnpwYllB79asVEKeo47Gs+meHZeQLShzv0VZWlsBGHxAYKcgIvWkCZAIJFJt9i13GhARqecd6agl1xRFT440wBdhJgGftC8k1j2zxFr5UtixCGvClIDjo5uXEs1HzRROZA08jgYCxFw8JlcCjTrPKf6BSVCkPDc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/2/23 09:56, Waiman Long wrote: > > On 12/1/23 20:57, Bagas Sanjaya wrote: >>> -void mem_cgroup_flush_stats(void) >>> +/* >>> + * mem_cgroup_flush_stats - flush the stats of a memory cgroup subtree >>> + * @memcg: root of the subtree to flush >>> + * >>> + * Flushing is serialized by the underlying global rstat lock. There is also a >>> + * minimum amount of work to be done even if there are no stat updates to flush. >>> + * Hence, we only flush the stats if the updates delta exceeds a threshold. This >>> + * avoids unnecessary work and contention on the underlying lock. >>> + */ >> What is global rstat lock? > > It is the cgroup_rstat_lock in kernel/cgroup/rstat.c. > OK, I see that. Thanks! -- An old man doll... just what I always wanted! - Clara