From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC822C27C53 for ; Wed, 12 Jun 2024 08:53:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1AB26B0099; Wed, 12 Jun 2024 04:53:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA2916B009B; Wed, 12 Jun 2024 04:53:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6A706B009C; Wed, 12 Jun 2024 04:53:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B857D6B0099 for ; Wed, 12 Jun 2024 04:53:52 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5A32D415F9 for ; Wed, 12 Jun 2024 08:53:52 +0000 (UTC) X-FDA: 82221623904.10.8C42AA4 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf19.hostedemail.com (Postfix) with ESMTP id 2313B1A0009 for ; Wed, 12 Jun 2024 08:53:49 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=m7M1JMks; spf=pass (imf19.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718182430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tkb5TXp35uMGhFX0bOi9/AXX3CAg0/55l8fdoR7W0aA=; b=0MZvuGZO51f3bT5rgGKLpRiEHp736RrzniwudOC4q/eLQz/v4oGlpJcTqw35bK1C/7aFL1 dn472/oY2r038p6p+ifc4u5RfM+BmYv4xfNXn1ogkBQzZBQ4/WhhIwAYCNndXwAEs6hIUx ShcWn/wL77n3JFbrp4DlPMxgp4yr3TU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718182430; a=rsa-sha256; cv=none; b=O5NYJ6K6T5fYoG1yu3HQIuKLRVc5ZThHo+Nmms6GMY0yLlYo07IHBYQsj5yH8yL5WPW1KN sZVG1+kUK7KeXbU7EH274Vf4DvUsVprjTL/QPqtcFl8SWoixa74MHxhELChgD2syAKWbHL DiGy9WwLmLljnkidraNehtFrvB3fMc8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=m7M1JMks; spf=pass (imf19.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: osalvador@suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718182427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tkb5TXp35uMGhFX0bOi9/AXX3CAg0/55l8fdoR7W0aA=; b=m7M1JMksvokr1bofKdKf2BIM/5M5utHaSOr8niE0TgI76JF+tYn84j7lC3rpIiN55isHJR jL+Kcd/EWm0bCgAvlsPuMhj8o3LDqJpYEw10R1BuqpC+IMdirAifuNob4jJEqNQVcBAphG y/74Ol4AtjQHKBMBUBGOFopjkcyyvE8= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: vivek.kasireddy@intel.com X-Envelope-To: syzbot+569ed13f4054f271087b@syzkaller.appspotmail.com Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: [PATCH] mm/hugetlb: Guard dequeue_hugetlb_folio_nodemask against NUMA_NO_NODE uses X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240612082936.10867-1-osalvador@suse.de> Date: Wed, 12 Jun 2024 16:53:34 +0800 Cc: Andrew Morton , LKML , Linux-MM , Vivek Kasireddy , syzbot+569ed13f4054f271087b@syzkaller.appspotmail.com Content-Transfer-Encoding: quoted-printable Message-Id: <5237BBD3-818B-4E06-A56A-80BE705EB024@linux.dev> References: <20240612082936.10867-1-osalvador@suse.de> To: Oscar Salvador X-Migadu-Flow: FLOW_OUT X-Stat-Signature: heoxkdx8oapgo1ww5kwpsnuus5gegje4 X-Rspamd-Queue-Id: 2313B1A0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1718182429-221483 X-HE-Meta: U2FsdGVkX19JaX/cO3vyBhhj6pUU+HjN9aNyvSqYVsNfRQuchvZ1h5y/yS+/uRZjbZmygOeK0VSAtTCoYAgtgueXNvKHEFUP9julacuwK74gTOzyAnPUcKfuhYSpL+LsUa9BaPBnmEh9bu4j6fz5O26MDvGBY+MIqOLMD2nN+CbCSSS5eu7tyvrN5pm4FElK0rVHuXNmjnXx3leC00q4AJJ+uKJ+/VMzAJncDkFDZkXBLoMFfbzvbIkd3BAYanoPUszm14coUkXmwlZ2dX9oZ+hDUBEPxq8PwjJMkw6fpdPxrrKeRCIf2Q5LflXc9L6SMEu6zNEUsWuXN7Uici3QmmT6vMYJloWypRnlTN+JKm/IgftVSvuogrLXgHza7eiW6gmPju/BrUo7/6TNbAdn4y7/DxDh4Q8dIDz1QM6CFNkaK1XJArBMF6IaDfbYCZiquVQvSVmh+OCopHwMg1d8gxUvL8LfgRN2qGjo0RjyY7iSjCM8faxdwCawLRtn+yY4uXcHRHp2TzH9BF6xIKROgb6/LQQ/AQ5YKJxpcroExp3fXt3Fxj6iXcqh/egN/TcSxlWYRITdcYDbJjCSMbgsqlbsmGDab7s/F1CmrjAd9bNiDTT4OD9a9XM74ImkWysc9dOC76z/JB1in8k5NsmWPiADBPwDpfHNJX9i0UetvX40QmqwFFZ2NaXkicXy3JnbENNMN3WbVXTalpUutN8viP1RevlnW5xgjMxcMQ2WL8h7MRNDa+vMFMxw1D7l+YKV8eBDfUsNJcdaxEKhgFk+zm+w+PZzWsbCDzvPh+ubTTNLMKA7d69z8TIIfgWXAmIfvjoJbi128EujlkVm4gBaGhM8ut8EOwlJP7qNe5oyB0WGdA67eRMzae1gOKyUPhLuhbTkN31xooBulxVnI4rFRFeLKAm1A46VOZ5U0kLpNoCXGPFUwHVmlM6xe+51U3KaLGOdFN4A4u++AZ22iWV c4snZCR/ /5epICBxrL+sGiFc3j0OLbH9vQ4tAgYTWPaHeAb0xghAikEPlWhddnyTZ1bGV82kugi00ZymwkFY/WW1w0/roL78/H8zpaeRvPn8Vvb304GwAX1xP1T40KBJbRX0R+qQf3cVgLR8K1zU0GFXHGPPL3OBJ+MXxBj1cWpW6jNmvYxrG4SLiqabaNZpMwQUflEhWycy1LTUR5LbHYVxWbHCvuCEs962s2f4rSqGNRQXfZm5/cP0NMdlnOX/EHzIrhXQCTRTql3C11P8esHkvDrk2Jv4E1/HvYYWl0sd5qQfnjmeG3FnStbF5s5UTQY2URG+3aQQDe+zW5YGqxPPumt8uApui4eA5RTnRNDJGrciEIVLXvLc8KBCzMN9PJRHA3J+wWq/CoA+TgwJRciyB/FcPkDs4+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000424, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Jun 12, 2024, at 16:29, Oscar Salvador wrote: >=20 > dequeue_hugetlb_folio_nodemask() expects a preferred node where to get = the > hugetlb page from. > It does not expect, though, users to pass NUMA_NO_NODE, otherwise we = will > get trash when trying to get the zonelist from that node. > All current users are careful enough to not pass NUMA_NO_NODE, but > it opens the door for new users to get this wrong since it is not > documented [0]. > Guard against this by getting the local nid if NUMA_NO_NODE was = passed. >=20 > [0] = https://lore.kernel.org/linux-mm/0000000000004f12bb061a9acf07@google.com/ >=20 > Closes: = https://lore.kernel.org/linux-mm/0000000000004f12bb061a9acf07@google.com/ > Reported-and-tested-by: = syzbot+569ed13f4054f271087b@syzkaller.appspotmail.com > Signed-off-by: Oscar Salvador Reviewed-by: Muchun Song Thanks.=