From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx153.postini.com [74.125.245.153]) by kanga.kvack.org (Postfix) with SMTP id 6F1F16B0033 for ; Mon, 16 Sep 2013 17:28:12 -0400 (EDT) Message-ID: <5237617F.6010107@jp.fujitsu.com> Date: Mon, 16 Sep 2013 15:52:31 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [RESEND PATCH v5 1/4] mm/vmalloc: don't set area->caller twice References: <1379202342-23140-1-git-send-email-liwanp@linux.vnet.ibm.com> In-Reply-To: <1379202342-23140-1-git-send-email-liwanp@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: liwanp@linux.vnet.ibm.com Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, rientjes@google.com, kosaki.motohiro@jp.fujitsu.com, zhangyanfei@cn.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org On 9/14/2013 7:45 PM, Wanpeng Li wrote: > Changelog: > *v1 -> v2: rebase against mmotm tree > > The caller address has already been set in set_vmalloc_vm(), there's no need setup_vmalloc_vm() > to set it again in __vmalloc_area_node. > > Reviewed-by: Zhang Yanfei > Signed-off-by: Wanpeng Li > --- > mm/vmalloc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 1074543..d78d117 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > pages = kmalloc_node(array_size, nested_gfp, node); > } > area->pages = pages; > - area->caller = caller; > if (!area->pages) { > remove_vm_area(area->addr); > kfree(area); Then, __vmalloc_area_node() no longer need "caller" argument. It can use area->caller instead. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org