From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49EBEC3DA5D for ; Tue, 23 Jul 2024 01:48:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6F7F6B007B; Mon, 22 Jul 2024 21:48:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1F556B0083; Mon, 22 Jul 2024 21:48:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0D9D6B0085; Mon, 22 Jul 2024 21:48:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 829F26B007B for ; Mon, 22 Jul 2024 21:48:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA6D6C1ABD for ; Tue, 23 Jul 2024 01:48:41 +0000 (UTC) X-FDA: 82369333242.21.619C1F7 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id 2401B14001A for ; Tue, 23 Jul 2024 01:48:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721699297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=koNwivg14Ckygbggwv7dKkt4LOt/wQbCzSfXzAre6Tw=; b=ZYh7gzQlcGo544EwQiLGhqO927wJ1io91VoAT3pBY9Aznx1BRbzmf5jy3hxj9K4NCmJ5L6 d0k2+TGX96KkvhIVzSoKLXOnnX3ai5erMW15xnEHF/Y86A1OG0G6XZB0/O9a8baNOuS2q2 hO46nBzlcWtZYJg5m8gzl6DrHmr+t1o= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721699297; a=rsa-sha256; cv=none; b=jIv8YDyzDKLZ8ALyAUBHwabta3zITa7JY3WEHo7SikcjsKfWk4tG49IYTRqQ0IQ9VdfDE7 yhy6kEv1X0CGgBDmN5W4SvnrC3xGa9CvT+/Dyy9y+XgL5z2JgN1ajlNmrhQ0KMgeSvKY1W w+MqJRH2Xq3GltDU+WOHUE17wUbaS2c= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WSg480jxzzdjrt; Tue, 23 Jul 2024 09:46:48 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 8C90F18005F; Tue, 23 Jul 2024 09:48:34 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 23 Jul 2024 09:48:34 +0800 Message-ID: <5230d72e-81fa-4ef1-b386-90bd3b06bf0e@huawei.com> Date: Tue, 23 Jul 2024 09:48:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. Content-Language: en-US To: Zi Yan , Andrew Morton , CC: David Hildenbrand , "Huang, Ying" , Baolin Wang , References: <20240722172917.503370-1-ziy@nvidia.com> <20240722172917.503370-3-ziy@nvidia.com> From: Kefeng Wang In-Reply-To: <20240722172917.503370-3-ziy@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2401B14001A X-Stat-Signature: k1n9bnugmx4s6e6rbajg9g44wnufs39y X-HE-Tag: 1721699318-280751 X-HE-Meta: U2FsdGVkX1+uwIZtCP/GGbR+jM7x6EXuMxb3kP+9jZxi6+QCjDtBwc1BBDKQ4p/8TvpL1oXTRcVPrCNtkEQjPxLdZsrn1r/ngnMBOXmoquoHT0sv626HGFlv8uxB2kftuJXt3dYovC1R9hJHdW23g50JBZnGsSwQg4WYXvRivZi5SiYrr3cS5UGIec9PC2kBfsMByWVClEUGViKDBhEq770sC/Tlm1vsuUY7c0MRu7jIM9IiG2NGjubWVUYBVOQDnn0TcrXQKrxxyIfiPngDCtmO4Ogf3VFg/Gq/Sco2kJ7N7Ks/4my6TkrHf+MG6PWbfVsA95Knivn2WLdj6hyxU1+7koO1ZXJoBjriHRE1XGHCEpJk0hJ8UfbQcvm0lXDy4YSCNpAyCY5GIbwbG1nOJRsx8RJy8cn2fcigPvXkrVqNRi6MOAo+6NNDxH5YUfhBNkKM0tIzR0L5yXHDcjfa8g3eBPSYcBxURiXRuz1H4463j4SMvO04kKBk20krfAJ6sA8PraBOXjs54mKH25D9D070StK5Rt82BbmKooFut+9jGvsjJWFXjxSKc29J7gNppc7ojsh9HogIV9/IPmSxNSim9rOfQfCY72+0wBjyAW0XpT5/DIov5EzKmcYzj3Tk5V+keIJXjRcjoKL2UPiY88kjhV8LynQA3if6ZghIXR+85Mb9F7CmWDen0V4UvEQ5xsHKRvo8nmgKDUY6UpfiFPHdGAiGhkdu/tOLJgPYP+bqNWWtwjuyR2HKtU3X5sT8QJLbCPTOSceEFV90W6Vp99ZiC0sSrqWPiI7okF9AJFbdXWj1BgORGpYCYryADrCR11TuzYOiv1YnFDWpPXYZxrg0o3NBxJno0Lp/EJiWlbdbBzzVRURrmy/G7RArn/vYgewjnDujgiKzEJwskNovCttAv0SfLUo1gE1wqo456oVFYFzY484mNTSIfaPscJMaUYJogVMjhAiw4++DGYM yV3d5WpU M4OVXndYsBcc5MhJNOLoghPNfkotcRihN9+0gdg/RxnGFDYaa8Vdz/801ggG2UftB5EkwEWXShj0V6/DB5N+b11ryNdK41Sk+t4d5BeFe3D6uMJLKldyKDjY8IwSf8ra0FayEkFP+znVHMsczk2uX0xws6UeEjL+4vcnTVnOXmUKGv069e8esy+PbErtGRuWYHL22vwDJx4DgZ0diBbw85DEfAuS4x78hTpy6IwPNbv69NwgT6FlW0v0N9yW5C/CbTT+w8EhdsYovlZltBWBrHPD+dzWW1jAexYr6ibp/sLr+IXTkkEzKMVwcQsgfvf5XALJv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/23 1:29, Zi Yan wrote: > memory tiering can be enabled/disabled at runtime and > sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check > it. In migrate_misplaced_folio(), the check is missing when > PGPROMOTE_SUCCESS is incremented. Add the missing check. > > Reported-by: Kefeng Wang > Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/ > Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") > Signed-off-by: Zi Yan Reviewed-by: Kefeng Wang > --- > mm/migrate.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index bdbb5bb04c91..b819809da470 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, > putback_movable_pages(&migratepages); > if (nr_succeeded) { > count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); > - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) > + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) > + && !node_is_toptier(folio_nid(folio)) > + && node_is_toptier(node)) > mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, > nr_succeeded); The should be in advance of patch2, and change above to use folio_has_cpupid() helper() too. > }