From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05DD8C46467 for ; Thu, 19 Jan 2023 22:40:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C89A6B007B; Thu, 19 Jan 2023 17:40:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 978C26B007D; Thu, 19 Jan 2023 17:40:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8418E6B0080; Thu, 19 Jan 2023 17:40:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 72F836B007B for ; Thu, 19 Jan 2023 17:40:50 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3FD93AAE87 for ; Thu, 19 Jan 2023 22:40:50 +0000 (UTC) X-FDA: 80373019860.18.1BD4EF1 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) by imf06.hostedemail.com (Postfix) with ESMTP id 319B5180011 for ; Thu, 19 Jan 2023 22:40:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=D36vBhjx; spf=pass (imf06.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.54 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674168047; a=rsa-sha256; cv=pass; b=VAuQPGMrRNdX3EnO7kK3Nd65xtztHyhNvsVLA5CIo2SelF3zi8ZLGbq6BP1eI9ZSbMbsHL TPf9q48xjAapzsocZuP94eHTQ+MyGK1YIn34p6w1upC9s82ojP+QwEfZmr91uNE5yLUBV8 bGWTimpZoUF2S2/piAwJuMkscUP1JHY= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=D36vBhjx; spf=pass (imf06.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.54 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674168047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AGdvgnJX749Usr8qnBeuH+xJW0+FuXivn4ZnEdhb4U0=; b=FwV1t4a2iHNfDLRctIDPiOrS7bhngkVgN8xOE+cF8Zm/aBKYqPnqPafk92YinaTCaeCTq3 4LOKpk3U6T/bjRhfKCweRGvBYhF1c8yGHI2u2ujYYwDRKsEyqoIOme71KRU/wVtunSQ2Kq 1Wj5YOM0iEtwek2PtV/zuMAsFl5iieQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdtcVPT6bbBgMNs9b82rqjxJdS1CLXFVvhvQUNT0h26fXqnKkJ7VZAZyPoMibfwpgmEyYQ/eKrp6/WsJZlcfM8ypElaRmtFG45jmzXlq7/LRusiIlOk5LgtuLYFbRv/g7unnxqDhJ3tcUYCCSf+6R3lFn0jBD3+teI8Jg9A3SFMi0gf74/wj8qci9xoF6opwU00h1RGcacimbK9XqUxXVCKGjfk53bukc5+KTDPClw/hSG6SoxIBiAVAPMhx9jSK9zQzoWAWD2/UzuR3xWkTA4aoGwx51xovzRxtnaohDAuVXtgTt/lOk21ugspVgVlHkJ42tJHjyQk4FS8aFKUkBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AGdvgnJX749Usr8qnBeuH+xJW0+FuXivn4ZnEdhb4U0=; b=jzhjtGf1rvMxIkPjPVzRgZTwpTjv1V9oZOCClr8pfwyD+vT4wHwRYiUFm5CcnVKcdLSkdNfPg+TYeGZxVlqt6UmmYBKGzY/h1TG11X17oRHB7QdbcoNteyzHarPCvqBzDm9DV98MEvnWZl0Y73F2v+QsnSIPgQ7e08swVYrPJEDqRaqh4wUmBoHUxAK9UOE2dgcYoGiZQjTmHXEMExOWUnAJKTWc9Rf3hzDI51YPIvVSi1VqPMkLEZ4+9Aqz3TTrCbwz2OiiTrcXDvhe0uF4fgnxtWlNU3KKAK/uhnZv34hCppMnCWiEbgIDAgvPuveBhoIit4vJIgh59Dd+utMeyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kvack.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGdvgnJX749Usr8qnBeuH+xJW0+FuXivn4ZnEdhb4U0=; b=D36vBhjxNtD6GrE4cb+FM3my7YF0oAz6FlVgDAIgG39P/tF0CoKFXiVLysSamqDs09PQjnjnWG8iQETdnwZ2nV3fEPxyHmaydER4rj3HUfaDcwsjEkHZ8AQAzjoh5hZ4J5rGU3S322oJRrrUc8/0ZjPv3shU2KPRrrV2a1mhoe+D8x9dNGsrQxRiSg1sNn5ZLzKGmPAzjRNQ78tG2dvk/cM92ik9HAK9uI5JYF/wC9Zw+yi6KEBzrk+Rr/OU4a2lwcMejU1ljr2Jx3gsgV+JH0uWEqnSQYYAudT+e0al3CJiQN8bllGycBW02/HtQiNJwACA5UtcrvOIlszfxU4Seg== Received: from DM6PR06CA0082.namprd06.prod.outlook.com (2603:10b6:5:336::15) by DM8PR12MB5496.namprd12.prod.outlook.com (2603:10b6:8:38::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.26; Thu, 19 Jan 2023 22:40:44 +0000 Received: from DM6NAM11FT113.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::f7) by DM6PR06CA0082.outlook.office365.com (2603:10b6:5:336::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.25 via Frontend Transport; Thu, 19 Jan 2023 22:40:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT113.mail.protection.outlook.com (10.13.173.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.16 via Frontend Transport; Thu, 19 Jan 2023 22:40:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 19 Jan 2023 14:40:33 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 19 Jan 2023 14:40:32 -0800 Message-ID: <522af666-e219-893a-22db-fde1739f9404@nvidia.com> Date: Thu, 19 Jan 2023 14:40:32 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/8] mm/gup: have internal functions get the mmap_read_lock() Content-Language: en-US From: John Hubbard To: Jason Gunthorpe CC: Alistair Popple , References: <1-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> <6b1f8b54-031f-d0ea-f393-86f5a23aa93d@nvidia.com> In-Reply-To: <6b1f8b54-031f-d0ea-f393-86f5a23aa93d@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT113:EE_|DM8PR12MB5496:EE_ X-MS-Office365-Filtering-Correlation-Id: df4e0774-4c13-4752-98c6-08dafa6e33a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QiwTlpF0drCFOptOtNs3zG2uP7IcPS+kDmsO2Bu2+E+YubsbH6ht7KAl+Bn6+pyvYijMWD+29a+M6jZkKYrM3hh44AMnI6EO8eXX1IDuZz2LPmj0Zid9ZfkruuPsxBxODQOP2mnQka/il87hWrun23R2DDw7hFP9tM5gJAWLKa1dzH5edbUf5iGxw1cnJAaGIunbM89Xm07TY5Y8FHXWdREEsVHBj09ZlLQbvKw4NmzSSvV5UNUqsecige4ADACM6V5FykmNxSr+BQ0sOM+hRfwmyfGUKqvnn0YVGMhzS4anOJeJupMcSuARN72cpKk1HKPqw/GfG+BQUMe6JpwnRIICJL0C+GYR2TWP3PIFBJJVTKTCukB0UVGWld0eC/ZLmVde6nCHbBEEMHatdg32/lCORs/yfNcLp9vUCFvwKFp4fwFJZj9bfwHbPP/HVZnpZPaqpBl0t/5Mx9O9sDqmYDwwXEyxASRt1Uez2D9Vt/6UDeVToLeLP/0UN9zpyMNIPoYxo5HeTWCD0yJyBZ7QlX1pY3FwcFyoJfUJHdoIclvmyaAnSq74yeSHrp3e92KIPH2vcNNiZpZMRhNnFoUHWOTd4Dd/xG2FjGLm/has7ZbubQCSGTgEXBfGR9OfyzicXG8GdSlQBwo0PTxgP3iLtTFVKI3lztrcBv5WTiVHgWquug/kA3ODMG9JqLR7w/G0I3dRuNqkCkUMzhiIT5/hH33OtdcFHjWuTqFRyAhxTrA6r8NxzeF8t2Hma5ZtBJOIV9OSZYNElHfgGQC1S+jLxw== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(82310400005)(31696002)(356005)(31686004)(40480700001)(36860700001)(53546011)(478600001)(336012)(86362001)(2906002)(37006003)(316002)(16576012)(54906003)(4326008)(5660300002)(82740400003)(2616005)(6636002)(70206006)(70586007)(40460700003)(4744005)(47076005)(83380400001)(7636003)(426003)(8936002)(6862004)(41300700001)(8676002)(186003)(26005)(16526019)(36756003)(15583001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 22:40:44.4777 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df4e0774-4c13-4752-98c6-08dafa6e33a5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT113.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5496 X-Rspam-User: X-Rspamd-Queue-Id: 319B5180011 X-Rspamd-Server: rspam01 X-Stat-Signature: yypnhkqj18insmwzye5uwkksskd46jg6 X-HE-Tag: 1674168046-432478 X-HE-Meta: U2FsdGVkX1/BZy8xjhwEe6H1e+/rKhTzd7DHrOuaJ/k0HceQ9c6Jb7ejv46ENflaJMDAJJ+pXJvheKn0gvlij5GukOqfK8s2nsRVUbnJZ/3qyrytUMz9RPmjbX4opvGPG5DB4FiwS9pMuDw96n2UoZcfE3myFyf4HxMbdrsvVv/gi7i3XfPQGjt4GSIAncNN39ah1YRz01WXddtQv80dNn7oZpnK5QhtzOzzzJF6iS+0pYE1U1Ah9a4KFOXZOUiLk4deM+vq4FsuTloRt4unduUWswXQSbtZi8xrE8fWTirfZ9hPyhKnF3zEpqy8RrT2oufiY0k2JKmBI4j6VOPRRW8M5OHYEgx9Zk8KRtr8O03lBcCRvTthgQg2zRALNd+Aec38Rgs/+RXEgh4y0ETgvk8gVvHw3OtxsOT4BF0OxMfV9Lrln98X1I691uFgm9n25qixsbRi8H1uJcrmD7Bcr7J5H+4IWETiq7aRFvWiEmGsw2ELFGVofR3YXFBWSNRUoyEbMZh5cRQPF2WgyOyjkGyTnCnaCsIqgpaApLIJXl1uAOf+g168y5s3HF+PjT4/47i1Zm/+3oARbKK5I6QsWYkYlojIS+tHyNqzLqswDNwW6pzbWEOVxTITkDpC2fubYgORuvTLGSZXjTT8rDtI254WzivIGEv53IWKgHOYZHeod+7cxbn+24qxbz8K7YMUWgzPjNhJYkkzX9VHMFdRQJN91wrq3BxDhSLFG/ESJiWRNsxMYRu4S5+3Jcel4tYx+uw7CeE0d25/fl3xNxFfYwAcz6oXRtq+72t6WWxfM8lTXmXL+2793KN29Ti/hq5O2xzzAOt6GtKGopvZM9+jML7nKE+4R3r2Kgb3CpTu1PWneV7oVo7h+zdAskA0iA9JA1KjA3MiIG9FWg+XXfvFJeWfEftPcdALNG4qtty7iMTlA2IfNFjyeAc5z8MnmSXqFWQ2qFGf5XMD5VY1pPG R+I6+7sY diAyjgZHJtFZpTCzr9KafnAxIFZNyHDoCuyc+tOJZWWBYavi0EOUvTEVllbZ7ddYuhqjet9pnodg9dnfr5kzs77DdG9P8B4WFf9n/QVbpissW9rCNZJjYlXcIERBvltOPKsczjShWnGWzwXZdsJd0sFYt9m6YoXm4FIFUxGcN3YjzFVghWFUgqnfflqG4N2jKmyxUuUzurI9QIBZWqQFNPaddH04yzGXoPsH2t2Y16TYbumFLJGeOYi2MPlLkr+9PzajOR1PtfyrZVYSZ/i56jD6D9375tePk3f+T4IPpppfNljiT5jNICQtlDtM10q9GvMtapjKp7qVHVFaDuJhyN8OVOE0qVNdfCb5Fa1S1atOgQP8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/19/23 13:19, John Hubbard wrote: ... >  long __get_user_pages_locked(struct mm_struct *mm, >                          unsigned long start, > @@ -1343,7 +1352,7 @@ long __get_user_pages_locked(struct mm_struct *mm, >                          unsigned int flags) Shoot, this diff won't apply without a fix-up, because the above is actually supposed to be: static __always_inline long __get_user_pages_locked(struct mm_struct *mm, ...but I had a local patch applied on top, to remove all the static keywords for functions in gup.c, thus in turn allowing my function graphing tool to work. It draws helpful pictures of the evolving call graph, but "static" hides things from it, due to using gcc's output for this. And since most gup.c functions are static, it was awkward... Anyway, apologies for letting the tooling noise leak into my response. "It will never happen again." I hope. :) thanks, -- John Hubbard NVIDIA