From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx114.postini.com [74.125.245.114]) by kanga.kvack.org (Postfix) with SMTP id 993BB6B0031 for ; Mon, 9 Sep 2013 02:09:47 -0400 (EDT) Received: from m4.gw.fujitsu.co.jp (unknown [10.0.50.74]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id A1D7F3EE0C1 for ; Mon, 9 Sep 2013 15:09:45 +0900 (JST) Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id EA5F445DE58 for ; Mon, 9 Sep 2013 15:09:44 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id D12EB45DE50 for ; Mon, 9 Sep 2013 15:09:44 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id C26061DB803B for ; Mon, 9 Sep 2013 15:09:44 +0900 (JST) Received: from g01jpfmpwkw01.exch.g01.fujitsu.local (g01jpfmpwkw01.exch.g01.fujitsu.local [10.0.193.38]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 7161F1DB8042 for ; Mon, 9 Sep 2013 15:09:44 +0900 (JST) Message-ID: <522D65F3.2030400@jp.fujitsu.com> Date: Mon, 9 Sep 2013 15:08:51 +0900 From: Yasuaki Ishimatsu MIME-Version: 1.0 Subject: Re: [PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb() References: <522D4038.7010609@huawei.com> In-Reply-To: <522D4038.7010609@huawei.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Xishi Qiu Cc: Andrew Morton , Wen Congyang , Tang Chen , Toshi Kani , linux-mm@kvack.org, LKML , kosaki.motohiro@gmail.com [CCing Kosaki since he maintains mm/memory_hotplug.c] (2013/09/09 12:27), Xishi Qiu wrote: > Function is_memblock_offlined() return 1 means memory block is offlined, > but is_memblock_offlined_cb() return 1 means memory block is not offlined, > this will confuse somebody, so rename the function. > > Signed-off-by: Xishi Qiu > Acked-by: Yasuaki Ishimatsu > --- I have not acked your previous patch yet. But this patch seems good to me. So I acked the patch. Thanks, Yasuaki Ishimatsu > mm/memory_hotplug.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index ca1dd3a..85f80b7 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn, > } > > #ifdef CONFIG_MEMORY_HOTREMOVE > -static int is_memblock_offlined_cb(struct memory_block *mem, void *arg) > +static int check_memblock_offlined_cb(struct memory_block *mem, void *arg) > { > int ret = !is_memblock_offlined(mem); > > @@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size) > * if this is not the case. > */ > ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL, > - is_memblock_offlined_cb); > + check_memblock_offlined_cb); > if (ret) { > unlock_memory_hotplug(); > BUG(); > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org