linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Huan Yang <link@vivo.com>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@linux-foundation.org, bingbu.cao@linux.intel.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	lorenzo.stoakes@oracle.com, opensource.kernel@vivo.com,
	rppt@kernel.org, ryan.roberts@arm.com, urezki@gmail.com,
	ziy@nvidia.com, vivek.kasireddy@intel.com
Subject: Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns
Date: Tue, 18 Mar 2025 16:20:17 +0800	[thread overview]
Message-ID: <5229b24f-1984-4225-ae03-8b952de56e3b@vivo.com> (raw)
In-Reply-To: <20250318064805.GA16121@lst.de>

HI Christoph

在 2025/3/18 14:48, Christoph Hellwig 写道:
> So you want a folio based version of vmap.  Please work on that instead

The folio-based vmap implementation you mentioned may indeed be necessary, but it has limited

direct relevance to the specific issue I'm currently addressing.

> of doing crazy hacks using vmap_pfns which is just for memory not

I mentioned that if we use HVO-based hugetlb, we cannot access the page structures corresponding to

the physical memory that needs to be mapped.

This prevents us from properly invoking vmap, which is why we have turned to using vmap_pfn instead.

Even if a folio-based vmap is implemented, it still cannot handle mapping multiple folio ranges of physical

memory to vmalloc regions. A range of folio is important, it maybe an offset in memfd, no need entire folio.

So, I still consider vmap_pfn to be the optimal solution for this specific scenario. :)

> historically backed by pages and now folios.

So by HVO, it also not backed by pages, only contains folio head, each tail pfn's page struct go away.

Do I misunderstood this part? Please correct me.

Thank you

Huan Yang




  reply	other threads:[~2025-03-18  8:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  6:15 Huan Yang
2025-03-12  6:18 ` Christoph Hellwig
2025-03-17  2:12   ` Huan Yang
2025-03-17  5:29     ` Bingbu Cao
2025-03-17  5:53       ` Christoph Hellwig
2025-03-17  7:42         ` Huan Yang
2025-03-18  6:48           ` Christoph Hellwig
2025-03-18  8:20             ` Huan Yang [this message]
2025-03-18  8:33               ` Christoph Hellwig
2025-03-18  8:39                 ` Huan Yang
2025-03-18  8:44                   ` Christoph Hellwig
2025-03-18  8:50                     ` Huan Yang
     [not found]                     ` <20250319050359.3484-1-hdanton@sina.com>
2025-03-19  8:08                       ` Christoph Hellwig
     [not found]                       ` <20250319112651.3502-1-hdanton@sina.com>
2025-03-24  2:13                         ` Huan Yang
2025-03-25  6:32                           ` Kasireddy, Vivek
2025-03-25  6:46                             ` Bingbu Cao
2025-03-27 13:40                           ` Matthew Wilcox
2025-03-28  6:13                             ` Huan Yang
2025-03-19  9:09                     ` Gao Xiang
2025-03-20  5:31                       ` Christoph Hellwig
2025-03-24  2:22                         ` Huan Yang
2025-03-24  2:57                 ` Matthew Wilcox
2025-03-17  6:26       ` Huan Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5229b24f-1984-4225-ae03-8b952de56e3b@vivo.com \
    --to=link@vivo.com \
    --cc=akpm@linux-foundation.org \
    --cc=bingbu.cao@linux.intel.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=opensource.kernel@vivo.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=urezki@gmail.com \
    --cc=vivek.kasireddy@intel.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox