From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFC3C19F2D for ; Tue, 9 Aug 2022 23:05:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84D098E0002; Tue, 9 Aug 2022 19:05:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FCC68E0001; Tue, 9 Aug 2022 19:05:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C4328E0002; Tue, 9 Aug 2022 19:05:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 59B918E0001 for ; Tue, 9 Aug 2022 19:05:46 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 306C21C6A5F for ; Tue, 9 Aug 2022 23:05:46 +0000 (UTC) X-FDA: 79781588292.23.B635C83 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf31.hostedemail.com (Postfix) with ESMTP id 16CEB2016F for ; Tue, 9 Aug 2022 23:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660086344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YQQjxvyb8CLjve4FfHQqn1TrKDgNJT0ViQGm4zbKbG8=; b=iDHgo/TEfP/kJb/LHLr5ntQZkaiNGLHZX9JCEA0NaJgTgEZAb+8FSaSzrSQRu/3fv3qMot EqSBfG6Tx3xLk1CEAsLenPyJmRUbnKb74nTA0OEa8op28uAViw9703ORP/yoB3+A8gLtRA RjONeCtp0c4oNETy8Qt9ij/4eWHbxIE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-Z4DTJHyIO2Kbdfdv2o53dg-1; Tue, 09 Aug 2022 19:05:39 -0400 X-MC-Unique: Z4DTJHyIO2Kbdfdv2o53dg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C7E078117B0; Tue, 9 Aug 2022 23:05:38 +0000 (UTC) Received: from [10.22.18.32] (unknown [10.22.18.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F910492C3B; Tue, 9 Aug 2022 23:05:38 +0000 (UTC) Message-ID: <521f2fbe-3732-0829-3562-2b113eb7b7e4@redhat.com> Date: Tue, 9 Aug 2022 19:05:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm/slab_common: Deleting kobject in kmem_cache_destroy() without holding slab_mutex/cpu_hotplug_lock Content-Language: en-US To: Roman Gushchin Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220809205901.76595-1-longman@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660086345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YQQjxvyb8CLjve4FfHQqn1TrKDgNJT0ViQGm4zbKbG8=; b=AQczxQSMmQsPALSeR1Ni3O+4/bzD/41wyKS4IucXRjx+vPazDGB4HpoF21xB36X1nZVhpU tkiczZvRcsqjCdVFd/lQYXIY+40nRD/bZ9ZWaGuSnTKT8BDA9IvsYLSjygdk2RJbPUh9Nv 33aWtl0KHiVFlGWPgDzJlb5cafl4JOo= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iDHgo/TE"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf31.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660086345; a=rsa-sha256; cv=none; b=2R8BvxhYly4ovMMqXp0oz8A1Qu03R/DxyyFbZgv4gcvQm+/M3Ct6bmNPZE7OsXdGH3Id4G liT4Gnbjud17NVJ1tyeABonXkXiu1S7zU72W4bypw835mYVreoPCZlUtjTMud3i7lOwGKu n6QynkFgRYf1YXzK+Et0StNGD84QN88= X-Rspamd-Queue-Id: 16CEB2016F X-Rspamd-Server: rspam03 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iDHgo/TE"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf31.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com X-Stat-Signature: 4u3br9frqiotpz8fn9a1hwtfy8jgkoc6 X-HE-Tag: 1660086344-924230 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/9/22 18:25, Roman Gushchin wrote: > On Tue, Aug 09, 2022 at 04:59:01PM -0400, Waiman Long wrote: >> A circular locking problem is reported by lockdep due to the following >> circular locking dependency. >> >> +--> cpu_hotplug_lock --> slab_mutex --> kn->active#126 --+ >> | | >> +---------------------------------------------------------+ >> >> One way to break this circular locking chain is to avoid holding >> cpu_hotplug_lock and slab_mutex while deleting the kobject in >> sysfs_slab_unlink() which should be equivalent to doing a write_lock >> and write_unlock pair of the kn->active virtual lock. >> >> Since the kobject structures are not protected by slab_mutex or the >> cpu_hotplug_lock, we can certainly release those locks before doing >> the delete operation. >> >> Move sysfs_slab_unlink() and sysfs_slab_release() to the newly >> created kmem_cache_release() and call it outside the slab_mutex & >> cpu_hotplug_lock critical sections. >> >> Signed-off-by: Waiman Long >> --- >> mm/slab_common.c | 48 +++++++++++++++++++++++++++++++----------------- >> 1 file changed, 31 insertions(+), 17 deletions(-) >> >> diff --git a/mm/slab_common.c b/mm/slab_common.c >> index 17996649cfe3..9274fb03563e 100644 >> --- a/mm/slab_common.c >> +++ b/mm/slab_common.c >> @@ -392,6 +392,30 @@ kmem_cache_create(const char *name, unsigned int size, unsigned int align, >> } >> EXPORT_SYMBOL(kmem_cache_create); >> >> +#ifdef SLAB_SUPPORTS_SYSFS >> +/* >> + * For a given kmem_cache, kmem_cache_destroy() should only be called >> + * once or there will be a use-after-free problem. The actual deletion >> + * and release of the kobject does not need slab_mutex or cpu_hotplug_lock >> + * protection. So they are now done without holding those locks. >> + */ >> +static void kmem_cache_release(struct kmem_cache *s, bool workfn) >> +{ >> + if (!workfn) >> + sysfs_slab_unlink(s); >> + >> + if (workfn || !(s->flags & SLAB_TYPESAFE_BY_RCU)) >> + sysfs_slab_release(s); >> + else >> + schedule_work(&slab_caches_to_rcu_destroy_work); >> +} >> +#else >> +static inline void kmem_cache_release(struct kmem_cache *s, bool workfn) >> +{ >> + slab_kmem_cache_release(s); >> +} >> +#endif >> + >> static void slab_caches_to_rcu_destroy_workfn(struct work_struct *work) >> { >> LIST_HEAD(to_destroy); >> @@ -418,11 +442,7 @@ static void slab_caches_to_rcu_destroy_workfn(struct work_struct *work) >> list_for_each_entry_safe(s, s2, &to_destroy, list) { >> debugfs_slab_release(s); >> kfence_shutdown_cache(s); >> -#ifdef SLAB_SUPPORTS_SYSFS >> - sysfs_slab_release(s); >> -#else >> - slab_kmem_cache_release(s); >> -#endif >> + kmem_cache_release(s, true); > Hi Waiman! > > As I understand, with SLAB_SUPPORTS_SYSFS kmem_cache_release() can effectively call > into itself: first it's called with workfn == false from shutdown_cache() and > then optionally it's scheduled to call itself from a work context with > workfn == true just to call sysfs_slab_release(). Is it right? > > If !SLAB_SUPPORTS_SYSFS, shutdown_cache() optionally adds kmem_cache to the > slab_caches_to_rcu_destroy list and calls kmem_cache_release(s, false) == > slab_kmem_cache_release(). How it's then removed from the list? > > Overall the patch is a bit hard to follow (not like this code was easy to read > before, so can't blame the patch). But I wonder if it will make things simpler > to decouple kmem_cache_release(workfn == true) and kmem_cache_release(workfn == false) > into 2 different helpers? Or at least add a bold comment on how things are supposed > to work. > > Thanks! You are right. I agree that it can be hard to read. Simpler is always better. Will post a v2 with the change suggested. Thanks, Longman