From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx106.postini.com [74.125.245.106]) by kanga.kvack.org (Postfix) with SMTP id 9C3ED6B0034 for ; Wed, 21 Aug 2013 01:49:23 -0400 (EDT) Message-ID: <521454A6.1000306@asianux.com> Date: Wed, 21 Aug 2013 13:48:22 +0800 From: Chen Gang MIME-Version: 1.0 Subject: Re: [PATCH 0/3] mm: shmem: check the return value of mpol_to_str() References: <5212E8DF.5020209@asianux.com> <20130820053036.GB18673@moon> <52130194.4030903@asianux.com> <20130820064730.GD18673@moon> <52131F48.1030002@asianux.com> <52132011.60501@asianux.com> <52132432.3050308@asianux.com> <20130820082516.GE18673@moon> <52142422.9050209@asianux.com> <20130821053142.GQ18673@moon> In-Reply-To: <20130821053142.GQ18673@moon> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Cyrill Gorcunov Cc: Chen Gang , Mel Gorman , kosaki.motohiro@jp.fujitsu.com, riel@redhat.com, hughd@google.com, xemul@parallels.com, rientjes@google.com, Wanpeng Li , Andrew Morton , linux-mm@kvack.org, "linux-kernel@vger.kernel.org" On 08/21/2013 01:31 PM, Cyrill Gorcunov wrote: > On Wed, Aug 21, 2013 at 10:21:22AM +0800, Chen Gang wrote: >> mpol_to_str() may fail, and not fill the buffer (e.g. -EINVAL), so need >> check about it, or buffer may not be zero based, and next seq_printf() >> will cause issue. >> >> Signed-off-by: Chen Gang >> Cc: Cyrill Gorcunov > > Looks good to me, thanks! > > Reviewed-by: Cyrill Gorcunov > Thanks. > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- Chen Gang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org