From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D46BECAAD4 for ; Mon, 29 Aug 2022 08:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2EF9940008; Mon, 29 Aug 2022 04:32:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDE4B940007; Mon, 29 Aug 2022 04:32:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCD2B940008; Mon, 29 Aug 2022 04:32:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CF441940007 for ; Mon, 29 Aug 2022 04:32:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 960C61A02CD for ; Mon, 29 Aug 2022 08:32:57 +0000 (UTC) X-FDA: 79851964794.20.472BCBE Received: from 189.cn (ptr.189.cn [183.61.185.103]) by imf15.hostedemail.com (Postfix) with ESMTP id 5D0A2A001C for ; Mon, 29 Aug 2022 08:32:54 +0000 (UTC) HMM_SOURCE_IP:10.64.8.43:56878.266017777 HMM_ATTACHE_NUM:0000 HMM_SOURCE_TYPE:SMTP Received: from clientip-123.150.8.42 (unknown [10.64.8.43]) by 189.cn (HERMES) with SMTP id F26B61001F8; Mon, 29 Aug 2022 16:32:48 +0800 (CST) Received: from ([123.150.8.42]) by gateway-153622-dep-84fc4d489d-2xtjd with ESMTP id cfadb1fba75e4e5c839080c542a553f1 for rppt@kernel.org; Mon, 29 Aug 2022 16:32:49 CST X-Transaction-ID: cfadb1fba75e4e5c839080c542a553f1 X-Real-From: chensong_2000@189.cn X-Receive-IP: 123.150.8.42 X-MEDUSA-Status: 0 Message-ID: <520fb512-8d2f-15e1-fd00-a7343e136d1c@189.cn> Date: Mon, 29 Aug 2022 16:32:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] tools/testing/memblock: define pr_warn_ratelimited Content-Language: en-US To: Mike Rapoport Cc: karolinadrobnik@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1661755140-3331-1-git-send-email-chensong_2000@189.cn> From: Song Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661761977; a=rsa-sha256; cv=none; b=GDmlKb0Va/PNnvu8A5hSnFKlJIxgEVZ2/jJS+htF9E/13Wx2aQy74eru4V2ut1PbMSCxqq DFhmgsEPCsRdTL5MNdZ4db0HkHxp+3UwchCiyN9+GW3JK+aMn8EhidzMVWQhTmgo6or9te yzuQlxu16hFamibUTeiH5LKVOU7fPNI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of chensong_2000@189.cn designates 183.61.185.103 as permitted sender) smtp.mailfrom=chensong_2000@189.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661761977; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=brn+i0RGSr66Y7V9Lhz/jBW5CDBgD1RagItonVH6F7Y=; b=kSHTE3XaWBV03kO+oI6MptKuGhnotO+fotKQNB3gQ5AQJenmopANPc1et01oI0szitdNZu KKQXBoQPQuivXE5glxkx/D7zjUBYr8flgA4ZDSoRy7kjAHgupQR7dRf/hCnHtOgBbiLaW/ ku9NOcMExI6noWveu83p84eSy/kJZ8Q= X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of chensong_2000@189.cn designates 183.61.185.103 as permitted sender) smtp.mailfrom=chensong_2000@189.cn; dmarc=none X-Rspamd-Server: rspam08 X-Stat-Signature: qsif5w61ezmbmoe9ynj7em4794f7meos X-Rspamd-Queue-Id: 5D0A2A001C X-HE-Tag: 1661761974-528981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.217773, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, 在 2022/8/29 16:24, Mike Rapoport 写道: > On Mon, Aug 29, 2022 at 02:39:00PM +0800, Song Chen wrote: >> Commit 14d9a675fd0d("mm: Ratelimited mirrored memory related warning >> messages") introduced pr_warn_ratelimited in memblock.c, which breaks >> tools/test/memblock, below is the message: >> >> /usr/bin/ld: memblock.o: in function `memblock_find_in_range.constprop.0': >> memblock.c:(.text+0x4603): undefined reference to `pr_warn_ratelimited' >> /usr/bin/ld: memblock.o: in function `memblock_alloc_range_nid': >> memblock.c:(.text+0x786a): undefined reference to `pr_warn_ratelimited' >> collect2: error: ld returned 1 exit status >> >> A fake pr_warn_ratelimited needs to be defined in printk.h like other >> prink functions. > > This is fixed by commit 0a7e91528202 ("memblock tests: fix compilation errors") Is there a commit taking care of 902c2d91582c(mirrored_kernelcore) ? it brakes memblock test too. If not, i have fixed it and will send a patch soon. Song > >> Signed-off-by: Song Chen >> --- >