From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F348C43334 for ; Tue, 12 Jul 2022 08:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43CD0940054; Tue, 12 Jul 2022 04:13:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EB6D940033; Tue, 12 Jul 2022 04:13:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DA83940054; Tue, 12 Jul 2022 04:13:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1DCD7940033 for ; Tue, 12 Jul 2022 04:13:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id DEA5B80D02 for ; Tue, 12 Jul 2022 08:13:04 +0000 (UTC) X-FDA: 79677732288.22.9344554 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 5C0431C0070 for ; Tue, 12 Jul 2022 08:13:04 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F4891516; Tue, 12 Jul 2022 01:13:03 -0700 (PDT) Received: from [10.162.42.8] (unknown [10.162.42.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A4F973F73D; Tue, 12 Jul 2022 01:13:00 -0700 (PDT) Message-ID: <520e487b-a274-9b92-b01b-164ee9a2b6c3@arm.com> Date: Tue, 12 Jul 2022 13:42:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] hugetlb: fix memoryleak in hugetlb_mcopy_atomic_pte Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org, mike.kravetz@oracle.com, songmuchun@bytedance.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220709092629.54291-1-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220709092629.54291-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657613584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gXgXKINvCz/zc7AFNavq3Aumvr8bGnCxLGQmretaSDI=; b=f4Ngk5F8rKIMyCIaCqVVl0ZQQaVSH8tba+3lM5XPlNAlVcEIIqkVkDxBliw7mnfaXOOO2o G2uE5/6b92iDCYLgr1+1HzGb+tumXZ2zFMSkUMG0X4bWCWwZTryzXiKHQiU70rGUXA6asb U/E3NjklCVjtqrGXhQxKYNVQcztqkcs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657613584; a=rsa-sha256; cv=none; b=Bj638hZYpPQD6uwo9m7SR/5OFqgPnOiTiymdF/CVrzuZhyJva+SeoS2uDcOVVD+05Zt01s qnn+pxRC3jNxJMf3/c1vVZCKSq8vgQtPD1VRGHIQ11bMa2/LOAHbLMHub6rfgCcVA7tr76 9ku+rUxRQceCqJ3Izw9aXwSeQS3o3c8= X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Stat-Signature: i6x75wow668qf1jsk53bhhixhhr1bpnj X-Rspamd-Queue-Id: 5C0431C0070 X-Rspamd-Server: rspam04 X-HE-Tag: 1657613584-591080 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/9/22 14:56, Miaohe Lin wrote: > When alloc_huge_page fails, *pagep is set to NULL without put_page first. > So the hugepage indicated by *pagep is leaked. > > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY") > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > mm/hugetlb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 06c2d86b1ba3..598c37279fee 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5962,6 +5962,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, > > page = alloc_huge_page(dst_vma, dst_addr, 0); > if (IS_ERR(page)) { > + put_page(*pagep); > ret = -ENOMEM; > *pagep = NULL; > goto out;