From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx105.postini.com [74.125.245.105]) by kanga.kvack.org (Postfix) with SMTP id 7D4686B0033 for ; Thu, 8 Aug 2013 08:19:38 -0400 (EDT) Message-ID: <52038C84.4080608@cn.fujitsu.com> Date: Thu, 08 Aug 2013 20:18:12 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH part2 3/4] acpi: Remove "continue" in macro INVALID_TABLE(). References: <1375938239-18769-1-git-send-email-tangchen@cn.fujitsu.com> <1375938239-18769-4-git-send-email-tangchen@cn.fujitsu.com> <1375939646.2424.132.camel@joe-AO722> In-Reply-To: <1375939646.2424.132.camel@joe-AO722> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: Joe Perches Cc: robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org Hi Joe, On 08/08/2013 01:27 PM, Joe Perches wrote: > On Thu, 2013-08-08 at 13:03 +0800, Tang Chen wrote: > >> Change it to the style like other macros: >> >> #define INVALID_TABLE(x, path, name) \ >> do { pr_err("ACPI OVERRIDE: " x " [%s%s]\n", path, name); } while (0) > > Single statement macros do _not_ need to use > "do { foo(); } while (0)" > and should be written as > "foo()" OK, will remove the do {} while (0). But I think we'd better keep the macro, or rename it to something more meaningful. At least we can use it to avoid adding "ACPI OVERRIDE:" prefix every time. Maybe this is why it is defined. Thanks. :) > >> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > [] >> @@ -564,8 +564,8 @@ static const char * const table_sigs[] = { >> ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, NULL }; >> >> /* Non-fatal errors: Affected tables/files are ignored */ >> -#define INVALID_TABLE(x, path, name) \ >> - { pr_err("ACPI OVERRIDE: " x " [%s%s]\n", path, name); continue; } >> +#define ACPI_INVALID_TABLE(x, path, name) \ >> + do { pr_err("ACPI OVERRIDE: " x " [%s%s]\n", path, name); } while (0) > > Just remove the silly macro altogether > >> @@ -593,9 +593,11 @@ void __init acpi_initrd_override(void *data, size_t size) > [] >> - if (file.size< sizeof(struct acpi_table_header)) >> - INVALID_TABLE("Table smaller than ACPI header", >> + if (file.size< sizeof(struct acpi_table_header)) { >> + ACPI_INVALID_TABLE("Table smaller than ACPI header", >> cpio_path, file.name); > > and use the normal style > > pr_err("ACPI OVERRIDE: Table smaller than ACPI header [%s%s]\n", > cpio_path, file.name); > >> @@ -603,15 +605,21 @@ void __init acpi_initrd_override(void *data, size_t size) > > etc... > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org