From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17117C77B7C for ; Fri, 26 May 2023 08:29:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1B67900002; Fri, 26 May 2023 04:29:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CBC56B0074; Fri, 26 May 2023 04:29:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CF0900002; Fri, 26 May 2023 04:29:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 756C76B0072 for ; Fri, 26 May 2023 04:29:32 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 499F8120DB3 for ; Fri, 26 May 2023 08:29:32 +0000 (UTC) X-FDA: 80831732184.09.222902F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 447B6160008 for ; Fri, 26 May 2023 08:29:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cFhpiHDK; spf=pass (imf08.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685089770; a=rsa-sha256; cv=none; b=cFiyzz2pZUKxSX8A7yXVsUhoLpCgG2fqvj2L5Y5WLAP7XcQxc5Qr1VPp2R5uf32kA52nTE ilJnswaONq3u4M+f+S2Sap0hK2uCuVEV87BnSrJD7BrCdEkx0d01/P/SyGIZcbQfrWHpiG L0PcbbPDjJMaCGwk9K+zUmreSE6oXcg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cFhpiHDK; spf=pass (imf08.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685089770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c892gmHnFnyJknfSVBWfjI1O+CRXJGRWy+yybVQO/8A=; b=c5I2UtVru3he8UVmWx40mjzRqWx4CnECrSWBMtJVXTFapL1Q1TKIhjOdpuKcVYpubyS8f5 MTeohTt4cSGNYRNbBGtRaE4x/MD0JTn3ASoT3nguTJR23lVbV50ZUWqRTGMDtq8FS3WpA2 hZMwnhS7mpQiw/nMURE/53tiz4gNKec= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685089769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c892gmHnFnyJknfSVBWfjI1O+CRXJGRWy+yybVQO/8A=; b=cFhpiHDKvo2x30cHJRaNGprlQFTAO3McevsP04WM2OfEZqoTAc0i9aD3LH08lgvX+O2vDB 0oygoi+qFsh4WfDggal4J31geI6S76sVDWNqYBLo/CUzhGCNxJzv1sSjEUD6dx4qho6Vir DdeQMiZ/GxHHva9iqa6Y/50qcKnfOh4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-436-bQLEo4I9MN6xV7hqaz2Y0Q-1; Fri, 26 May 2023 04:29:24 -0400 X-MC-Unique: bQLEo4I9MN6xV7hqaz2Y0Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0A07538035A6; Fri, 26 May 2023 08:29:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C9D19D7A; Fri, 26 May 2023 08:29:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230525223953.225496-1-dhowells@redhat.com> <20230525223953.225496-2-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, David Hildenbrand , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [RFC PATCH v2 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <520321.1685089759.1@warthog.procyon.org.uk> Date: Fri, 26 May 2023 09:29:19 +0100 Message-ID: <520322.1685089759@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 447B6160008 X-Stat-Signature: raczx7rh8xa8q1zcdfabxmb8fy3oo4gk X-Rspam-User: X-HE-Tag: 1685089770-66042 X-HE-Meta: U2FsdGVkX1+hRC89wM7KzTd7ep4XdjPZ90992+qqHrn4/YAeg944zw59rxhuhJ9gBLVeh4wvImFM4HfIw0L2YffWrrjvwHksq+see9OPAM66xIOsDQOOoAmcCCLTE/OIpbcL0U832lu9N3M5i20B/PWwt+yYSB4kf7EgASityXtI5oou5Blvm5Yi0rdy1Vt28BqTJtFK2ezeh5iivV1/oklmERRc9p3C7V6aQcdn4vIzGVY+kPxMdaMfq1vr7neAP14vB8E8PKw5Z+PIFm41ftU1RbQgy86ng0oZTIcdBmfxzYn4hfKwmiYZGYXcNfhXEDFE8dCj1Y4k0DjR4RzLlIEEMobsxlG6CJjg62K/UQqIbp+oewP1i1uBRQgUWHfZBIv/XPYmA8qo9Cl9wYIM+DGDUcH7dhU0q6GjQlRp7t9wZiF4uhenV48Di63ijCz/k74Z6T0RE1L1pOhAmf20UcUwYlaJtBA5p16TGaO+UuAZMIkar61z6jlIbWLZsa+vVJ1EkjHCc9rZFkVi/ApfvyV5ZrIhGpi1ILijK7BWY/SAE5P7PHRLYqbdz+P3sINx75WptnBXDftnpqd039i5QMu11OBbzXGSfSS4MIk7B1E4QmHZUF/oQm5FnqfSk4WfiOlGu7e514tUmjLLiAL4FAUfYandyTY8i881lYvBx9F2hzi2q3If3C2zaanjNLoO92Ao7XbiVNOxJpF5V5RyqI50lEa/hQnD0ibtG/NFSJqDb9AOO40oRVOgQ+JWEzkFqlhmOsRDcCRdXYDSnnmGzXR1kF/6wT1H+BbdtFABjo/eilV7zdIYZtrRXaN0oKxJYkwFLuyO0/eK7S9bbP99g+A6hO7V+USc+ffJ0lNqu5GpczdFV+k69WVPt6y79Q6Yz47PB9M5PoFnvxCSDV7igqN0iY0C9QuFNFGP49qg00p1JgCX5KAQ9BZxwTRczpvzHprWg0ixs4ZeC1KnB0A lJ60O7Pi f5j89oAUGp5ATxr2zXhnOelDwUUY6P+f2xYzIgHuvThDi3ggsXkVolpEi+vxWM5896LwrI2ksLpm0x66y8GYlU2SBJtvdZ9ve0z6vl9oulVUKQKJYFPOv6BmA/i20t1gxpUHgpGVPRdU7i/0d7RFvTh8IjjwjH3VqV8YzLhUtCrMYaIfHJzBPC1sui7r4SDcX8hSOg1sVM+J8nxZc+TQpqLdFqoXiiRRy9W8Ys6LA3YV9hXfHMQFh3Npzcsc6X1Fvj89z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > Shouldn't unpin_user_pages It calls gup_put_folio() which is where the skip is. > and bio_release_page also be updated to skip a zero page here? Porbably best to leave it to unpin_user_page() there. I've tried to hide the behaviour entirely within gup.c. David