From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx130.postini.com [74.125.245.130]) by kanga.kvack.org (Postfix) with SMTP id 67AB66B0039 for ; Tue, 6 Aug 2013 21:39:26 -0400 (EDT) Message-ID: <5201A4F7.4080306@cn.fujitsu.com> Date: Wed, 07 Aug 2013 09:37:59 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH v2 RESEND 11/18] x86, acpi: Try to find SRAT in firmware earlier. References: <1375434877-20704-1-git-send-email-tangchen@cn.fujitsu.com> <1375434877-20704-12-git-send-email-tangchen@cn.fujitsu.com> <1375832015.10300.206.camel@misato.fc.hp.com> In-Reply-To: <1375832015.10300.206.camel@misato.fc.hp.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: Toshi Kani Cc: robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org On 08/07/2013 07:33 AM, Toshi Kani wrote: > On Fri, 2013-08-02 at 17:14 +0800, Tang Chen wrote: >> This patch introduce early_acpi_firmware_srat() to find the >> phys addr of SRAT provided by firmware. And call it in >> find_hotpluggable_memory(). >> >> Since we have initialized acpi_gbl_root_table_list earlier, >> and store all the tables' phys addrs and signatures in it, >> it is easy to find the SRAT. >> >> Signed-off-by: Tang Chen >> Reviewed-by: Zhang Yanfei >> --- >> drivers/acpi/acpica/tbxface.c | 32 ++++++++++++++++++++++++++++++++ >> drivers/acpi/osl.c | 22 ++++++++++++++++++++++ >> include/acpi/acpixf.h | 4 ++++ >> include/linux/acpi.h | 4 ++++ >> mm/memory_hotplug.c | 8 ++++++-- >> 5 files changed, 68 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c > > Please add "ACPICA" to the patch title. This patch also needs to be > reviewed by ACPICA folks. OK, followed. > >> index ad11162..6a92f12 100644 >> --- a/drivers/acpi/acpica/tbxface.c >> +++ b/drivers/acpi/acpica/tbxface.c > > : > >> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c >> index dcbca3e..ec490fe 100644 >> --- a/drivers/acpi/osl.c >> +++ b/drivers/acpi/osl.c >> @@ -53,6 +53,7 @@ >> #include >> #include >> #include >> +#include >> >> #define _COMPONENT ACPI_OS_SERVICES >> ACPI_MODULE_NAME("osl"); >> @@ -760,6 +761,27 @@ void __init acpi_initrd_override(void *data, size_t size) >> } >> #endif /* CONFIG_ACPI_INITRD_TABLE_OVERRIDE */ >> >> +#ifdef CONFIG_ACPI_NUMA >> +/******************************************************************************* >> + * >> + * FUNCTION: early_acpi_firmware_srat >> + * >> + * RETURN: Phys addr of SRAT on success, 0 on error. >> + * >> + * DESCRIPTION: Get the phys addr of SRAT provided by firmware. >> + * >> + ******************************************************************************/ >> +phys_addr_t __init early_acpi_firmware_srat(void) >> +{ >> + struct acpi_table_desc table_desc; >> + >> + if (acpi_get_table_desc(ACPI_SIG_SRAT,&table_desc)) > > This check should use ACPI_FAILURE() macro: > > if (ACPI_FAILURE(acpi_get_table_desc(ACPI_SIG_SRAT,&table_desc)) OK, will change it. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org