From: Tang Chen <tangchen@cn.fujitsu.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl,
lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu,
hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org,
trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com,
wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
mgorman@suse.de, minchan@kernel.org, mina86@mina86.com,
gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com,
lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com,
prarit@redhat.com, zhangyanfei@cn.fujitsu.com,
yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 11/18] x86, acpi: Try to find SRAT in firmware earlier.
Date: Wed, 07 Aug 2013 09:37:59 +0800 [thread overview]
Message-ID: <5201A4F7.4080306@cn.fujitsu.com> (raw)
In-Reply-To: <1375832015.10300.206.camel@misato.fc.hp.com>
On 08/07/2013 07:33 AM, Toshi Kani wrote:
> On Fri, 2013-08-02 at 17:14 +0800, Tang Chen wrote:
>> This patch introduce early_acpi_firmware_srat() to find the
>> phys addr of SRAT provided by firmware. And call it in
>> find_hotpluggable_memory().
>>
>> Since we have initialized acpi_gbl_root_table_list earlier,
>> and store all the tables' phys addrs and signatures in it,
>> it is easy to find the SRAT.
>>
>> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com>
>> Reviewed-by: Zhang Yanfei<zhangyanfei@cn.fujitsu.com>
>> ---
>> drivers/acpi/acpica/tbxface.c | 32 ++++++++++++++++++++++++++++++++
>> drivers/acpi/osl.c | 22 ++++++++++++++++++++++
>> include/acpi/acpixf.h | 4 ++++
>> include/linux/acpi.h | 4 ++++
>> mm/memory_hotplug.c | 8 ++++++--
>> 5 files changed, 68 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c
>
> Please add "ACPICA" to the patch title. This patch also needs to be
> reviewed by ACPICA folks.
OK, followed.
>
>> index ad11162..6a92f12 100644
>> --- a/drivers/acpi/acpica/tbxface.c
>> +++ b/drivers/acpi/acpica/tbxface.c
>
> :
>
>> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
>> index dcbca3e..ec490fe 100644
>> --- a/drivers/acpi/osl.c
>> +++ b/drivers/acpi/osl.c
>> @@ -53,6 +53,7 @@
>> #include<acpi/acpi.h>
>> #include<acpi/acpi_bus.h>
>> #include<acpi/processor.h>
>> +#include<acpi/acpixf.h>
>>
>> #define _COMPONENT ACPI_OS_SERVICES
>> ACPI_MODULE_NAME("osl");
>> @@ -760,6 +761,27 @@ void __init acpi_initrd_override(void *data, size_t size)
>> }
>> #endif /* CONFIG_ACPI_INITRD_TABLE_OVERRIDE */
>>
>> +#ifdef CONFIG_ACPI_NUMA
>> +/*******************************************************************************
>> + *
>> + * FUNCTION: early_acpi_firmware_srat
>> + *
>> + * RETURN: Phys addr of SRAT on success, 0 on error.
>> + *
>> + * DESCRIPTION: Get the phys addr of SRAT provided by firmware.
>> + *
>> + ******************************************************************************/
>> +phys_addr_t __init early_acpi_firmware_srat(void)
>> +{
>> + struct acpi_table_desc table_desc;
>> +
>> + if (acpi_get_table_desc(ACPI_SIG_SRAT,&table_desc))
>
> This check should use ACPI_FAILURE() macro:
>
> if (ACPI_FAILURE(acpi_get_table_desc(ACPI_SIG_SRAT,&table_desc))
OK, will change it.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-07 1:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 9:14 [PATCH v2 RESEND 00/18] Arrange hotpluggable memory as ZONE_MOVABLE Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 01/18] acpi: Print Hot-Pluggable Field in SRAT Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 02/18] earlycpio.c: Fix the confusing comment of find_cpio_data() Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 03/18] acpi: Remove "continue" in macro INVALID_TABLE() Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 04/18] acpi: Introduce acpi_verify_initrd() to check if a table is invalid Tang Chen
2013-08-06 23:02 ` Toshi Kani
2013-08-02 9:14 ` [PATCH v2 RESEND 05/18] x86, ACPICA: Split acpi_boot_table_init() into two parts Tang Chen
2013-08-02 13:00 ` Rafael J. Wysocki
2013-08-05 3:21 ` Tang Chen
2013-08-05 13:26 ` Rafael J. Wysocki
2013-08-05 13:23 ` Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 06/18] x86, acpi, ACPICA: Initialize ACPI root table list earlier Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 07/18] x86, ACPI: Also initialize signature and length when parsing root table Tang Chen
2013-08-02 13:03 ` Rafael J. Wysocki
2013-08-05 1:33 ` Tang Chen
2013-08-05 13:28 ` Rafael J. Wysocki
2013-08-02 9:14 ` [PATCH v2 RESEND 08/18] x86: get pg_data_t's memory from other node Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 09/18] x86: Make get_ramdisk_{image|size}() global Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 10/18] x86, acpi: Try to find if SRAT is overrided earlier Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 11/18] x86, acpi: Try to find SRAT in firmware earlier Tang Chen
2013-08-06 23:33 ` Toshi Kani
2013-08-07 1:37 ` Tang Chen [this message]
2013-08-02 9:14 ` [PATCH v2 RESEND 12/18] x86, acpi, numa, mem_hotplug: Find hotpluggable memory in SRAT memory affinities Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 13/18] x86, numa, mem_hotplug: Skip all the regions the kernel resides in Tang Chen
2013-08-05 6:22 ` Tang Chen
2013-08-05 14:52 ` Tejun Heo
2013-08-05 15:12 ` Zhang Yanfei
2013-08-06 2:29 ` Tang Chen
2013-08-06 15:10 ` Tejun Heo
2013-08-06 2:50 ` Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 14/18] memblock, numa: Introduce flag into memblock Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 15/18] memblock, mem_hotplug: Introduce MEMBLOCK_HOTPLUG flag to mark hotpluggable regions Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 16/18] memblock, mem_hotplug: Make memblock skip hotpluggable regions by default Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 17/18] mem-hotplug: Introduce movablenode boot option to {en|dis}able using SRAT Tang Chen
2013-08-02 9:14 ` [PATCH v2 RESEND 18/18] x86, numa, acpi, memory-hotplug: Make movablenode have higher priority Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5201A4F7.4080306@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=jweiner@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lv.zheng@intel.com \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=trenn@suse.de \
--cc=vasilis.liaskovitis@profitbricks.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yinghai@kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox