From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF78EC433B4 for ; Mon, 26 Apr 2021 11:15:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 306B261177 for ; Mon, 26 Apr 2021 11:15:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 306B261177 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 83B466B006C; Mon, 26 Apr 2021 07:15:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C2206B006E; Mon, 26 Apr 2021 07:15:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6897B6B0070; Mon, 26 Apr 2021 07:15:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 48A1F6B006C for ; Mon, 26 Apr 2021 07:15:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F28031803307A for ; Mon, 26 Apr 2021 11:15:17 +0000 (UTC) X-FDA: 78074261874.19.B33319F Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf09.hostedemail.com (Postfix) with ESMTP id 60131600010F for ; Mon, 26 Apr 2021 11:15:11 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id n2so83809587ejy.7 for ; Mon, 26 Apr 2021 04:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=hnjr3dCi4hCFH0E2IT+UC1Sw0LW27btik6EgV4fSASY=; b=ZK79hNDuTPAnQIcmy5yhMTe1JdyE3pgZxy+8e4WrhCvOmTkDcp9Wt0XowrgUI2TWiM m5eBSeNk0jxFBpCicqW9NSea2ed3Brwl/7gd7uAdsAsDfFqycfEAWtBR8v2tI69eF2fC PcIkBpTFoEWhbrkA5mQkHrZITQfhdgbP8oDls+uQklmfnayKurg7mSze6YRXn6j0Kp3q nNkdKJOKRK5UYMSVgK9QDgFy4TvE2dBnYMwg6lEpkxL06FLR4oA9guRfnAla3+QGX4DF QbeqfX6sAwRS0UIlUYK5MjFPMbeezJrv+sRg1xmudHzEkB8yrqigyp/33ncOddhNwEj/ uaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=hnjr3dCi4hCFH0E2IT+UC1Sw0LW27btik6EgV4fSASY=; b=WRTXHMddA43jcwBVn/J0ViCY6axN3/hD8Yo6r36ofbT3jfMZntlSywhDlL63Y5tn+2 HlWTTb13XaEKkL7SHssoaJ1XmQo5AkxgdwAdJ/aMQmq0GE66RvP1iTPGubFO/kB7XFC/ GzkHZgxV7rOBoyOPI8g9VfzxMWcqM/NJWuVQ9d5WqaqOUv9pL373bdOjIGW1pxhGcJKn r2TxMc8JEZu+S5Ir7FEhRE2HaGbmDW3jtR2gYYBFCR6vIHhtay6eWe6KcmgB4ZzkraNK B4QNi3WaswThvfRfEK7fxvxhkOgsr6kis2XVRREUv3gCU0clnWAJ9MlF9Y94oroF0ZAk Qekg== X-Gm-Message-State: AOAM530Ghba7eRss2Pl7IYh8Bmxx09gOIMVt9RvoRyOfzthrNfN65qnm VA7WffDNxGsAI4kSFMYCf0M= X-Google-Smtp-Source: ABdhPJx81PB9/OFPNLuSjgtYtafdOJTkTTVUWd+LMl4HPtM9iy8wWrNpPZQPwBImYgWHf5jqhZ6V7Q== X-Received: by 2002:a17:907:c0b:: with SMTP id ga11mr17789045ejc.545.1619435716310; Mon, 26 Apr 2021 04:15:16 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:ddf1:e741:577e:9eb2? ([2a02:908:1252:fb60:ddf1:e741:577e:9eb2]) by smtp.gmail.com with ESMTPSA id r25sm13611385edv.78.2021.04.26.04.15.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 04:15:15 -0700 (PDT) Subject: Re: [PATCH 2/2] drm/ttm: optimize the pool shrinker a bit v2 From: =?UTF-8?Q?Christian_K=c3=b6nig?= To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, vbabka@suse.cz, daniel@ffwll.ch, ray.huang@amd.com References: <20210415115624.2904-1-christian.koenig@amd.com> <20210415115624.2904-2-christian.koenig@amd.com> <20210415133310.1ee9df70a9eb887be937c3a3@linux-foundation.org> <57572373-d68c-80de-7f9e-c04239d1b050@gmail.com> Message-ID: <51fe2c43-4f05-5727-1680-b6907d652630@gmail.com> Date: Mon, 26 Apr 2021 13:15:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <57572373-d68c-80de-7f9e-c04239d1b050@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Stat-Signature: r9cjzue4wfru5hsg1yekh387fme4cutn X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 60131600010F Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-ej1-f54.google.com; client-ip=209.85.218.54 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619435711-622739 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just a gentle ping? Are you ok with this explanation Andrew or should I look for a different=20 approach? Thanks, Christian. Am 16.04.21 um 09:08 schrieb Christian K=C3=B6nig: > Am 15.04.21 um 22:33 schrieb Andrew Morton: >> On Thu, 15 Apr 2021 13:56:24 +0200 "Christian K=C3=B6nig"=20 >> wrote: >> >>> @@ -530,6 +525,11 @@ void ttm_pool_fini(struct ttm_pool *pool) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 for (j =3D 0; j < MAX_ORDER; ++j) >>> ttm_pool_type_fini(&pool->caching[i].orders[j]); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> + >>> +=C2=A0=C2=A0=C2=A0 /* We removed the pool types from the LRU, but we= need to also=20 >>> make sure >>> +=C2=A0=C2=A0=C2=A0=C2=A0 * that no shrinker is concurrently freeing = pages from the pool. >>> +=C2=A0=C2=A0=C2=A0=C2=A0 */ >>> +=C2=A0=C2=A0=C2=A0 sync_shrinkers(); >> It isn't immediately clear to me how this works. ttm_pool_fini() has >> already freed all the pages hasn't it?=C2=A0 So why would it care if s= ome >> shrinkers are still playing with the pages? > > Yes ttm_pool_fini() has freed up all pages which had been in the pool=20 > when the function was called. > > But the problem is it is possible that a parallel running shrinker has=20 > taken a page from the pool and is in the process of freeing it up. > > When I return here the pool structure and especially the device=20 > structure are freed while the parallel running shrinker is still using=20 > them. > > I could go for a design where we have one shrinker per device instead,=20 > but that would put a bit to much pressure on the pool in my opinion. > >> Or is it the case that ttm_pool_fini() is assuming that there will be >> some further action against these pages, which requires that shrinkers >> no longer be accessing the pages and which further assumes that future >> shrinker invocations will not be able to look up these pages? >> >> IOW, a bit more explanation about the dynamics here would help! > > Sorry, I'm not a native speaker of English and sometimes still have a=20 > hard time explaining things. > > Regards, > Christian.