From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D94E6C7EE29 for ; Fri, 9 Jun 2023 14:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55AE68E0002; Fri, 9 Jun 2023 10:43:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50B1C6B0074; Fri, 9 Jun 2023 10:43:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D3CA8E0002; Fri, 9 Jun 2023 10:43:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2E1DC6B0072 for ; Fri, 9 Jun 2023 10:43:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB9801A026D for ; Fri, 9 Jun 2023 14:43:01 +0000 (UTC) X-FDA: 80883476562.24.685472A Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf23.hostedemail.com (Postfix) with ESMTP id DC0BB14001E for ; Fri, 9 Jun 2023 14:42:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mFpiqwqW; spf=pass (imf23.hostedemail.com: domain of n.borisov.lkml@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=n.borisov.lkml@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686321780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zO8ENOnSimS6n7gy9/kTHBLX2Up3InmL5+w7nO9x+a4=; b=dByUAMx5XDeNJTts/Nz0I6dyIpbLaN0SmjUulXcTiYmlcWgic4ehy08dilNZjA4iqXaJav Cqemio4KwAz5BhvUyU9TALg5OIBuSmOwEMx72JfK8MHkGDpXEHU18Ge3jJ9IhJzHlLzuU8 qn9JxWq6Nxv76kb/dpG4oOr7u82bp3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686321780; a=rsa-sha256; cv=none; b=P/Y0Swabp6pPdmmJZQFCiHk43nFBwhN+sJl8ZG6QmmZquW7FEDDic45GC8YXAHsZXMOpMu obaSrhGhme66nERUUyHjQg+tAhRlro65mByBIy2Y56OTXeHkF0pZTRrA9jw3Pre9tTFYRx PQXw/qnwP9TaFmOh3NxL/75bUwkyWp0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mFpiqwqW; spf=pass (imf23.hostedemail.com: domain of n.borisov.lkml@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=n.borisov.lkml@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3f732d37d7bso14050325e9.0 for ; Fri, 09 Jun 2023 07:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686321778; x=1688913778; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zO8ENOnSimS6n7gy9/kTHBLX2Up3InmL5+w7nO9x+a4=; b=mFpiqwqWl2vdGhX6AJu3w1NHIIZoQi6trxq0Lqp+ylDiBSnZiasMfSJxrk8StXj146 bsFIpsnfeKf/pNWC/J7X6wDvXx3YJx06hGc/aoUNjRZBE/hojOLO4TolDHwlNlaktdLB HgJSDRPKW625qqxAZHmsfjs0fqEDTf5DUQ51s+DY78dzKkpZzUuTrKbgfipgdJnAplvh 7yUqJSSwDnZ12P5iQD6U38lPC22hA1OGjLKncZsA/O9leoWMO2Znn9bIuG116hNxi/i/ i/D4QRmYjQ8FgsH9xDbo33qHBT4pcYmPKSkqW7tbbY8IkqOCwYxOFtLXo3VsmZ6XSx9b mR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686321778; x=1688913778; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zO8ENOnSimS6n7gy9/kTHBLX2Up3InmL5+w7nO9x+a4=; b=TvS3nxtRpSRu63qO0+GUS3Fj1T7JzxygNhDNh5G7Pj0g9jFrtxvtkfWbjy85aumQDh PSk+uW6KuehcHhZY0ChWJ0P1saN52Ivy/VEHGkV20RCo9tkjyn/94xrPR7+hfXhLdMjY xmlx14cgE9l+6s0//TqflYgEdzrBzSDHluSCxP+I9abhaAWmOKYq0yqcXBb+95jPhQU4 uScDTTcAjRH0kwGG72AnCxsF67Djmww810NHDh6rii3I4CtZSk1kOGtnMqUoQTbLpBbI RngLwQ8w5lpLHYVRvl8uaXU6phXaoZC1/rQHUKvF2LakYPm25W9NdxKURa6r0DyIS1jf 4PeQ== X-Gm-Message-State: AC+VfDyTEQJckUQ7t4NXOkpBImmRvkYg7cfcc/2SWHqCCaroX8ZMlywS PWW+tfIw7QpyFtw7Hz8CP8w= X-Google-Smtp-Source: ACHHUZ7zRycn6Zhb+VOFkhu/NrKADDjabWSSsCk+2juGpn7Kl7FYm9QcZHMOp4VDrTurTF5Mu+KZFw== X-Received: by 2002:adf:fd43:0:b0:309:3df3:8e0f with SMTP id h3-20020adffd43000000b003093df38e0fmr1093526wrs.51.1686321778019; Fri, 09 Jun 2023 07:42:58 -0700 (PDT) Received: from ?IPV6:2a10:bac0:b000:7727:c9f1:3163:7113:1dbf? ([2a10:bac0:b000:7727:c9f1:3163:7113:1dbf]) by smtp.gmail.com with ESMTPSA id x5-20020adff0c5000000b003078a3f3a24sm4637525wro.114.2023.06.09.07.42.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 07:42:57 -0700 (PDT) Message-ID: <51f4c068-7dbc-6f7d-fa49-b98807b74bee@gmail.com> Date: Fri, 9 Jun 2023 17:42:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v11 06/20] x86/virt/tdx: Handle SEAMCALL running out of entropy error Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, dave.hansen@intel.com, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> From: Nikolay Borisov In-Reply-To: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: x4ym95xgxo6sin36g7d69aeurxhnmk1z X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DC0BB14001E X-Rspam-User: X-HE-Tag: 1686321779-228954 X-HE-Meta: U2FsdGVkX19SOxFdXSp9ZNLwDF9EF1EU5ua7OtsdsrStjda+swHci48IuvrWNhqfZvp+O0bF6LJSQ4wKupfyPFGPzyBkGs6kAU7r5x8bVh6p0gu2Ck6GXzBJ2u7CW+nNPEy8zy/NVQrnGIfqJCZjP+JhRVLm0vMq6LCqFP7enn2racd9ZikY8b9TJ5p7OtbeqGeh/Ibt103hzlMeHEMVvOIj/BNkhy1+eR6ZPj389bJaSpxYmodbeZcbKI5oS0nKbIJTk3PiVlkx1cYKUq6YeN4X7hiooYRR6oIJGWUVaTRsXeS9mrRrYhaUVFzaiuaPsemLAdeAI5AlOx9sDFCTEXczE+6HEgOJCUeW41z6Mv4+G5Sc+4gygQcTzLJQFYpmySSFr6fUHPKbCPTOTxXDkJ26DZDgVp+oFzcQAbsSOc6lFslEEmZXutmQEm81iconGf2tZJP4r68xAmAU45LGnS6tUH7qfqcJfqpDPZXdM+NasLlfNFHkex4EZbeaaXjkhf4iZINg6lHf1zPqHbSl4EmramRDtl4VMAbpmVhpVGLOf/LZtFxROWvummUcCJTz1cDXAAbPvdUHHvGTpoDhVhZvtS3BXnFBupBpOD0ImY1nIdV6RP8wWqOyBuZcKvSTa/Bucg3DJ8wch0O+wxRbKEUynKhkARq9Xd66noj1SDVdM4NiRlXi7x1fTNn41QG+WMdE+6FQ/DsMdLv79zzsD/6CXQvo8/7rZeN17yHAxtGp5GL+yDlx5jqtCBWa4ylUeFpn6TCQb7sG3Fc8n785VXwc6eiy59m/iZbHPWQp1xIbL3ff4wzKwaKaZA6vKJXAVIHpcyNnHTgdl0eKbapvhg1KJiRCQRTHZKlNUXU5LNgJZk5up/tpnAatkCLN4dTuI1PiFyhobUPRJfh3tSkNJEaywN7QX3CutVf7OGbeOf8bN0uMw2UQQF2tsvvz766EWk8SM9GMVGh/SgTUmI3 VkQbLLFg 50J7sBoeV8sxMXSlLWQx+sHc/qvuG1WnW8+XhzZvH3QDvEBBezKuXr9CG4NjLSY5Cg/b0TyWnMICmallgXKcBwUxkAoJ7ZvcXSHVjhtHctVQTCfw3RBksiE4cPxB1+PJC9hI4fzc849f++XJspQJ7+fKjRN02irEgEuFQit9dp5tL1SF/AdN+qjyqyPiWeRZ0b1ROF4c2BckFEAS24/30ZIa6Gs6Den3gn+mXV2T9vfo1GiPhSjUH+7TFGmFJXX26Bt0AAxr2fVtHg8Y3+TKAZf0CzdPMQynksOFSRkajxU4bwdlK4N8t4RuzYoJBrXJA/i1YO6EcMbrs8KREMaGP74UCyPi1fEUZz+xOr704Ie+aKnHL/cng/SpIBb69P4ClrWnfRRhFkHvYCV1BfHjRocg5iabVwSFNSgt2so7qHjgHbPIRmxWczOWpjv0RD92GGRAgTGIkr1j5AbKkcoxLXcu0vP4kW40hP6HnBySeTiqmCvAmtgN0e0JF9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4.06.23 г. 17:27 ч., Kai Huang wrote: > Certain SEAMCALL leaf functions may return error due to running out of > entropy, in which case the SEAMCALL should be retried as suggested by > the TDX spec. > > Handle this case in SEAMCALL common function. Mimic the existing > rdrand_long() to retry RDRAND_RETRY_LOOPS times. > > Signed-off-by: Kai Huang > --- > > v10 -> v11: > - New patch > > --- > arch/x86/virt/vmx/tdx/tdx.c | 15 ++++++++++++++- > arch/x86/virt/vmx/tdx/tdx.h | 17 +++++++++++++++++ > 2 files changed, 31 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h > index 48ad1a1ba737..55dbb1b8c971 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.h > +++ b/arch/x86/virt/vmx/tdx/tdx.h > @@ -4,6 +4,23 @@ > > #include > > +/* > + * This file contains both macros and data structures defined by the TDX > + * architecture and Linux defined software data structures and functions. > + * The two should not be mixed together for better readability. The > + * architectural definitions come first. > + */ > + > +/* > + * TDX SEAMCALL error codes > + */ > +#define TDX_RND_NO_ENTROPY 0x8000020300000000ULL Where is this return value documented, in TDX module 1.0 spec there are only: 8000020[123]00000000 specified and there's 80000800 (TDX_KEY_GENERATION_FAILED) and its description mentions the possible failure due to lack of entropy?