From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52852C5B552 for ; Wed, 4 Jun 2025 07:39:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 418E36B059D; Wed, 4 Jun 2025 03:39:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA3B6B059E; Wed, 4 Jun 2025 03:39:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B9FB6B059F; Wed, 4 Jun 2025 03:39:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0AC2F6B059D for ; Wed, 4 Jun 2025 03:39:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 67985EDC6D for ; Wed, 4 Jun 2025 07:39:39 +0000 (UTC) X-FDA: 83516918478.21.F85AB63 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id C2875140006 for ; Wed, 4 Jun 2025 07:39:36 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Up9l/8ey"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749022777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vEeoKlp6F3sCfv0THwxJPcjcYZSfLkHHDxNn+gbXPaA=; b=A5CM9WXE558VkfOzKA/b0MOjyKB6o8cOiN2ykPlqfZi9nizUl+4a2VnC8iRGwxQ89vThOu fqoXynoa3CsViJdFfl0OMkyJpowf6DkcxqndEjidhI9yLZCUMRzH7Vq2pvYLpME2qSHRGd Oszh1fm8XY0Qe2vj30P07sOc4Tt7OVg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Up9l/8ey"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749022777; a=rsa-sha256; cv=none; b=7KMdqUIAIW3fNxYOQFK4dGcQgszG7FvsLiAgf/y+JZoiAA17D8XY70EVqOJ8Pntpe6Ac1/ luKD//SWCGI6xh8Z6SbUUUJA8EcacSllP9hJloyoSs6/7aEmhMyzfQc1eZ08+TrUpzTt2k 0yjaVBZ3cfs4CgfBgoIX7/QSuVSv3nQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749022776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vEeoKlp6F3sCfv0THwxJPcjcYZSfLkHHDxNn+gbXPaA=; b=Up9l/8eypwgdqjt83lTBwudzWbPIb/6gbAVwWyfmXnyLIsb1HgFfeYUv6t9dbtZjR2n5Dq rdsoX2ziceuZs2Y4D7NV4riBbNtzIiNMNZKgTAy3vFhCnVW3i27N44+5eMPmqSroFPZvqk ic4JspNzaaCZaG+0LBY/GsUp1JC6w2s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-UFDznyPyP_ifbOMQ4_NquQ-1; Wed, 04 Jun 2025 03:39:34 -0400 X-MC-Unique: UFDznyPyP_ifbOMQ4_NquQ-1 X-Mimecast-MFC-AGG-ID: UFDznyPyP_ifbOMQ4_NquQ_1749022774 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f8fd1847so1940575f8f.1 for ; Wed, 04 Jun 2025 00:39:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749022774; x=1749627574; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vEeoKlp6F3sCfv0THwxJPcjcYZSfLkHHDxNn+gbXPaA=; b=qdzFzXVQlQImIPZFWzx+JW3Z0N5kkhbL8jRqKytJAU5EVFlBA3Py53erLI4JSAY5jZ 5LA+pAPyJbcig7V66iMbm7w/S70wssc1N/mCuuQ2+XjwS5GSJD+teZM0OFq2qxQg5Xh0 CdREbsGw+wSuJKHkBCAfWMWOxobQtbNhfCPGprX5JC+6AQwdryXmnp1Aff6kCoLTbBb9 ukLO+QKhQ6iVF01deV13g4AFygdnrtFc05y/gph7G2JBhuY6PMkc8HO9CzXuiVlN1xGW X3HhlFtwurHLVJfZKx26wu5zkcVa3heObH1hzoWksUDeKoovkjvy4beHAsDYab8wvctf 5zcQ== X-Forwarded-Encrypted: i=1; AJvYcCXQMs+OicxiR8a22hFig1gQ51LDyDlwA33itbDr986lRH/meIw3iE4p6f6Cx8bI05IqkpMUnpQfkA==@kvack.org X-Gm-Message-State: AOJu0YxJRQxpKlej7RxwuYIw79APpEHleAhZu1KRE6DaHRu3JjBjgVhb tvj54CFXfcAPriZJg5Gdl8INEtc5sCLvjb7W8SWWeOmsFhR7zlYQ7fA/SJx4LdHgfqKt0H4r2k0 ru8yI6vlMZunF/w3oUe+VQytC6WjLWdHS2SJnlWVZm2un56J2kqrB X-Gm-Gg: ASbGncu6xPbnnVoUTdj2PUfBBq0ezoYQ9CJHxOJc7w3pfdBBOpioMoJge3d3JReCpwI Qo2t8SShWswQ/B70x/mUpoCr9dgXNvhnUJax1NgkTlsVmhatvHLVR4enb1wtx6bgZidhQ6yYVMu g7vCOWsyxv2z7638FVvUV09WSiJmAswQ9jnMymKIcBjro9VExgzgWIsrbCz2QJUaI9+Au27ipjd LIm1iBaKXn8hRLzJP+GbvKT46qudctfJLPnxgqkxgm6emcEWhdeq8BCBx33qcLuKftEuzrOlIY7 fGvMrayfNdTByZQCEV8HGU4UbxfHoa62UoH7xPy+Yg== X-Received: by 2002:a05:6000:430a:b0:3a3:652d:1638 with SMTP id ffacd0b85a97d-3a51d96673fmr1049768f8f.48.1749022773627; Wed, 04 Jun 2025 00:39:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtjE45p1dQbMhXKznJNQhD9gzd16Gald/ROfCnxrA2ljBjwOkDtYt1uC7/AKZ2m2XTHTCIeQ== X-Received: by 2002:a05:6000:430a:b0:3a3:652d:1638 with SMTP id ffacd0b85a97d-3a51d96673fmr1049729f8f.48.1749022773213; Wed, 04 Jun 2025 00:39:33 -0700 (PDT) Received: from [192.168.3.141] (p4fe0f831.dip0.t-ipconnect.de. [79.224.248.49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f00972f3sm21121625f8f.69.2025.06.04.00.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 00:39:32 -0700 (PDT) Message-ID: <51ec4269-b132-4163-9cb5-766042a3769d@redhat.com> Date: Wed, 4 Jun 2025 09:39:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts To: Lorenzo Stoakes , Andrew Morton Cc: Barry Song , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Muchun Song , Oscar Salvador , Huacai Chen , WANG Xuerui , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Jann Horn , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org References: <20250603192213.182931-1-lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250603192213.182931-1-lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RdWz0IwFBi_Zk0Ldw3DhxhS34d4frCERcN2tSxQSSAw_1749022774 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C2875140006 X-Stat-Signature: exi9xozb7zmrrnmf43yj6gppp7t5w1s5 X-Rspam-User: X-HE-Tag: 1749022776-973719 X-HE-Meta: U2FsdGVkX197UbcVGuGAI9p+LdnZASn//KHezQgu6Fa5vv8xwIXiDUOa0XLog9+O3RNIPA7wSEWFlYSNLF7jVUyOh8O6VgwG3nL5LwytoCNfyaRW5YON0lKAhLswQ42eNvq/oce3iQOACit348uGXTTbeBJqhy7IrqPYkaTzJmbtePkqKI6730jPLmBql0AMWWpFOkC8/eKWvSThHBg/AF4R283YIm8aBxDhRKPEf/BJty4jTYQPDRzUrDzDExsH73r7PJaUHtDcDt6n0ALj1AB/XWzyYvakq523YRLnyVdexG6tJZqQkzK2DBESl1276PXOYs8Qedg//WUazVt1uiWaokBOqRhZzFrOtP9TD13URIL6uReZDkDBzcjaUWa69UuhJKiBU+ipFMXfMwTsrQmPSzo0F0LKXubjDpDHK3DOflLrtKJVXYG9Feipxphqbsy3ryOGKT+5ftMMlHMKRJGIT4rDiQf90sXoJq6+GmRiPtvaTAm8sLqttB1+SZTRcyhYVTI/QrFg8lmiV2/HEEBjSyipcMj4JaC4kGrD3OiMuXHV0icXcaR/tnTq9foR42rWUwV1rbJ+ibzYXLgVDRzMelRObxFUdQD6OuOoikWuhsyi6ostBrOLIdoiFhINBTfhGwL0ucxr7WjoGK7RuYyRSx0FK+fUi0aQ+CcEkahfTJN30jSb1niFhieBC4o2hTpLJyaQ4BI7BdKksKfM1j88KqhcWu8cqmFJpZnnE4wOMZfwDsdmmKt0ZILgAidyPmfqnbHxvVOZLU/BFpVQzXMlm0evjKCp5JfV1yhuBTH/IzY1GQG7fDN7/XUhk2bOmS9tA+oEAIOx8cF89UrgSUVSmqaeMyVzpyN/O8oxK396yduw3W3NhQIdbDUCmxZRmhFbedm0EjJLIavZ4BIsnH9zq0incfe3sPyOJjiD1mEgbI+0jSoeheiKWhVhGzc+Wl4jal5/Y/VJm0BhO0Z 59y69SJK hvVzHx9kDifppKUZrEzfmtzFqdfUjLpEIYgyDj+XnErN5BX3ErFC9C58aiU4U1Pn7VJZiA57lL2lueCAW/HCKUzr4WsRzqatVMpUBAvF36Q4jusUCpA3mrF3CdkXVakxUmD7E0lu5r1V5/WMGpaIMeWZATSidl/PxjC3f/zC/5um5dX7CHP0nj94lj3Kuzc6hATfNIlegLr8bLyY3JdYwc+mpXoicNV4kWDJD5HrGQD/iYc5302mU3NehEpM/A7odv6g+3yZ+btiFr+AWxlv+Ih8lybjbMzn3xi3vP6XuEt3EAAKwhVTh18msQzKnoFnnGSBcLU6BYGuBlIlh9pjnsGr+/hnZv/qZ6kzEBhf3jorAtF+MJ0YK27ay45+bX+dg5bVhUoKLNEp8qXMXN6uhTUef5u8BI79aq2o7OT3MMMKcV0PmKDpdRaVsyf01r5EtjtkesPcGuZxivOtA+M4or3htoLiMgxDC+IJfSOFoVB3Wq1A7VTtCY26HfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 21:22, Lorenzo Stoakes wrote: > The walk_page_range_novma() function is rather confusing - it supports two > modes, one used often, the other used only for debugging. > > The first mode is the common case of traversal of kernel page tables, which > is what nearly all callers use this for. ... and what people should be using it for 🙂 > > Secondly it provides an unusual debugging interface that allows for the > traversal of page tables in a userland range of memory even for that memory > which is not described by a VMA. > > This is highly unusual and it is far from certain that such page tables > should even exist, but perhaps this is precisely why it is useful as a > debugging mechanism. > > As a result, this is utilised by ptdump only. Historically, things were > reversed - ptdump was the only user, and other parts of the kernel evolved > to use the kernel page table walking here. > > Since we have some complicated and confusing locking rules for the novma > case, it makes sense to separate the two usages into their own functions. > > Doing this also provide self-documentation as to the intent of the caller - > are they doing something rather unusual or are they simply doing a standard > kernel page table walk? > > We therefore maintain walk_page_range_novma() for this single usage, and > document the function as such. If we have to keep this dangerous interface, it should probably be walk_page_range_debug() or walk_page_range_dump() > > Note that ptdump uses the precise same function for kernel walking as a > convenience, so we permit this but make it very explicit by having > walk_page_range_novma() invoke walk_page_range_kernel() in this case. > > We introduce walk_page_range_kernel() for the far more common case of > kernel page table traversal. I wonder if we should give it a completely different name scheme to highlight that this is something completely different. walk_kernel_page_table_range() etc. -- Cheers, David / dhildenb