From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D189BE77183 for ; Mon, 16 Dec 2024 23:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EEA96B00A9; Mon, 16 Dec 2024 18:38:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 574C06B00AA; Mon, 16 Dec 2024 18:38:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A09B6B00AD; Mon, 16 Dec 2024 18:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1605C6B00A9 for ; Mon, 16 Dec 2024 18:38:46 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 802A1C0110 for ; Mon, 16 Dec 2024 23:38:45 +0000 (UTC) X-FDA: 82902438486.10.5494A26 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf11.hostedemail.com (Postfix) with ESMTP id DAE8640005 for ; Mon, 16 Dec 2024 23:38:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Qhqu9WlI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=OMAA4kVK; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1734392294; a=rsa-sha256; cv=pass; b=VMv7SW2V3d2QODQ+K7b5rNI7XSAlXTShkUXOf52foI5up2CTdxozDeS4XOedLCEGSzfbrB ond0WvXED5f/ZKZ0wh8x47qfwyLOe+RmOZ6E9N+BZI3iSyxVocGb4NaJV2KUpUTkrJwHuw PKyjwy6GdXDzsyYa15JokIlOlgkLMeA= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Qhqu9WlI; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=OMAA4kVK; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734392294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oCovIRw/OmBXkD/l1AsAyM1fWl+Hn3dGiOtcgQJw2Kc=; b=du6Uh9XBr+4PucSsbZ4u1W0YPSMRHa7xdSYHMbWaOa6ZEB8sO6D21XAK7oqilFK4ZRg0s3 GvwPYjsQneX8YKBPV5TTrfPJrfZpb0mZ+8k/NiRO+PI4hXSEbjAtBd2LgTjcQvtP4x5zqT riTWJtHAoFNQdgKk6hQ4fF1ubyKUMbI= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BGMjZ2A022798; Mon, 16 Dec 2024 23:38:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=oCovIRw/OmBXkD/l1AsAyM1fWl+Hn3dGiOtcgQJw2Kc=; b= Qhqu9WlILCEsdKCPR5Xq9dRvqUDgWYxi+yQt9UlAbh7m++h8P9xQKzQca0FZimy7 F+XVMb5ZN85aT1FxaSUGiGONEUMk9gBbNMTMeRNDgHu3yVU6rk81H5fQBbXpmu6A fDNwBrj3Ks+u45BMPA4BlkjnzI6gIF5BuQSq1hhz1wS8WJf1SsfdDjBQ5h5IBiFr 1517evYUri8ZxyFbR7eb7tXso5uWdEVLwnY/BW4kav1KfmdfscGYWT5MIer9xCz6 kl1vYhzIEORX8oZ24lDauZDHoRr+nNMYjcSI9+gmn9Guj4HST7gLJIEg0zo3wQfY O8U9LzrLDDu4lzVRtym43g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43h0t2cnr6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Dec 2024 23:38:06 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4BGMmX5b032668; Mon, 16 Dec 2024 23:38:06 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 43h0fdyue2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Dec 2024 23:38:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jVNh+M3ai25n1f3Eu2NVqEJvqsBkocPlB1chRyS7NMifL/y7ks9ykdnEfjBcC+ItCi0MuAkgPjMK0Xzek6Wb0cbKtfynRIxc3U4FNblewLgEMCuz00vhiu6WkLm2fqcAyo4s2kwjJqMqoK2Aqp6O25TFWM+FyVuOd1i/PXKA4bbIDQ19J7ztG3pE2HNXWOk/06eDu9tSQWjZZlO18kiBIohVCVKiBl6pB6qWphksGRVsFN7QaWWztLldQHUTP5g3v+padaoz93seTnwsAL9JjDk/u8Qbyk/NQIFd4rJ/KzN3BVNcBopeuovW+9UaTdwEVWO+98Iq2WODKJl8tPjUrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCovIRw/OmBXkD/l1AsAyM1fWl+Hn3dGiOtcgQJw2Kc=; b=A3tXuPUkvO1ZTQFCE6I9uklWatPCR4Hm6wn6owuYSFVSnXzrxjvh5C1b9TWxuc0jKu3XNSZR846CTzaov6RPGsGHxBMBJOYQ6rzaJYOW2wdqP01fWESBpgQ5+XJtCttJLrhr4Ums8UidqVmkPl7WasyA17GrT4FTHbhM5Fz3RhVKiUgmcQNk8YqOn4Y3Kg/3D2oaGKoboHSGVmQLytqKNo7oXQLcIDHIRK60KlHlt0c4nY3xsf1+BYPVd9kDURat80kn20e5v2Y/jyHqyTt5PBvbfb5Ejib8xUA2v2wrCB6f7nTYSlJIYCFg8hlqCeWxWm9f42X9yW4pEzoseChWyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCovIRw/OmBXkD/l1AsAyM1fWl+Hn3dGiOtcgQJw2Kc=; b=OMAA4kVKwtFWjRdGeydqTH/9vcmlNIKFGVDGK44pmDcfYq8J6Yx4UAj2lG5s0fzoZeoaH3GPwoJ2BnTFfZJ0mO++TUPjgjhLT1WzZy7N0zEf2IxNJASPCwKu21HaCRiYhrHuoz0Qd0Y/RnIbUywXfFHKOFYgPbg1ME9rANiridA= Received: from SA2PR10MB4780.namprd10.prod.outlook.com (2603:10b6:806:118::5) by IA0PR10MB7352.namprd10.prod.outlook.com (2603:10b6:208:40b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.21; Mon, 16 Dec 2024 23:38:03 +0000 Received: from SA2PR10MB4780.namprd10.prod.outlook.com ([fe80::b66:5132:4bd6:3acb]) by SA2PR10MB4780.namprd10.prod.outlook.com ([fe80::b66:5132:4bd6:3acb%6]) with mapi id 15.20.8251.015; Mon, 16 Dec 2024 23:38:02 +0000 Message-ID: <51d231c2-3659-461a-b6c3-d0e7f9fddfc1@oracle.com> Date: Mon, 16 Dec 2024 15:37:58 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 2/3] mm: memory-failure: move return value documentation to function declaration To: Shuai Xue , yazen.ghannam@amd.com, mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, Jonathan.Cameron@Huawei.com, bp@alien8.de, rafael@kernel.org, linux-arm-kernel@lists.infradead.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20241202030527.20586-1-xueshuai@linux.alibaba.com> <20241202030527.20586-3-xueshuai@linux.alibaba.com> Content-Language: en-US From: jane.chu@oracle.com In-Reply-To: <20241202030527.20586-3-xueshuai@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0351.namprd03.prod.outlook.com (2603:10b6:a03:39c::26) To SA2PR10MB4780.namprd10.prod.outlook.com (2603:10b6:806:118::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4780:EE_|IA0PR10MB7352:EE_ X-MS-Office365-Filtering-Correlation-Id: 636f0cff-8cb3-4d0b-265a-08dd1e2aaecb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eExOdFRJQ2U1eGMwTS9heW4yZHo0czdxNG1jWkQwZjQ5WW9QNUtVaCt4aHJW?= =?utf-8?B?STlOTFZEK0lhcXRUSndxSmFwZCswaWZwcTNHNnFldnkvVWZ6SWNnZG90S04y?= =?utf-8?B?VUJQTlA1dkFQYW1WQkJlVnhzM3ZBdzZTREJIOVlZWkxaR0E3OGFRKzkrVGNr?= =?utf-8?B?c00yUlNFaHhkMzQ3VkRIN2d1TWdRbVZuOGtaek5NS1pmSEJLN2FtYUo2ZzNX?= =?utf-8?B?RkFtUzMxaG1KTklhVHZ3Syt3SGhjQ2YrQ2V0WTEwNVdBdWp4bjZMajhlbmJh?= =?utf-8?B?c043T1kybVRaNkl6Q2JtS3BYYUlVMUlRSGVYdWZ3d3djY2FXd0E0eDdycUpl?= =?utf-8?B?RkV0Q29xUW1XYSsrNlNhbFNzNmt2SE5uaGNaYmJmQ1kzeTJoaDdDTVdQMnJV?= =?utf-8?B?RUQvcXBZSUF0bm9YcjBvbnhZc2NQc2I3QXdzeWxuU3NRYXFrTGVQZ3NRMThv?= =?utf-8?B?bklEdEd4ZXdnOVBMbUlqSks0VDM1aUh1QVNlVzJyU3JRVzZpNTBOV2g5QUtN?= =?utf-8?B?QlljdUVkN0ZzR1JmdWhmYzZ2d1huTW11aXFFb212S3J2UjNMeTlHTW1ZYjJi?= =?utf-8?B?M1M2UmdadU1Cb2ZLU1lMMXZPcU5GbGhGY2IvZzNmWGFUSFNaTVl4NVNReVlY?= =?utf-8?B?NkJDMCtyL3BHK2ZMeUVndW5WRUlrRXdGWFV3bVhvTUtFcC93YnYyc0hHcjNK?= =?utf-8?B?TXRUbDBWUGd4djk4ejRQdllpeDdWZTYxUGNXektmZnFVVGg5dU9ZV1d3N3lS?= =?utf-8?B?YWE4LzVGSDJ0bC9SWHdkYktMcUtKd3BGWWJVeEJnY0RoWU9qUkNIaTFKc0Jm?= =?utf-8?B?a0tjb2xpMTJTbjlVN29aMUdGZUw0QXZYbm1xcWVkcWxGQkFUbWE1SGZ2blIx?= =?utf-8?B?a3VYR2NWRTg4MEtUb3BUR3J3S01EZGlYUVYyNEN6QXZHczQwekJFdzFDTU5i?= =?utf-8?B?MVdWNUJlQ3dMTkhma2cxT3VQaDFoOE1vb3hWM0JUOG4vaWFKNlQ5Q0xYK21P?= =?utf-8?B?MW1ScXN1eFE2Z3RGTmZqWnl2Q0JRUUUzSjhNRE5XTDJpMWNFRjY3RXdaZTlN?= =?utf-8?B?NTVzK2dJRTAxbHlNbzF3UGxnRGVlZHNtcHRPZyt2c2J3d2JxM2liV0cvS2k4?= =?utf-8?B?MjRBbmMvck0xeVJhN1V5TzY3SjJjNjV0b2I4QlAxYjJBWnRjTHR2cDhEbzlO?= =?utf-8?B?OVhkNUpGT0pEMXhvMFMvME42Q2ZyaTlkTzBpZXlCbHpLVFFvcEY5SkhWcmtB?= =?utf-8?B?OEpZa2NPQWhYWVpaYTR4VWRYREw3ZHNFOGI1RW9oYXZmVTB0Y0dDRzk4TGxJ?= =?utf-8?B?NTNBNzdsWTY4cm92OTNia3RFbGZFV2craDU5TzRnZzB3ZFJ3QnYwNGZsRGRP?= =?utf-8?B?K2RrdGRqZENVYlI2L1g2bkxDOWNJQzdhZnhqWjkrS3REYno2ZWdnb0Jaald5?= =?utf-8?B?ZzlIU1d1aFgxeHIxSXluMDFMaCsyVVBxYUVrcWNkMnBheWl5N0kycm1OUFh1?= =?utf-8?B?b0xUSzlrMWFXSXg3ZG9XMnJ1NGhTdjVuUjRUZ096YkxibXBNS3ZOWU9Dc2pQ?= =?utf-8?B?cnlRdHNPcE1uY2g0Q0prU3U1UG1nS0lmSi9hSTUyZ0p1eUxjSnpjelNwK05O?= =?utf-8?B?R3ZKclNNSjQxaWJBdjh3ZnZJUG9xc05NWS80N1pDTnFwVmlJOE5aek9xY3dP?= =?utf-8?B?REp1ZUJBbVRhSlRDMEJ2NHIvWXRpV0VuMVBzTWNlRG1US1hmSkYreU56WVky?= =?utf-8?B?S050WmRjMSsyRGJsQ3VuK2VMamJxWHo1Wm44K3FKdlVMNFFWQXhuM3p0WVd2?= =?utf-8?B?TSs3Qnd0UlV4YnZsYStsa0hCOER4WU9rT3UwUi9uU1c3M040THh5eWh5NHVP?= =?utf-8?B?bjVVSmJ1a0ZTV1hKaEZFZFQ3ZWwzSVZWQ1ZUVmVlU0RSajBKQk5jT3h0REVD?= =?utf-8?Q?EEiMIeb30Ms=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR10MB4780.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NE0yc2JFbGZGS01mWFRaWnVQS0pNNmhVeVpod1ZGdzVLeDBoT3dtRjRmdXhl?= =?utf-8?B?QnJzYytOdkZubXJtMWE2ZDAwRW1LT3pUN3luVXN3QlVpQ2U5bHVuK2Y3cW1p?= =?utf-8?B?U2FQRXFDV1M3SW0vVXk4azkxVzNVMU9YZFpRUDk4ZThmL1V5VWsyYkt1djVu?= =?utf-8?B?dW1FSkczaUwxTnBFWXdOVUk2WGhhd0drSHRIelAyb2ZRcng2cVUwS0o2c3pQ?= =?utf-8?B?dURwVmpjakdZZ29uS05XMThWRHdLMkhuQWdQKzN1RDh2dU9Vb2pudFg2TVhy?= =?utf-8?B?NXFuT0JpZzNYOFVQOGRlZjRVcnh5UkhoR3JEUWhKN2ZGeGNOeDhVempxQ3lT?= =?utf-8?B?NUhlWDR5OXJtTklzZ0hCZ3drQ3dZRjBYVW55MnBPbU5XeUJBdWFwWlV0VVhU?= =?utf-8?B?Z3ZieStuNHkrRGNCUTdzUVUzamFvZmtWekgzazV5TkdkbUU5YmtNNlFhUXFy?= =?utf-8?B?SnpuN2M2aFdaUGtrZjhkd2lCR1BEc3YvQmdweXp0OTY1dXY1WXFBbmpDS21D?= =?utf-8?B?OW5EMmhnS3Y1ajJIakVxT1I0VVJ4RmhkeFBGcmdUekZ6WC9TY3ZkdUltN2ta?= =?utf-8?B?MWdyUnpXSm8xcEd5bHNseTVCL2l5TEd2RmxFTjByRFgyZG9TN0VKMDV4VXg0?= =?utf-8?B?Qkh2M2NPaGNqcGRQa042UHdRbDROeVJJZkR2SmtmR2Y0MDFmTTlYUVhnMDlV?= =?utf-8?B?U3IzTVNnaG9tMDVNU0p5SmtXaTh1RldFOHN3bENSMkRMNERibFFka0lmU3ln?= =?utf-8?B?Qm1nQU9yU1U3bk5GZ2tuVXZBSU54S1VnREVaK2NqY1FEY0FtT0ROS1Q4RFFn?= =?utf-8?B?UUpSRkE0UWFPNmZMZkIzNlhhYjRqeVJsYlZOSVFKa1R6NkdvbXBOdHF6TnRJ?= =?utf-8?B?VXhLUzlzbkxTalV6R3NJYUxUSUI2aXNRQ2dSZmgzelRqcnRtWlBNUTVUQTVP?= =?utf-8?B?NURDN3BLVnpxdmZCaThjU3VFWHZnYjRQbVdhOGk3Q3E4WnN4QkJrR0I5eSt1?= =?utf-8?B?SDl6Q0VWbXlqWk45KzZhNGtONDQ0SHZ6bUU1ZGxUNkVpUmg2b3pOcmswRU50?= =?utf-8?B?WThwU0huRDJTUWNaUUQvUXBTdC81cmlxSStxdTgrc3ljNGJVYnpRMDE2NVIx?= =?utf-8?B?QWlVZm5DQWRtcEx2WUpiS1RZWUtwRmVsVi94QThLTjhEV1UvU0hYNmlMSW9P?= =?utf-8?B?NllFUUpzcVBIQWNzT1dNSTdEMFUxV05pM3lwQ1diVk80dEFrRHZjZklZektB?= =?utf-8?B?bnVFdkd4Nm1QN1hqQjYyZTE0MHZKdjhtZzlXeHAxZHpyeEpnZ1NjT0xqSkZj?= =?utf-8?B?S2Fid0hYbVJnZGljMlliOTJybUdWTmtMZU00dXY1Qmw0d1M5TkplNUFZdklO?= =?utf-8?B?V1ZBMXMwYXVpUVN1OE9zV1ZWTE9nNVZjSE9mVjdNckpjZ21aUVVlTW8xOWwx?= =?utf-8?B?dm01b1l6VjM1M0dqaHpuV2dqU2RsZFJPNTc2VXZTQ3QvRWxWeTJleGlvSkV1?= =?utf-8?B?Q1ZVWW5oSmltakxEbHJLVWM1SG1JMk1PMUhuL2Mvcllodll6Y1djUHVUelJY?= =?utf-8?B?VnpOSzFkS0x1Q053c3o3OGpPazJyVUtnc3ZPVG1FSERsYXg5YnIvTWJXWTNE?= =?utf-8?B?a2lMSlV4TzIwMzVXU2pNc0taNXArTlcrQUVtMmlWS2FGUmpCQWhyTXI0QnZ4?= =?utf-8?B?YWVuakkrTDFmS0JtRzhBQmNITk1kS2IyUzBJcHpMVDVsRnRRTDNRVmtocit5?= =?utf-8?B?b0lzOTFVVW13KzAzeFcyYzhqTEtTV2ZmZHZtK296VUVjZmRWM2c5OE01VW5L?= =?utf-8?B?OWljaGIweWJ6S2FXT2huRk94cWtPcktBNmJmUnRsOWc0c2tJR1gvdmVDVlFI?= =?utf-8?B?aCtvVzI1UEh6Qjl2MktJZVk4Y04xVXZDejYxMC9uYWRmdlhJZkpGdjRqZGhO?= =?utf-8?B?b3FUaEJXV0dVSmpERDJvQUpROWNSNW5BelJ5eHBPa25UbHhkYm1vNmFnYncy?= =?utf-8?B?Z3lmZENHQmpMOWhPR3VVRGhZSmcxeDREcWVCU201ZGFiQm9mbjRyejgvcDNG?= =?utf-8?B?aFgyL3NLS01Od0JuSzNmVGlVV0tPV09RQy9EM3BGZ0pWeWMzd05vT2k0S29V?= =?utf-8?Q?NPRJn/UZETftb1IH3uWbxbCE0?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /83Zyr/exHS2OJnsB4n3sWeu8XVFdFoow4YeXJqzqPRXbAxWnoA/vrNB9mC3DVOQ7pNRvYCoyT9wgxqoP4Ko6q462iv5Gebmpq7cKIU9EgW0JGQTLzjkjvxkAOJEuCkKApudLvyB1njG7VOUnrw7IuLGU+9T9NsbVWe7hty8bUoXc/gW2hZG8+HZEd6OtMPInUDThGFxBJNXu+23QTHTBMyJuvFlAvrHpjvD2rizNq9qrwkqKg5or7Jdd1/isDg0yajig1QpfMvVz+q7lhrYhYscFFaosqxmCiugTnOzPaFC/DU1t9S8oGeEnTFA8ePZY+R1bU/uyTDVNWBEBmzctyh6LzEHCUyGCxTMWPZlbQ5/OmmMD7BA9Kdp/+TMiUW1VqDtwc01N1ewC3Con/1Py9p3P7prPAGAgMHkbo/8UmbfklnXmDl1+urM/rE1g7Y5Catg+Xv/kxZtqbERm9stkXGR6QnPQAlblQcBfKY+1tPzG1Zr4VYLMpNRFIaT/iljR5YdaZmr4kLv9uvOyzqOytr4g6zEiT8cf/2fkC08KH455yQ5RDmYw/waqYg75jLn/UPTcDLEETXY6XDIfQ/3D/aHI1mPG6VKY7S3iWCUol4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 636f0cff-8cb3-4d0b-265a-08dd1e2aaecb X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4780.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2024 23:38:02.8700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LyiZ6CnIW8NKQsLkMFlarMu9sdaleCEqtpdm3SZecy9teMgwjVRloV4xPEqUPE9Uwh0e+ucCaSjphXgFARguxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7352 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-12-16_09,2024-12-16_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2412160193 X-Proofpoint-ORIG-GUID: 4qgW32Gxn3Ons6dVNAVLaaKhzwH54U0d X-Proofpoint-GUID: 4qgW32Gxn3Ons6dVNAVLaaKhzwH54U0d X-Stat-Signature: mypdqhwcdyiotsktmx1r4eeyunhwwkix X-Rspam-User: X-Rspamd-Queue-Id: DAE8640005 X-Rspamd-Server: rspam08 X-HE-Tag: 1734392294-849130 X-HE-Meta: U2FsdGVkX1++AXwT6H/yni/4HFhl1b7oNvysAJ8gwmepjXkHyVvKE8A0Qo9wyV3hgGG7tQ2ehaC16Hkkg8usUEM8lhX1hL/eOIc0wJA00j4M3qMP0+xZQc6Ec6HDVMac7EHGiUrm38jJF4scarbRakADlED+a8ZMfI+Svs9fy+y+0S5blJIIKeGbNbMhBO1MJ6P/zf7cO5wvZkkThEk+Aiy1CaAyKb/IfVCRaB9JxUdkHLth8NWpzfEN09l4lzZ42PdGhyFzZNIpld+zEd/vFlSf8MN+n6QYnrlJeSKB4MZ9NhnN9VrZwrkqhk5DXc9Mqaowvz4e77pQwvJGvt9mddwtN/EOxVZNXAKh73gksY6r0DHIxCtY7itzVUnBC2z6S4UpZy9ZEv6jeqrPUQ7b4hvjRt9VWnjluX8gHk5TcEg4pvzYZWHq+lEPfUepRben972Se38mcor3KrRX1FKK1ZPf96YEFEnLR0Syaf4ARDZfunymOD2WURm/mDW3a1x/0gwCHAKDkPlUcJq+jCROVT/UuFrjvuzfk4SKOr95XH2bM7yKKe2AbXg0m0sTg+dumuplqmkjjjhNs8iuBFqCi9Hw0B31S26+9+PaQZAxD5LmnSZ9ULblP/IrJnQCkRGt0+801gmuO8KMARU+kpNyMQIdAj2vfaOeeUvC9JJdlq82YZQfTAIH7r1lxA+bzXJrgNLPtnDcqFUpEL/+HihQ7bRVfqUcs3nUHtlBXPIpoEZ7lI2KsRFKKxXNoVrUoLRIingX4oeYK1n1IW2xT0Xr3PmQK/cK/fHxwegJxbbGCzI9dv/JNaZpF5PnOZQFdkHIw5g3YpuKStKtjTs0ySbNnEjQIYnsGoLorYTp5mlSK2FX2PAAXH76XCF8DxgafofF3P5EbdskWyAh/iVJwiw9Rgy+lHLzd4xlIvLgMqvHd1LjStqDa1Zqwi1VtXqP81NOXRTsKjZECxDBV3A1wJH a8yIS+a+ Vw1b6fjZnAXnF6C8vfmPFeW7AI0TiVLrU9bPsQ92N9AHRQbAmgzMCfiIeN/z1zVrb5mvIdzwOuoIyYOOV4vGfEfRxuy+aXxHk/3/0sKtxQefCUkRDB6rsbW4Z1NMcfODzPOmCWYV6+NZfP8DOMqAERyKTwQU8csIHhDcd1KoBdRbhM7hC5SqguJ9o5VlL8V7lGYufRwGvZWbF17jBVfeo8LwPj+Rb5qLE528BvshqUYc2UvadlgnMthqh5OFWyuFHesQI4EowczUDHU4M22rAh4Sm/IoiTb6lkZ+YW/+4+5PuPm6HlX1uo1EEyQS9I5K6uNva4ZOfsRQrpc29kBOxzzTxA9TEozbPqYJHgdWnVSsdYsayjOPeQYXC0mD4Bhb/zRzmSeCgTnhWW+vGLM0tIzpWAcbv/DssolG0yDDN0UOqa4dhn+vnPzvORXu8JbaCUk3mMa0BYUVTYtVPE9ydSs+3aiMTPiKcLGCyNw9IXYHZsDxL1kPt7PKdU/+2nEVbJNb+KeabaB0lTjzZOpwrdnFoui4/sbO0grW2UhSu8WYVFTT4L24x2PcXOo7DsfNYsTbLuDze/8l5xejWhxf65Z/ewrS/CZamYa93iguHzqJdrOGmXy7aCp7JFc+YsGM6i6jJ8bXSEP6f3Pi8boqT9FKkCrATc+JFQG7/JPV3PpvfGBp3UOTEwa7bwzBe1QSzKaqlp/bA+ByHRrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/1/2024 7:05 PM, Shuai Xue wrote: > Part of return value comments for memory_failure() were originally > documented at the call site. Move those comments to the function > declaration to improve code readability and to provide developers with > immediate access to function usage and return information. > > Signed-off-by: Shuai Xue > Reviewed-by: Jarkko Sakkinen > Reviewed-by: Jonathan Cameron > Reviewed-by: Yazen Ghannam > --- > arch/x86/kernel/cpu/mce/core.c | 7 ------- > mm/memory-failure.c | 10 +++++++--- > 2 files changed, 7 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > index 7fb5556a0b53..d1dd7f892514 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -1398,13 +1398,6 @@ static void kill_me_maybe(struct callback_head *cb) > return; > } > > - /* > - * -EHWPOISON from memory_failure() means that it already sent SIGBUS > - * to the current process with the proper error info, > - * -EOPNOTSUPP means hwpoison_filter() filtered the error event, > - * > - * In both cases, no further processing is required. > - */ > if (ret == -EHWPOISON || ret == -EOPNOTSUPP) > return; > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index a7b8ccd29b6f..14c316d7d38d 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2211,9 +2211,13 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, > * Must run in process context (e.g. a work queue) with interrupts > * enabled and no spinlocks held. > * > - * Return: 0 for successfully handled the memory error, > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, > - * < 0(except -EOPNOTSUPP) on failure. > + * Return: > + * 0 - success, > + * -ENXIO - memory not managed by the kernel > + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, > + * -EHWPOISON - the page was already poisoned, potentially > + * kill process, > + * other negative values - failure. > */ > int memory_failure(unsigned long pfn, int flags) > { Looks good. Reviewed-by: Jane Chu -jane