From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 699BCC7EE23 for ; Fri, 9 Jun 2023 02:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79D588E0002; Thu, 8 Jun 2023 22:50:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74DAD8E0001; Thu, 8 Jun 2023 22:50:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 663AB8E0002; Thu, 8 Jun 2023 22:50:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 579688E0001 for ; Thu, 8 Jun 2023 22:50:24 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1BFBD1602D6 for ; Fri, 9 Jun 2023 02:50:24 +0000 (UTC) X-FDA: 80881680768.03.5BB09AF Received: from out-45.mta1.migadu.com (out-45.mta1.migadu.com [95.215.58.45]) by imf12.hostedemail.com (Postfix) with ESMTP id 2146640009 for ; Fri, 9 Jun 2023 02:50:21 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=erezWzub; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.45 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686279022; a=rsa-sha256; cv=none; b=PxESlWDG36QCj0WdJQU0YDC74TYpVaBZY4MlYlOSf8UEdFfvNRdXh97Qrnx2+b0i6HwNd5 7ZsoVUy57A4DpJbv62MJKRwOgLPTiIYGBYul3VguzbIXxBCtKCQ4UnTJs1vgJg1VdMJwbo 8MbPIrC5NA7eZrqxIko6xsIh8e1HaqI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=erezWzub; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.45 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686279022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=91kh3tFTkOaJY25bw6pXpjQkW2Fhj7YHRJnvq6DamMc=; b=CvFAb16mWWQvMu7i4vpHpw9I8DB2Yv9VKJqInYwgniCblIf0ZPXAMhDmbThqcsJL3oSn0+ Iemw+tCT3qssWAmXj9yEXfKdYeZ+3rX1k75e1G7u+ZvKQhx42FHTOwgaAGfnyXxjHA+KHH hwJCkaufVlqMaKH9fS6bgcSBpswhDVI= Message-ID: <51cbf269-daff-d7b8-653f-7ba388475ab8@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1686279019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91kh3tFTkOaJY25bw6pXpjQkW2Fhj7YHRJnvq6DamMc=; b=erezWzubfqiZyyNGaggPMzlGAh3FNfUsfyDunUTfYykraWAIkxCErvgXdbuVdw1qzSe8qq EamnuObDnVO4mFAHRfhGBw6GuXs8e2NxsBEBTllWy9ubHmkTZapeoixstE8icZjHe5r2uO lfmT682R9NhjDHhUHvZ6z1e7CXr5/FU= Date: Fri, 9 Jun 2023 10:50:11 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v2 3/3] fs: Use delayed shrinker unregistration Content-Language: en-US To: Andrew Morton , Dave Chinner Cc: Theodore Ts'o , Roman Gushchin , Kirill Tkhai , vbabka@suse.cz, viro@zeniv.linux.org.uk, brauner@kernel.org, djwong@kernel.org, hughd@google.com, paulmck@kernel.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qi Zheng References: <168599103578.70911.9402374667983518835.stgit@pro.pro> <168599180526.70911.14606767590861123431.stgit@pro.pro> <20230608163622.GA1435580@mit.edu> <20230608172722.d32733db433d385daa6c11a0@linux-foundation.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: <20230608172722.d32733db433d385daa6c11a0@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2146640009 X-Stat-Signature: dcgwox51e5zontspm9fasb9ihuiq8tak X-HE-Tag: 1686279021-394035 X-HE-Meta: U2FsdGVkX1/uB8Kr6l9rHLRlNW65ZADx+gaZVvL9Th+rI/PyslXmBvKDJaeFlNeEcQ3gipGWyiV48OQBZ80YvVY41sHo5fSffjHcRHS512iBw8KN2mlmaG8t2DVSgHi5BiwQtA7iFd3TPk7oF0fyjt490M+CcBC+0ycDCJZRH6pB9YouDpRdYfRcfgbMBb5xmS3aw9I4Zoqgn7uTTn6aZN2sX8UULe3qYxJ0dk+r/vJC6zFheEzqqEaTKIcq2uCfHFumS6+nbpXa20xX4eSCdB+PWqkOodWaS2Ddo76ZjCTvW58+hxj9ycbSGuCoswICpksO3KapikNdCBYvvqt0jKhFLyq2BZS0Cc4AFdHL0mGOrXHnsxDCDnT2Ug4uEABGsJYdGYIIssqGtLmnt4nvTMKev8lIuUfwiroynW4KkIo9jTkklrnD+beO8lg7ClltX2fgx5v2s+4VIJDzp13gc3mjW12L4Z17XLHXTy77IsBrlJ++6qHmxIyJbbd9G0MeDQKzUvhnoATIUzydw/BSoTso76fCOyBvLS2TGsm0II1PCmZMrbpaq9ykKtwWeGU7tf8QpiPVUv0w0a4rk3E32VmNQPND/N1L7tKS8MC7DHT1EmVtlNnNl/IyRU+YlXgGz174nbXpaBwZpWiEG5Dwzs1T8ou5OA4046D0tsYGXAwDJsKuZflRmlyGil7YsLZDBaYMIomDoSS5UUOtLlAWISt84wMEBVJTIPMQnHDsWrFMtg5OfZ/6LEq+A308nXcSeVmdyqJ8e65IUGsWAv/z8wghaTJqF9Jkp41HB0iDMwar2Y91LlFhdbQXt7uZqlICnpMf/cGxpLcS7ZE6+FbAMfGdBTe61cfFPPPbQMYShMEXdFxYYfthEfwxgEd0sKpNLdkZOqkFCC8hyTlCWCNBIJTwG309yeS+2bM1vSZHgTYNEeD6bu9dUt3HFkEiZWnCZe12xJy7GHrUmaoUl/W 9dCgkhWk dBSOoGsJDu5N/8LxoeTKzoxVbEEgnJyXJm7LoMFlKAZfXLb+Dv/aMRZTIZX0oKnrpGmQ4stUhwQD7fANwy3cZ1TAkXuw+yhJBPEhYWS/iq9Thl3KgRhO5VB5HVujnpUuudbDT1Z7EozPeiNftEdhEX4a101M+rpA6kdmfDSyVSdRlBP4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/9 08:27, Andrew Morton wrote: > On Fri, 9 Jun 2023 09:17:54 +1000 Dave Chinner wrote: > >>> Given that we're at -rc5 now, and the file system folks didn't get >>> consulted until fairly late in the progress, and the fact that this >>> may cause use-after-free problems that could lead to security issues, >>> perhaps we shoould consider reverting the SRCU changeover now, and try >>> again for the next merge window? >> >> Yes, please, because I think we can fix this in a much better way >> and make things a whole lot simpler at the same time. > > Qi Zheng, if agreeable could you please prepare and send reverts of > 475733dda5a ("mm: vmscan: add shrinker_srcu_generation") and of > f95bdb700bc6bb74 ("mm: vmscan: make global slab shrink lockless")? OK. After reading the proposal suggested by Dave, I think it is more feasible. I will revert the previous changes ASAP, and then try to implement Dave's proposal. Thanks, Qi > > Thanks.