From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FF3C19F32 for ; Fri, 7 Mar 2025 07:55:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DB1A280003; Fri, 7 Mar 2025 02:54:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18B66280002; Fri, 7 Mar 2025 02:54:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02C0F280003; Fri, 7 Mar 2025 02:54:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D7A37280002 for ; Fri, 7 Mar 2025 02:54:58 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B92E78065E for ; Fri, 7 Mar 2025 07:55:00 +0000 (UTC) X-FDA: 83193993960.15.0E2DC42 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 4EA8D140007 for ; Fri, 7 Mar 2025 07:54:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=irS0WXDg; spf=pass (imf23.hostedemail.com: domain of jfalempe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jfalempe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741334098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/XjSBrzgKarSUxwTUTP4kt/kMcpFKwcJA5tHsYp7Puk=; b=ICsRMzgCIxLgiM9sfOguLkWH2aKCmYjfIG3WCH2q5rKwmbAozVRWf4V2TjY7UHmNs3tSji I0s2590ersQVzDQNGKNv8mPWGcyfU+y3cxrtBEVhRIth17GU87a/geq+gLbS/G9jI/xFnO mevfGzfl4g1LzxdL8ejYo9vEyKYZu9c= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=irS0WXDg; spf=pass (imf23.hostedemail.com: domain of jfalempe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jfalempe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741334098; a=rsa-sha256; cv=none; b=gmCIe3WjQwRoJtCTAobrXj5otSU6MsAq/LIdXATKPMzDTIueRfCU1x4PhU3aly23c57RTW vC1AEeEIjTzXOgRgGqy4ZRsYXivP7q8Lf13KSWrTbHDFiEBDOGHCXD+kdHcu1EFuxozJxh 6Nem6s2r/QeYZxDy2nse69Ix+j+JhFg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741334097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/XjSBrzgKarSUxwTUTP4kt/kMcpFKwcJA5tHsYp7Puk=; b=irS0WXDg/AGbatsAGuVNipYkhYfktaD/Dzzc7/wYnmPk59ylk6Ud6Hkq0FovfqApdWuWSt YtdD7A5DfKVElpFRGkmzTJRJPG+kFmJy0vL0upjgoF7fQ8j6AZOKyNTkAkJjVv9qkdmTGx lCrpL8NDXFwUTG0159ChDtqOCXRhCl0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-W7v-W1i9MAOPvVztSLFSDw-1; Fri, 07 Mar 2025 02:54:56 -0500 X-MC-Unique: W7v-W1i9MAOPvVztSLFSDw-1 X-Mimecast-MFC-AGG-ID: W7v-W1i9MAOPvVztSLFSDw_1741334095 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-438da39bb69so10866055e9.0 for ; Thu, 06 Mar 2025 23:54:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741334095; x=1741938895; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/XjSBrzgKarSUxwTUTP4kt/kMcpFKwcJA5tHsYp7Puk=; b=sSBW9kOff2sLnTrNkefT6NsKCwnFInKdpSRS3NrdrGzRe54hh/ADb6QB2l4hkfDgka jw4wPZ2/vhOHBJUpEcquXJOSLyJYvfYBS/gu4DNfTw4Bmtl/EGt/YR3UMae0i7/85aQJ fyeDYps789LLKCyswUiI0Kxg8QxpSl7d84pJygA2YDkRRCglMSSjv5bK23xbj49+tdDx 4wymN4NSpFIG0A8GWOuNMM71SG1Vitd64+t+6ymVWzjc0UAXFFT8gAy3Eo/a9vb94ByN dqSD+2Ke5LKEPYxMzt/UNSvliB1RBdvpjH8N35S7f4QchOipN31FZHeJsFq4uSNw0EP/ l57A== X-Forwarded-Encrypted: i=1; AJvYcCWIPrJ+zc8T2YAAgWcSddFQRG+gXS9PVz3x2CXjIPJu2ZDPk3yYSzVNR5cglYJBjA/oEtLRhtr1Gw==@kvack.org X-Gm-Message-State: AOJu0YwcPXATfkAXgJ641wSlnml2LcTObNbOEpoULixIhhT+iG9KwTIH 0XfVFnFC9xjuO/F/kryfS/xDxr3a1+DyeipkC/H2JkItY2gDj97xOJUAUMxIA0VvMqL5fL1k1SS ijIFSSsc1mDHLg4dmYAMwoIojwwP28ZEsG+Tc3jZPYCH4R1Qy X-Gm-Gg: ASbGncvcs90QoWHOmJqexMJO3KLfW5QcbDBc03Dm0W+lY7YwdVzGuCreue0YRDWF7xy 58GPYs42GI6XtHWUb4KgbJ5o0Xm4qZKCMyF64CxLF7UTWfdniPoFh/WdZ5XNBb6dCtou7zRwT3C Gi/sD6K4vb1mr70YkSZVEAMeGPRcW2SlJl6WzuVE9gzYyJdgZ+oMqsyEuwWh8BYBM+SPq8FTNgn AEUCPAvADfKpPPANd43wJk6CpwHoUVonKFdFL80BkaviMDrpn0FLBLpwOwlKVqeXe7Plf6+MtzL lLUdn9ep4Zz8zzzBdOeCavwaB94G23THi14KNphhm7qi+wHQ9PBL6zI= X-Received: by 2002:a05:600c:3553:b0:439:8bc3:a698 with SMTP id 5b1f17b1804b1-43c601cdc45mr16230415e9.6.1741334094994; Thu, 06 Mar 2025 23:54:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5GpnS4MDn/K1MDh6DvplMjCwTGNqRWUJiQpcKLuEIKeIoa5hrBZx50YeG7edtD/K149h+Ww== X-Received: by 2002:a05:600c:3553:b0:439:8bc3:a698 with SMTP id 5b1f17b1804b1-43c601cdc45mr16230285e9.6.1741334094550; Thu, 06 Mar 2025 23:54:54 -0800 (PST) Received: from ?IPV6:2a01:e0a:c:37e0:ced3:55bd:f454:e722? ([2a01:e0a:c:37e0:ced3:55bd:f454:e722]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd4352fa3sm72985885e9.30.2025.03.06.23.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 23:54:54 -0800 (PST) Message-ID: <51c11147-4927-4ebc-9737-fd1eebe4e0bd@redhat.com> Date: Fri, 7 Mar 2025 08:54:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH drm-next 1/2] vmalloc: Add atomic_vmap To: Matthew Wilcox , Ryosuke Yasuoka , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, kraxel@redhat.com, gurchetansingh@chromium.org, olvaffe@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, dmitry.osipenko@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org References: <20250305152555.318159-1-ryasuoka@redhat.com> <20250305152555.318159-2-ryasuoka@redhat.com> <3bfd4238-6954-41a3-a5a3-8515a3ac9dce@redhat.com> From: Jocelyn Falempe In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bzxXA0jbSlUBYmbDJnp5_-O3pcvZ0joa7v1d1YhN4CY_1741334095 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4EA8D140007 X-Stat-Signature: ynd76ud18d6xze7ntp6ohdjb19kkm85y X-HE-Tag: 1741334098-497656 X-HE-Meta: U2FsdGVkX185e4Pd0w6xcQW8fJd9nh5bTfkzUWgR9tlWK+GMKgmEPJMqpviGlAzJNUUhUFVTFMKQu8FhB870XyZhpziMtTP/evJgFbp35HMA79tSIuRactkGS4sQqCiEDXYDM6KeDKn5bw3Xv4CfhvonAeI4RaxLPSZD5WfuVmudSxD3AL0rxZDXqCza6VNaaTCNRPf5GBDlFB0wE6VGJIdzQA2vjSfg2aGvC/vww+6vhYzCVjI9vAvdlAOIUh4byF1xxUQFEfkIYOm4+00twV+Vq6jkyqu3Q0a7SkGphtxBBt5uzoQHDd6t4mlXpVgM6J9uUX7658Dqp10C8cMyC1YHzu3mu2DyF+eIW/0MSpyqw+2RXM9aZtkEyjPZmc4O8OpAWtmEc3NmVUF7tWYpg0VJ+8U9Rz1Vyu1LCR2U9lZgRbMcVOdrEIdWObzCjOCWzqWA9ubxGtibUW2eS/YQIZRfpAcdypRXtVZXVNg8A/R/V6cfe55F31v2DqKWyaFInhmisZ5oYevHZDpQSXOP7pDMuSsCEmbeUOpTROj+35qjt3pPZmY0Xn9ryhcULQ+Q1pcaVTYIFu6Ynev3vdpyQJQ+bSKFrnoJh15lxFdmR6ItBSSXmQHn0JtrXGnfczHmXAKyyWf2t3y72dItUz1yPyVUuZqbHhGVw3/seY8awYTzCfewhCBR7yn1TvTvWxFwovTYjU9zDXMlz2QQAMSiJAP8O/MSQutqr8F1upQNlpDswrmhxWosR6y5UlB14AREzYHf9KkVIkpddrcwfqi5ivMtTfRSL4fNYfXc0MiiX57TAYMUhBHdNRDe1Zf1h03n8EdTT9k/pxhUV4OkfFAIUolbqLQrATf4ibSBGGlubDfglr3JvPw5LAsTaqnjbqjmqkvyq1zM9pC9f1C18Nvm71J1ni1PkhqxsO5Z1Xwtg3KoTz6is+epPRTkXJ3g7On+7aQFqkRpERcBKCIg03H lLpBbpdh agBXPSbgs+66Mpbtwb/92XBqDN3QffkLLK3TCsPk2rQ5hdNc+lA30iwtYjyERRI0YJGVUot/3QtwW5YdxolNpOM6ZOFfeljjUltoMbmdLgnAJvo/u1TX5fbKtmkLrOg2/Nrjrj+x8DrH7e5lC1FypvcgGvEDwfGOjR5dUh9yoFuRekuTWPVYAm7va0MmcmJfpfQmzZ6phaSpBRIDE3/0ZsRrVQhw3tcNwLfJfchgrAaaTogslOhkDZG20c/u39lPULyYMyX+RM6tgcDDxh50WqN1YeXFAf/A+NKfG0A0At9rhtLuDGKEVBT+8HuT3UHWvniICSI1Hvt8wlh2L298pQSsODRQKz7NZc9eM+7YBwVxnliEeACFAKjPfKyY0/YSCi2G+Ai7G1Ipclag7m1i6j2H3O8mAyQad3S7dYiGg0dCwMoIfH11rPBXSlP3BWX2fHZzR09JGAOXyoiJzpuq9fiOGoULEDq6CiSJvYYQAWiFuVph/nQ+kJuX7gUeV9AQSwXy6QXzkiyV6G+gtXSgy4B5ZaQq3wSYqYSi86ffDbILYM6g6R6GoB+TyGfVN3l59Iyr9tZ0vWeulCqK2jMdCmg7p7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/03/2025 16:52, Simona Vetter wrote: > On Thu, Mar 06, 2025 at 02:24:51PM +0100, Jocelyn Falempe wrote: >> On 06/03/2025 05:52, Matthew Wilcox wrote: >>> On Thu, Mar 06, 2025 at 12:25:53AM +0900, Ryosuke Yasuoka wrote: >>>> Some drivers can use vmap in drm_panic, however, vmap is sleepable and >>>> takes locks. Since drm_panic will vmap in panic handler, atomic_vmap >>>> requests pages with GFP_ATOMIC and maps KVA without locks and sleep. >>> >>> In addition to the implicit GFP_KERNEL allocations Vlad mentioned, how >>> is this supposed to work? >>> >>>> + vn = addr_to_node(va->va_start); >>>> + >>>> + insert_vmap_area(va, &vn->busy.root, &vn->busy.head); >>> >>> If someone else is holding the vn->busy.lock because they're modifying the >>> busy tree, you'll corrupt the tree. You can't just say "I can't take a >>> lock here, so I won't bother". You need to figure out how to do something >>> safe without taking the lock. For example, you could preallocate the >>> page tables and reserve a vmap area when the driver loads that would >>> then be usable for the panic situation. I don't know that we have APIs >>> to let you do that today, but it's something that could be added. >>> >> Regarding the lock, it should be possible to use the trylock() variant, and >> fail if the lock is already taken. (In the panic handler, only 1 CPU remain >> active, so it's unlikely the lock would be released anyway). >> >> If we need to pre-allocate the page table and reserve the vmap area, maybe >> it would be easier to just always vmap() the primary framebuffer, so it can >> be used in the panic handler? > > Yeah I really don't like the idea of creating some really brittle one-off > core mm code just so we don't have to vmap a buffer unconditionally. I > think even better would be if drm_panic can cope with non-linear buffers, > it's entirely fine if the drawing function absolutely crawls and sets each > individual byte ... It already supports some non-linear buffer, like Nvidia block-linear: https://elixir.bootlin.com/linux/v6.13.5/source/drivers/gpu/drm/nouveau/dispnv50/wndw.c#L606 And I've also sent some patches to support Intel's 4-tile and Y-tile format: https://patchwork.freedesktop.org/patch/637200/?series=141936&rev=5 https://patchwork.freedesktop.org/patch/637202/?series=141936&rev=5 Hopefully Color Compression can be disabled on intel's GPU, otherwise that would be a bit harder to implement than tiling. > > The only thing you're allowed to do in panic is try_lock on a raw spinlock > (plus some really scare lockless tricks), imposing that on core mm sounds > like a non-starter to me. > > Cheers, Sima