From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B0AC4345F for ; Wed, 24 Apr 2024 15:59:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04BEC8D001E; Wed, 24 Apr 2024 11:59:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F16406B02C6; Wed, 24 Apr 2024 11:59:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB67C8D001E; Wed, 24 Apr 2024 11:59:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BE0C76B02C5 for ; Wed, 24 Apr 2024 11:59:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 73629A021D for ; Wed, 24 Apr 2024 15:59:01 +0000 (UTC) X-FDA: 82044884082.14.28F13D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 201741C001B for ; Wed, 24 Apr 2024 15:58:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X9XFU2FT; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713974339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FXxAne31QRv+Be4fJgW6rZrEYbRt43j8aWEXlyjQvIc=; b=EUqYhGFUWWlsaxb53NkEMz/tqrCeL5jG4ZjwKeshkFzBQtjhJmdiE94AeO4G9X1f5axNEY cscRwwFd5HCgudvFGB54GGELT/eO06U5pjlQDJiD9A/NW2SUuwl5DD3IBLSwKMpbTsW9KH t3D0ICE5i6PKdmkeLexsGsym2hcrKk0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X9XFU2FT; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713974339; a=rsa-sha256; cv=none; b=DqEXRSNW3gLRoekyKR4IcbOEgFXkZFjM7tjaHx24R8TNrvgpK324egJB2jUigU+VIxCWL/ Z0En2eGm9mFjrQ91gJQzWuk/vZ8yPJGv57oxl/QPwc1vg8Tx4EI+Ui79iy+owpPVhnDfbW wTHohgV/PIjbN9U+XvRkLj70QyyqBG4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713974338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FXxAne31QRv+Be4fJgW6rZrEYbRt43j8aWEXlyjQvIc=; b=X9XFU2FTzZ1i+qOPF9lRvUqb64YIHV2SnuaLkSoNyq55bqDevI1vhPTpV/QjUuZuIT+QEq CnfLG22gY+T7TCiiMzw3hqIaO/OPNzsewhdT1rWYOsv9Lufx3Bpgv4Uy/lxdKwRabkojn4 MG/mn/YyJhnRWsHtYnnKuUA8d4oU/R8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-P46_KI8vMyyXScq3TlXwgA-1; Wed, 24 Apr 2024 11:58:56 -0400 X-MC-Unique: P46_KI8vMyyXScq3TlXwgA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-34b08e09bc4so2284936f8f.1 for ; Wed, 24 Apr 2024 08:58:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713974335; x=1714579135; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FXxAne31QRv+Be4fJgW6rZrEYbRt43j8aWEXlyjQvIc=; b=Kpp0HY/7lnFcwKmJjsTFqnaQwJhUHHljNlCHnlNroj7+sB7pjE+emBpy1NvxkOEt9D ypwc4U/7UOGtvZVG9sLbvYB/MQjYunequO1UZ7CsDHNWqJyXaulVIjvUOnx+gb1ODzze QVxlEHjbegpjYZacJPPFbeHZFitL1ZmRsJpWfMHXsyzdSc3fdD0HiEUe5gHfZMd4dJuv CNBbLTxYWccIQLc6Bm4zFczBGejG6ya9DBuNf8qnoDOXWtHaKfCqHSgLpKg9BHHIz0CJ HKMVhkZ+WeEfu1MdeOiIO0g1C7eBtkYueV6KrqSOCJr61ao5/mAUK9+MfAGwAmfba3fY wtrA== X-Forwarded-Encrypted: i=1; AJvYcCWapG9Bo3NQqFBF/CurHBdWHrXYgBQf64CvRpM4ffnGjOIgFNzzAlDyVOTVjSjnJKHVcdJWw4LYVwj8Ow8O6Ev/ab4= X-Gm-Message-State: AOJu0YzBs0JYYvjhV/48QXbTzxyr67c+S/jrv+BUIEWkqS1X4a9omO2B oGAN69MsvSVC18LcVGemtsxiWpj4auR5/3sMV7bi8jod4EeO5FdT89W+D3ZLbhxHu8UNqWddWGj FclsHDNUAy37p19WaXM9yykY6DU7mjKa/VPuJOdxNJjR4lCux X-Received: by 2002:adf:e0d0:0:b0:347:41be:3cf9 with SMTP id m16-20020adfe0d0000000b0034741be3cf9mr2296298wri.18.1713974335522; Wed, 24 Apr 2024 08:58:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG81RWjqB7Hx0TC/5TXRGjBfMzWGnrHQirtQ2JJCkjU59opn1dMkAl3JLq1F6NFX5C4pDMUrA== X-Received: by 2002:adf:e0d0:0:b0:347:41be:3cf9 with SMTP id m16-20020adfe0d0000000b0034741be3cf9mr2296273wri.18.1713974335031; Wed, 24 Apr 2024 08:58:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id a7-20020adfeec7000000b00349cadc5024sm17449951wrp.61.2024.04.24.08.58.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 08:58:54 -0700 (PDT) Message-ID: <51ba6efa-ce5a-49cf-b90e-62310db2c561@redhat.com> Date: Wed, 24 Apr 2024 17:58:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during shrink_folio_list() To: Zi Yan Cc: Matthew Wilcox , Lance Yang , akpm@linux-foundation.org, maskray@google.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240422055213.60231-1-ioworker0@gmail.com> <1a0ca018-8ad3-42b0-b98a-8e6b6862fc7a@redhat.com> <333181FE-C2E6-4859-AF6A-0667A1F42037@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <333181FE-C2E6-4859-AF6A-0667A1F42037@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 201741C001B X-Stat-Signature: 7y7muaqu6hqsme8gphqqqeqjio4faywy X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713974338-43517 X-HE-Meta: U2FsdGVkX19QFeoub/azlBtZxjfEvXf8s6MXx3wYJag87Hod2M8Ox2o6rkMDL/Tyr/7HruLNZCRiokC9/hoCofJn3mVGX44qZkpSR2k5TzcXWpxRqmdE8bJEUgu0XK9h0M161ZhkqRp/5/zWetZGqD5DqLpc+xaJKQWRl3JRwh2h/kAqJyCuN+hAVj//tCnqkEHbGE0+N1HOcxDwehMM07pnLeHCQu10M7m/Szo4Eefqy2n3DIjHGkmSFgYXHtbDCl6t6d5rGuyLsQjFCn1oLhtM149+IDnj5W/GX/0p3C3EQE7BUqxugb1aLJCJgqsW7zjwNHw6xLRBkoC/ePZKSH4bI+IhQxZ90Z7usgHPbjTnWy3PiE09wzjkjtz6EquuhXi9YVTYdWMeci/TBx5NdvQFQjre9RveYKTLqknCP3UFCYWMGrPmfC2DsvE+ViZlbquu/2PmShVjICpfWgRMqI3PZBHUmU3R8Y66kzP8LZv/bvcVNPfXz+RSVZGa/njfmVldThdYfuQLVPWDmDtWW+HaZJrqooIZlZPv7qQt4ruvK5o8A0Pv+INUTnBLfECvA/TkfkDf3EfKOmeANlDfSkmMtI6rGL/u3qrwCLihYe0+ZmobbID/PiG0r5ifZang7dxHFOTvVsliaZrt2kgfqTsJQTwKJkxnYgW//uiTwrvJrebAL9SiNTZwUM3USjTnGTHunaxfkBiPJdRuL6xwnUFxBIYrEBQQCy0kUWDwYqq+er09PHgk3o7lEXyDXWfVrb4HYXC79c+PBBf6OVwqoPx0UAtCrj0u8CXr5PzY4K1DazM+lZmBR+EMKA4ckuiIIvmdPLF9VsCYdt04kENvjzqvgILCZCiw08VPfxTuy9GCkq6VsH5A75f8l+v2oE8b6FrQk98B6Hh27kWJukOAcJx336ZXLW9SxMttH0MAIl6Djeaj9R37rU1ArpRpV/NsQXszwbBEZZztblPgUlf bKBu1Uku QMfJTaRRb6birSAslqX/Rq09SwW5QmBHQVJYhGia25j9h1n48OBWtVZgFtNDDFbW/lSt/JKc526S7+MPqsJAXbtEC5DAXk024p3u86HNEY3XkN+4WXpnzFHi1UFfhIbZBwjct2XJ6ssRohzkVJ82la6WWJM6I6WIkK2Nq8Mc7+/OiWWGxL7pIuzIGezGZtPksL+LRpv8CpS6lzQqr4wKD+KzBcDOZ8bXvZVGf7vyBM345ne0E9UWqmigzF7GaWgq8T7p73y3U2t2bY4LwKaoYHlLTnDm92cNnvF58sQkU3tkthZxGnEw8lEbXTCuHTbhcXexfhCbWLOgROJw5SzuQ1DOst2iNIxE73mBEHlI4G5VbK8lN8wxRVqsbd6THhZ8dJ+8ewkLw5gYJhwA+s73i8Uf3uey5v2kbA6OBcv/8LEUVIKTQPaD4grMc4fskp5yQaDkplINAdF8FmUY5d6rwIK1Jlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 17:57, Zi Yan wrote: > On 24 Apr 2024, at 3:17, David Hildenbrand wrote: > >> On 24.04.24 06:15, Matthew Wilcox wrote: >>> On Mon, Apr 22, 2024 at 01:52:13PM +0800, Lance Yang wrote: >>>> When the user no longer requires the pages, they would use >>>> madvise(MADV_FREE) to mark the pages as lazy free. IMO, they would not >>>> typically rewrite to the given range. >>>> >>>> At present, PMD-mapped THPs that are marked as lazyfree during >>>> shrink_folio_list() are unconditionally split, which may be unnecessary. >>>> If the THP is clean, its PMD is also clean, and there are no unexpected >>>> references, then we can attempt to remove the PMD mapping from it. This >>>> change will improve the efficiency of memory reclamation in this case. >>> >>> Does this happen outside of benchmarks? I'm really struggling to see >>> how we end up in this situation. We have a clean THP without swap >>> backing, so it's full of zeroes, but for some reason we haven't used the >>> shared huge zero page? What is going on? >> >> It's not full of zeroes. >> >> User space called MADV_FREE on a PMD-mapped THP. >> >> During MADV_FREE, we mark the PTEs as clean, the folio as clean and sd "lazyfree" (no swap backend). If, during memory reclaim, we detect that (a) the folio is still clean (b) the PTEs are still clean and (c) there are no unexpected references (GUP), user space didn't re-write to that memory again, so we can just discard the memory "lazily". > > It seems that try_to_unmap_one() does not support unmapping PMD-mapped folios. > Maybe adding that support instead of a special case handling? I was thinking the same, and finding a way to avoid TTU_LAZYFREE_THP. -- Cheers, David / dhildenb