From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D48FDC25B7C for ; Wed, 22 May 2024 09:38:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45E8B6B0099; Wed, 22 May 2024 05:38:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40F046B009A; Wed, 22 May 2024 05:38:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 306276B009B; Wed, 22 May 2024 05:38:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 124A86B0099 for ; Wed, 22 May 2024 05:38:56 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AC9C112092A for ; Wed, 22 May 2024 09:38:55 +0000 (UTC) X-FDA: 82145532630.14.563B56E Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf18.hostedemail.com (Postfix) with ESMTP id 6EBC81C0016 for ; Wed, 22 May 2024 09:38:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=o2nDLcEJ; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716370733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BLQEugnL1kRYNRU+br9+o3u5TxKkPi3pJuyhAveE0vw=; b=z+qBcDp2gVCnFf/500gBX0Cshltl08jdCV9CMSHqyOKnPv0d6wa2MZmQrDbNVMg/MEvu/5 C1Wuj5s7cnqSbwPtV3E/BJquon52x2jhLt8JGx4TUTfxjNt0mnjOPYeLo+Vai8+/uYMA6N RDQ23N4eOrnppkNKh5hYMV6kGZamZ0Y= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=o2nDLcEJ; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716370733; a=rsa-sha256; cv=none; b=bGNZIVI7IEQ7WpOIi3FVoBnQvrGcv/RSeBhvfzPIhvTOxxGiAMt4pN02TVtUGBE849yWr1 yTsXTIA+byaPEG+/IZIQUsxy3hRpVSPeNqse3IN2IqowIJC3JOjYpoGGgUms6HFP7IX7l5 zQK+F9+F4oZSaI0GHcRyr4ZjrlDyGEk= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1716370729; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=BLQEugnL1kRYNRU+br9+o3u5TxKkPi3pJuyhAveE0vw=; b=o2nDLcEJmIFcLvnnQ+btdNGiDOU4CnI+okpk7L/Sb3eZEhMf9cAfFB+muJfMO3AIVD9bKaXt179FBjJC1F6p2/Rf/8/cbpV4tNruRiF5lhCsX8UkyCl4aV+xWOyn6bP+rbr6r5rvFaoBuiZGN940dodfkOa8pc8lq3aODJ2uneY= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R311e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067113;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W7-ufZc_1716370726; Received: from 30.97.56.54(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W7-ufZc_1716370726) by smtp.aliyun-inc.com; Wed, 22 May 2024 17:38:47 +0800 Message-ID: <51ba1fc1-fd77-4601-8d27-459162fd008c@linux.alibaba.com> Date: Wed, 22 May 2024 17:38:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters To: David Hildenbrand , akpm@linux-foundation.org Cc: willy@infradead.org, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <0e2a6f232e7579a2e4407ecf075531980d97f286.1716367360.git.baolin.wang@linux.alibaba.com> <22ac01a3-ddbb-4114-88cd-ad1a31982dad@redhat.com> From: Baolin Wang In-Reply-To: <22ac01a3-ddbb-4114-88cd-ad1a31982dad@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6EBC81C0016 X-Stat-Signature: g8oug4hxxik7ord4qfm1xmqyh8bhk5fj X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716370732-5000 X-HE-Meta: U2FsdGVkX18SruSTkBxz6KEf2baRmkRv3Pnatr+R993RAmqq/BROdl7fJMXhjbAq4+J9S8LQSJ+7xf+Mf4WtpaIsOM87IiaerKN3qgWd2Cub29MZO38NUhyqcMi43+hxRkSJGy+LCKE5d+okEnihK52HABiDO12GWcriDPmp1MHaaZdkB4k2m+cyV3zP9xlixZAMurj/37PF0bK29vOjvrN9Bh27CLZ0iEI+cFKSCFylwmXXI83wDfEixJ3ySLXD2ckRZpVw28JkfGFM7R2fWgj3Y9Zyy1xTMKKPG/j0kJFsyBFPWYYSmrYMTMBeO9rji5cMKMnTgXhbIUX4u3iKBtOTT7ARsGVIsUsjhH5HsmVv2T/X9L7pTr2cBhckd+RO1ihejbpGCXAn66NAL7N3aXV3X1jnjtXfg8QnDIQhxJH+qdXFpFTv3jFmV7TIaWEVCI9QYie3BhEiJfQBKzeqOVUv/kiBJP8tTzxXOcCpvravItgqjiG0c9nKzYf5q8rW1qQ66Ycbjdk7mZ7N7ifHou0mq8HYjy3RJZQ/QjRGedVnhoqIFEzJCiHHKUuxmEEU+gffMw4rqhVphr+ZDPtCW177nDxoDFZgWPUNOxbgBKIvY+wCcPq89QeslPwyEvVWcr9WK+lf15qF8/0IOLbtcv4hLyc1oN0Ss0A8NrXHadxA/AytZaoPyjG2Ja7fyAele5ZZ+tKte473YZg+Saod3McHpKCS8sDIqRgC0PaHYsXCDAByCQ4ELbnfQyJNsasOt8Nh0t8WTSJlP0XrQ9a7Vhc2y0B8zDyhA52JBWD88h1FySSIl3U8XtmeODf3dXb0mMEqLMZwhVY5BFtUeMmqskSGhEqPCsRlCbgcTw18ekQd/Ak8QIkFPh7xt4rYLmz0rzv+isnYxwj4KAOumxlTys+zYL/P2Jt/uo0udbMyVG8Dfbk3EyH4hAGB/ir+WecTvCnldhZsika8NoyZ1f/ OFrOnI+s rvBUPP1DaACowKk+774gPP2S4InzHdJcyYvkSkI5+13EtYqpwZcEr5rjRGT434CnWPChcm8R9qtQLZVRiXjzqHcZK1aYB2/znlwIwtmFYlVLnsozpfv1KI6xCcHbr5angpaMe7vY6oEVSNiVMTuoDL4c+vlCNhtxRrXQ7dQXRN3+BdLsGF48srQZJ7Jg7LbIi2EAmhtGEw943IF67I8BIABIfBxNHK06eMFb8ZPSeC7fITNvtD18nU0NZqdioOkpvSSSEE7psTidEhkmxwNmXFxsG/Liyul0ok1kIQBbByDZ1RxSqRYnoN1w3gtGRfqC0bMfhxsGzHHT9A2XodDJEGeqVfhooVpzabWSQnW2lPtlKL3TMeXWoLsSW8Q3faChVCWiq1v19VV9yD/VXvEMTHMnLkJ1+F3Ydd9qnW66w00DY0/f9OZQR8AC6EvpQDQwOw4RBebtvBETOylhHZccTrUPMry2eXBQkxneO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/22 16:58, David Hildenbrand wrote: > On 22.05.24 10:51, Baolin Wang wrote: >> The mTHP swap related counters: 'anon_swpout' and >> 'anon_swpout_fallback' are >> confusing with an 'anon_' prefix, since the shmem can swap out >> non-anonymous >> pages. So drop the 'anon_' prefix to keep consistent with the old swap >> counter >> names. >> >> Suggested-by: "Huang, Ying" >> Signed-off-by: Baolin Wang >> --- > > Am I daydreaming or did we add the anon_ for a reason and discussed the > interaction with shmem? At least I remember some discussion around that. Do you mean the shmem mTHP allocation counters in previous discussion[1]? But for 'anon_swpout' and 'anon_swpout_fallback', I can not find previous discussions that provided a reason for adding the ‘anon_’ prefix. Barry, any comments? Thanks. [1] https://lore.kernel.org/all/05d0096e4ec3e572d1d52d33a31a661321ac1551.1713755580.git.baolin.wang@linux.alibaba.com/