From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3E1C6FD1C for ; Fri, 24 Mar 2023 08:01:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2912B6B0072; Fri, 24 Mar 2023 04:01:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2423A6B0074; Fri, 24 Mar 2023 04:01:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10A3C6B0075; Fri, 24 Mar 2023 04:01:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 000ED6B0072 for ; Fri, 24 Mar 2023 04:01:38 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B9D4D408DB for ; Fri, 24 Mar 2023 08:01:38 +0000 (UTC) X-FDA: 80603047476.19.EA2A38D Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf10.hostedemail.com (Postfix) with ESMTP id BD091C002C for ; Fri, 24 Mar 2023 08:01:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TUJ1gjZl; spf=pass (imf10.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679644896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7TZflQcry/zVbKgGN8VXhySI4kAf9LcbB6zEK3sU8LA=; b=Zze/iOn1qWwWb0gHFq5ID9BSVasopFRE1UMh7Fp1yfMor0sfT0+7r10GSzAKEuNgzYzEZh VEEqMALU8ksExLW7ocRfBMYOgaZrxobe+It4e/6WDmUBIHEDTcNIsUMOFDu4u6CWQNhtA7 ekl6sr8nDhnkuDWG8k9TikGppPsVLoI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TUJ1gjZl; spf=pass (imf10.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679644896; a=rsa-sha256; cv=none; b=VwnP6GCrs9W6c6cDhHQ3py1wHSsKc48gbIK0cCQkSofjrj4oFZp1iMIrws3RxZizGDF7xQ lZ42eZGcuY8vdWDxgxEM2Vkc2Qkeft/RYinc4WudF026v1u37LS/UFyB2WEsMT+5PtKhHu gDcT1/pxKbtdt1EwBcdaxst+LQ5d1NI= Received: by mail-wm1-f48.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so2603555wmb.5 for ; Fri, 24 Mar 2023 01:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679644895; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7TZflQcry/zVbKgGN8VXhySI4kAf9LcbB6zEK3sU8LA=; b=TUJ1gjZlY4cdfXMGFw+W2SH5lHAQF+7+P5xsVBbtwrTPsQqzOXZuRaWTUGDrc+ptEl D/IR/t51lNkl54yZ+NDArRinRwipvAw0VWM46bbcUFnoIDGpX430r/neTjF8CkJG7EYA nkFNGN5TfDQTMrclAUMHNlkL5fkBRrmNLfjgmLG50miiSq5EdwMgU3Mtu//EYMFGKnG3 IcwsH9MUSzBwlwAso0Az9lZQNtNDrFIMiTeyIuypNI+/xWszkLy/vkMWjATik6SAPYGZ Q8ZYjjcyO8+aYCoNxsyQHb/IazvuTb0ipS6aKxiSvM9w6eku1g38ddhE9s2LzJgrYAMP 8krA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679644895; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7TZflQcry/zVbKgGN8VXhySI4kAf9LcbB6zEK3sU8LA=; b=eA4p2L2lbhW9BymkmDz9muxAP6wyAkw6GHltvWAu3IEIQawYIT38Op8+WrZoYDUr9C c/x1eV2N2yincVfiKVns/JTlbKsQS4dwLFkKV3tYCUB0Hy3WJKdtHv3jOHr9C7aWxkc6 adVrKwdP/xAa0Tp2+aR8dE8v6jSIwkfUkFd57qkDxB9EQo2j2zvvX8E/MvbV49RQdRNo Rl8kOrdr2+VoNc9TNQ/fn9GE/BNV7TDvXvHtkMrNYbM9E1bQQnWvYEg3cAaW67fIKzUK kzptKxlnX+LxkyZic3slSXsV5kyJmmdFhqxRgO1Zea0zTu8EsnkrkhZoXZIe4qf1AEmg 4BzA== X-Gm-Message-State: AO0yUKVCGYlBGYAgb0e/WaY5SciEX9IM5kd1W5ruEMpczXKfkoBPE+I6 VEvQYNGt0dV9w93slcuMxFGF8ek+N1k= X-Google-Smtp-Source: AK7set8/Iq04QHghAHUv0aUGEuupYMtG42PzDbNIUIgAUBFYjhUCeOX+gd+RXJvzA27We3mS/L7eag== X-Received: by 2002:a05:600c:254:b0:3ed:dc11:1a74 with SMTP id 20-20020a05600c025400b003eddc111a74mr1727596wmj.5.1679644894952; Fri, 24 Mar 2023 01:01:34 -0700 (PDT) Received: from localhost (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.gmail.com with ESMTPSA id w4-20020a05600c474400b003edc9a5f98asm4262205wmo.44.2023.03.24.01.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 01:01:33 -0700 (PDT) Date: Fri, 24 Mar 2023 08:01:32 +0000 From: Lorenzo Stoakes To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 5496/6100] mm/mmap.c:962 vma_merge() error: uninitialized symbol 'next'. Message-ID: <51b0a7d2-0f9a-4104-b9c0-a1aa307cb028@lucifer.local> References: <7c7e59d2-435e-4677-b278-c066cae80616@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7c7e59d2-435e-4677-b278-c066cae80616@kili.mountain> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BD091C002C X-Stat-Signature: wejzeedkoep4hmzpzszaazhhq3efxz7z X-Rspam-User: X-HE-Tag: 1679644896-712978 X-HE-Meta: U2FsdGVkX19a5+4b0d79mHF1jbyby9hqHKjxbJjvjaezK70k/eadyV9Ngi+vgI35YljpOXhHxV7/S1yJB/4lkv+VrbDgxkCMM6Gzb8rLl+AGTtpDz4isE3kdw7tnAxfY5ec9PPOBndD0lfqjuQk1Q3+l/PkSIqTuc8RUAx4nPqhIh+ZvooLpKd5C/gg3MpaCmDCM9ytqs/Tuztff/ybKqcyn05dx7E2iCjw+ispKrNL6uGSGOF8i2i233ZckDQMr6iup556fQoRQ4r88ZZD59n2LLm7MHAnqVnGwqQFQIbifXRaF6IiqGfFN/PTDL/71KTpwXFkTWHgbiB9qn+t36BZAFBwTOMzQJWwEyxlU4TzZjteQtB1VEZUuCejLEecJH2dqPl7Wn/ISWSIISSytXEtWbhgKILAbq8q9IzRUiXEHvvIIivHs/LZ4NDLriY0ugS+lj3lqS5y716b3099K14LAXm9BA3kRoXBVjpm6nXgLqZBk3jD93pn/Kmxk9SM1+0JHCQp/aG7aJ4D7rDP8JJrcjxEUXAaIdSmEIKecMyLotHDUrApF4wQTeey7pqrHjy5eHzjTZ0iZOUEgf5dkonQAIK8DPN0L5cscuXw0MHe0aym1kJNh+LJGPjLpEl5UfL3+ppUi629XLqkma2lWwFwyq31gdMuqAaC47EHEXnWK867hWDCZ72G4se+CdCRHvdADCkGoDodmg39a3r6K52AT6o0NXOjpZ61Jc0LyHeDyAfU5Yqu2kJ5y7ihO/Cge85hBkCLTgvCCCMv3ap+uBd3X85cjbtH8bYBgBSyHWOuFM6ktLXFT/prkp1m45NguOpJiG6O386tZxlHc+wEic41HzBFkxXqtAi9LVvqK6sZ53WKHhYQbPSDn9hA3/Mf+YJG6LXdZgvsAfEDu4QTnrRp/BMNNslBEVo8Ih8UsotK4oY5ZbSFCm2+eAr7nS1Qr+hGVaSwRg5k6gZmCx+4 qSr4PZsC ESsgW7CI8vpD9zp7XRDAyRfuiErvO5M9JGVWhHYgbqXpljNtTKNQDWf/OGbYYj+zOAHdA82tvAUWK8oq1izmQhdVTbUs379JFIMDPMQ91Y39UEAs/MlqH/Lx522dNldKHMywEzurArx2HjLlWv3PBg1zbRWrWCdqkdVr1iPQHid34aHeg1UjXuvEF8L2tVH0A0dCRW9JkI4LOHSG7PMLQbFEaM816d+Ewftf2tYqZf5Tu524mOLoaE+S0kwhxmwAMQxCGr9gyZJnoBZygGR0lIOkiRtr15ZV3ZtgRV+zjr/jFdpUDciwc7/gVTgmaYNBKP/qzHYEwaVD5NM/xxWaa1PTAg7dmflhOw/EpoUd8wy89LnkBMUTs1ahGlEulBw4cDDaKNuCzVlUvM0z0W5jYvS6HRuHqzYyuDY+8JoiYsq83ybrpr5/i4WMPvx/8DYJvkeiKELTVoL8zv8Y59/nbPLl5Nxi2ZJdKO9UCOsASROG6TWqTw0bFk89yPzaHno75cgOtYN6I9xIc7c5/r1TnpVCt9wINYdYaAsFw6sCG6+V44fPdx3xtnjxc/Klctgriz+5hRILOK3vRohdDU41/jbfQV0Wl8DAhUr+g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 24, 2023 at 08:03:52AM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 7c4a254d78f89546d0e74a40617ef24c6151c8d1 > commit: e887ecae997ebaaad4d9b93e6a01fd5495ec1bc3 [5496/6100] mm/mmap/vma_merge: set next to NULL if not applicable > config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230324/202303240246.9rvyIPWZ-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Link: https://lore.kernel.org/r/202303240246.9rvyIPWZ-lkp@intel.com/ > > smatch warnings: > mm/mmap.c:962 vma_merge() error: uninitialized symbol 'next'. > Hi, sorry for breaking -next (this is the nth report for this :) but this is a mistake that accidentally slipped in a while ago, it was fixed in v3 of the patch series which is currently in mm-unstable and should land in -next when mm is next integrated (no pun intended). See https://lore.kernel.org/all/cover.1679516210.git.lstoakes@gmail.com for the latest version of the series in question. Thanks for the report and it's really nice to see how many people are on top of these things! > vim +/next +962 mm/mmap.c > > 9760ebffbf5507 Liam R. Howlett 2023-01-20 904 struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, > ^1da177e4c3f41 Linus Torvalds 2005-04-16 905 struct vm_area_struct *prev, unsigned long addr, > ^1da177e4c3f41 Linus Torvalds 2005-04-16 906 unsigned long end, unsigned long vm_flags, > ^1da177e4c3f41 Linus Torvalds 2005-04-16 907 struct anon_vma *anon_vma, struct file *file, > 19a809afe2fe08 Andrea Arcangeli 2015-09-04 908 pgoff_t pgoff, struct mempolicy *policy, > 9a10064f5625d5 Colin Cross 2022-01-14 909 struct vm_userfaultfd_ctx vm_userfaultfd_ctx, > 5c26f6ac9416b6 Suren Baghdasaryan 2022-03-04 910 struct anon_vma_name *anon_name) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 911 { > ^1da177e4c3f41 Linus Torvalds 2005-04-16 912 pgoff_t pglen = (end - addr) >> PAGE_SHIFT; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 913 pgoff_t vma_pgoff; > 721076b86904d4 Lorenzo Stoakes 2023-03-21 914 struct vm_area_struct *curr, *next, *res = NULL; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 915 struct vm_area_struct *vma, *adjust, *remove, *remove2; > eef199440df950 Jakub Matěna 2022-06-03 916 int err = -1; > eef199440df950 Jakub Matěna 2022-06-03 917 bool merge_prev = false; > eef199440df950 Jakub Matěna 2022-06-03 918 bool merge_next = false; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 919 bool vma_expanded = false; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 920 struct vma_prepare vp; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 921 unsigned long vma_end = end; > 27d6788ee67b59 Vlastimil Babka 2023-03-09 922 long adj_start = 0; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 923 unsigned long vma_start = addr; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 924 > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 925 validate_mm(mm); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 926 /* > ^1da177e4c3f41 Linus Torvalds 2005-04-16 927 * We later require that vma->vm_flags == vm_flags, > ^1da177e4c3f41 Linus Torvalds 2005-04-16 928 * so this tests vma->vm_flags & VM_SPECIAL, too. > ^1da177e4c3f41 Linus Torvalds 2005-04-16 929 */ > ^1da177e4c3f41 Linus Torvalds 2005-04-16 930 if (vm_flags & VM_SPECIAL) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 931 return NULL; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 932 > e887ecae997eba Lorenzo Stoakes 2023-03-21 933 /* Does the input range span an existing VMA? (cases 5 - 8) */ > e887ecae997eba Lorenzo Stoakes 2023-03-21 934 curr = find_vma_intersection(mm, prev ? prev->vm_end : 0, end); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 935 > e887ecae997eba Lorenzo Stoakes 2023-03-21 936 if (curr && end == curr->vm_end) > e887ecae997eba Lorenzo Stoakes 2023-03-21 937 /* Is there is a VMA immediately adjacent (cases 6 - 8)? */ > e887ecae997eba Lorenzo Stoakes 2023-03-21 938 next = vma_lookup(mm, curr->vm_end); > e887ecae997eba Lorenzo Stoakes 2023-03-21 939 else if (!curr) > e887ecae997eba Lorenzo Stoakes 2023-03-21 940 /* Is there a VMA next to a hole (case 1 - 3) or prev (4)? */ > e887ecae997eba Lorenzo Stoakes 2023-03-21 941 next = vma_lookup(mm, end); > > next not initialized on else path. > > 759224a5ffcfa1 Vlastimil Babka 2023-03-09 942 > e86f15ee64d8ee Andrea Arcangeli 2016-10-07 943 /* verify some invariant that must be enforced by the caller */ > e86f15ee64d8ee Andrea Arcangeli 2016-10-07 944 VM_WARN_ON(prev && addr <= prev->vm_start); > 721076b86904d4 Lorenzo Stoakes 2023-03-21 945 VM_WARN_ON(curr && end > curr->vm_end); > e86f15ee64d8ee Andrea Arcangeli 2016-10-07 946 VM_WARN_ON(addr >= end); > e86f15ee64d8ee Andrea Arcangeli 2016-10-07 947 > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 948 if (prev) { > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 949 res = prev; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 950 vma = prev; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 951 vma_start = prev->vm_start; > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 952 vma_pgoff = prev->vm_pgoff; > eef199440df950 Jakub Matěna 2022-06-03 953 /* Can we merge the predecessor? */ > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 954 if (prev->vm_end == addr && mpol_equal(vma_policy(prev), policy) > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 955 && can_vma_merge_after(prev, vm_flags, anon_vma, file, > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 956 pgoff, vm_userfaultfd_ctx, anon_name)) { > eef199440df950 Jakub Matěna 2022-06-03 957 merge_prev = true; > 18b098af2890cd Liam R. Howlett 2023-01-20 958 vma_prev(vmi); > eef199440df950 Jakub Matěna 2022-06-03 959 } > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 960 } > eef199440df950 Jakub Matěna 2022-06-03 961 /* Can we merge the successor? */ > e887ecae997eba Lorenzo Stoakes 2023-03-21 @962 if (next && mpol_equal(policy, vma_policy(next)) && > ^^^^ > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 963 can_vma_merge_before(next, vm_flags, > eef199440df950 Jakub Matěna 2022-06-03 964 anon_vma, file, pgoff+pglen, > eef199440df950 Jakub Matěna 2022-06-03 965 vm_userfaultfd_ctx, anon_name)) { > eef199440df950 Jakub Matěna 2022-06-03 966 merge_next = true; > eef199440df950 Jakub Matěna 2022-06-03 967 } > 0503ea8f5ba73e Liam R. Howlett 2023-01-20 968 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests >