From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C2AC5321D for ; Mon, 26 Aug 2024 10:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC1DB6B00C3; Mon, 26 Aug 2024 06:45:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4B356B0398; Mon, 26 Aug 2024 06:45:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEC706B0399; Mon, 26 Aug 2024 06:45:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9A4C36B00C3 for ; Mon, 26 Aug 2024 06:45:47 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 107ABA0EEC for ; Mon, 26 Aug 2024 10:45:47 +0000 (UTC) X-FDA: 82494065934.29.50B42B3 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf18.hostedemail.com (Postfix) with ESMTP id D1EAA1C0008 for ; Mon, 26 Aug 2024 10:45:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724669126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A50/yQvorRWfjsuMa18+pVws/YbRAbIKMeeLk+yxZH0=; b=Qcw3PW4eMOadi4l+kIxjx6tXjyPkqYh0gjcgDHO/BjeOn1JRN6s2NTZbu7zvIgEqCh4dF3 szccgSGsW7wiHXljUvQ59SBxC9/JYYAspx1c9aokkUyCWcMekwytDE2nHtghrO+ajuxjgx Nd5XkRW3sPmcTY6NjogcB0saqXKD9ag= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724669126; a=rsa-sha256; cv=none; b=ofVuVpuvmnhowxyjPYERf8AL9bG3qNJv+WNKiVL3BAgb72TJd8f8qOSy/3sKGmhhvnqT38 oNpJDqHhCK4AI+Iv4flGuLjf+xyRh/MDrRt7tuBQCpqnX0l5TMPSn5tF7pSwkBjl7LIYUf JBIvRKPfpphaDLSIgsGq5jIXESUntoE= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4WsnQF0ZHkz9sRk; Mon, 26 Aug 2024 12:45:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8l3J2mPFqWI2; Mon, 26 Aug 2024 12:45:40 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4WsnQD6mKZz9sPd; Mon, 26 Aug 2024 12:45:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D56398B779; Mon, 26 Aug 2024 12:45:40 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id L__8Kfk3Evvz; Mon, 26 Aug 2024 12:45:40 +0200 (CEST) Received: from [172.25.230.108] (unknown [172.25.230.108]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 86F3C8B763; Mon, 26 Aug 2024 12:45:40 +0200 (CEST) Message-ID: <51adbe91-3c3a-4baa-bb39-29df98a6eea5@csgroup.eu> Date: Mon, 26 Aug 2024 12:45:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom To: "Jason A. Donenfeld" Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <2a081f1fff5e40f496153f8e0162fc7ec5adab2e.1724309198.git.christophe.leroy@csgroup.eu> <7e519ba2-0293-4320-84bf-44f930fc286d@csgroup.eu> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: mr1kk7gzuk1jceqawipews4zisonngyi X-Rspamd-Queue-Id: D1EAA1C0008 X-Rspamd-Server: rspam11 X-HE-Tag: 1724669143-933357 X-HE-Meta: U2FsdGVkX1/RWuHsJOg2Pzao2wHGS/H9qwLM0EsB+ZeOyknZtm8XsRU2teTcNBWScJmRVVwaq2A/q1txs0t0VLfStSIFE29Wb+pcuL+P7PztjjnTNzpmXLwL/0wIWRXbp0uM81HZSllHncUJ8lD8awuzTjF9FWIbhnOWHF+b0oJT5BBSZiIByNDNzcPQdhj5T7OK0tV5ElwXME2Z/2OKoUrk5net8g3mku7d/IKFJN0FXYtbDxkckDBRyAbJ/e05yAMfx5aLUYd1cvy1x6SWsDN/5eAHH3l9bZMJaM4UNUvAZ59FTihoJV3ajHM/J2MQJqyTjBsHGIP4w2AJFvxrDxElNE4mVLCDqJLLlK0QIz5FDwt3CaOmEKsvrGA4OvZmAQ0j+9QTelukocVCBDonbOQL0qkrtNZFcMNTyssgzwS6RSQlu/573M1H7SZ59Ti6TjjXnwO7h58C/fraen1zCNAn9+hZ2T9fHdJG6kp7dX+rFTanvyvUd9IRrQ1sb18IUFmHUUlE6fsmygOgKRMroCRTUgPjekNe0c48qpgEXPNZTS5niW8yFO6WDE79kNCDgwuP7bhFAYbuSTsaBIp2MDewS/nsjXo39fRfcy4i2jly42IgON6g34YH9iSyNgQ3ODc1bbmUUvn5nYXH3ULysr3i8sn7a9oUHItIk0Y9oA5j81pnYdDEhXaeqFsz4RDWTeVI/8oQS58ndqPL+qjwh9unUR6Kkf+4CBTYRxhyNxaJZs0mXTcrNV+XqHpPC806mg1EpTJULOWupYSLUAPYDRa9/SPc86rsyDKK4yTh60dMpz40jw4rS6hmC6nOMNGm3LAqzgTXo6zDlQH1rGam8n79TG1qvjtryrxC1C2fyu8O72SGlWHaXtvwkttLgPtNws0QJwM8wAFFFwqzm3J8Tvy2siqKHdh/4UcYDxsclXj9HKcDpIACIXLti+o4WG4D+acMjYafRVJDVdVfjfk Mz7aQp7B ijmgWa1gdiAaRoWusleOUYxgMx+ldAURbb8vD2A0WNlx+mxS2UXNevOIcK5QU3cUkKYp0GVXk8zUHzLvPr9HjkiqhX5Pr5oh6Z55x2usJRRJ+xs1z+4Rt783onpdUrBfJIzYS71/LKBA+wXg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 26/08/2024 à 10:58, Jason A. Donenfeld a écrit : > On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: >> >> >> Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : >>> On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: >>>> >>>> +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) >>>> +#define _PAGE_MASK (~(_PAGE_SIZE - 1)) >>> >>> If PAGE_SIZE isn't defined at this point, why not just call it PAGE_SIZE >>> instead of _PAGE_SIZE? But if that's the case, why not put the vdso >>> definition of PAGE_SIZE into some vdso header included by this file? >> >> It was working ok on powerpc but on x86 I got: > > Seems like there might be some more fiddling to do, then? Or did you > conclude it's impossible? Maybe someone who knows x86 in details could helps but after a first look I gave up because it looks very x86 specific, indeed that's x86/asm/vdso/gettimeofday.h that pulls several x86/asm/ headers , and the same type of issue might arise for any new architecture coming in. For me it looked cleaner to just do as commit cffaefd15a8f ("vdso: Use CONFIG_PAGE_SHIFT in vdso/datapage.h") and not use PAGE_SIZE at all. But I didn't want to directly use (1UL << CONFIG_PAGE_SHIFT) and (~(1UL << (CONFIG_PAGE_SHIFT - 1))) in the code directly hence the new macros with a leading underscore to avoid any conflict with existing macros. Christophe