From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx160.postini.com [74.125.245.160]) by kanga.kvack.org (Postfix) with SMTP id F39CB6B0031 for ; Mon, 5 Aug 2013 09:24:47 -0400 (EDT) Message-ID: <51FFA748.50800@cn.fujitsu.com> Date: Mon, 05 Aug 2013 21:23:20 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH v2 RESEND 05/18] x86, ACPICA: Split acpi_boot_table_init() into two parts. References: <1375434877-20704-1-git-send-email-tangchen@cn.fujitsu.com> <7364455.HW1C4G1skW@vostro.rjw.lan> <51FF1A4F.1050309@cn.fujitsu.com> <2500845.tndtCsERty@vostro.rjw.lan> In-Reply-To: <2500845.tndtCsERty@vostro.rjw.lan> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: "Rafael J. Wysocki" Cc: robert.moore@intel.com, lv.zheng@intel.com, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org Hi Rafael, On 08/05/2013 09:26 PM, Rafael J. Wysocki wrote: ...... > > I think I understand what you're trying to achieve and I don't have objections > agaist the goal, but the matter is *how* to do that. > > Why don't you do something like this: > (1) Introduce two new functions that will each do part of > acpi_tb_parse_root_table() such that calling them in sequence, one right > after the other, will be exactly equivalent to the current > acpi_tb_parse_root_table(). > (2) Redefine acpi_tb_parse_root_table() as a wrapper calling those two new > function one right after the other. > (3) Make Linux use the two new functions directly instead of calling > acpi_tb_parse_root_table()? > > Then, Linux will use your new functions and won't call acpi_tb_parse_root_table() > at all, but the other existing users of ACPICA may still call it without any > modifications. > > Does this make sense to you? Thank you for you advice. It does make sense. I'll try your idea. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org