From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx127.postini.com [74.125.245.127]) by kanga.kvack.org (Postfix) with SMTP id 582626B0031 for ; Fri, 2 Aug 2013 03:50:37 -0400 (EDT) Message-ID: <51FB646F.30604@cn.fujitsu.com> Date: Fri, 02 Aug 2013 15:49:03 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH v2 06/18] x86, acpi: Initialize ACPI root table list earlier. References: <1375340800-19332-1-git-send-email-tangchen@cn.fujitsu.com> <1375340800-19332-7-git-send-email-tangchen@cn.fujitsu.com> <1375401251.10300.53.camel@misato.fc.hp.com> In-Reply-To: <1375401251.10300.53.camel@misato.fc.hp.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: Toshi Kani Cc: rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org On 08/02/2013 07:54 AM, Toshi Kani wrote: ...... >> /* >> + * acpi_root_table_init - Initialize acpi_gbl_root_table_list. >> + * >> + * This function will parse RSDT or XSDT, find all tables' phys addr, >> + * initialize acpi_gbl_root_table_list, and record all tables' phys addr >> + * in acpi_gbl_root_table_list. >> + */ >> +void __init acpi_root_table_init(void) > > I think acpi_root_table_init() is a bit confusing with > acpi_boot_table_init(). Perhaps, something like > acpi_boot_table_pre_init() or early_acpi_boot_table_init() is better to > indicate that this new function is called before acpi_boot_table_init(). > OK, will change it to early_acpi_boot_table_init(). >> +{ >> + dmi_check_system(acpi_dmi_table); >> + >> + /* If acpi_disabled, bail out */ >> + if (acpi_disabled) >> + return; >> + >> + /* Initialize the ACPI boot-time table parser */ >> + if (acpi_table_init()) { >> + disable_acpi(); >> + return; >> + } >> +} >> + >> +/* >> * acpi_boot_table_init() and acpi_boot_init() >> * called from setup_arch(), always. >> * 1. checksums all tables >> @@ -1511,21 +1533,7 @@ static struct dmi_system_id __initdata acpi_dmi_table_late[] = { >> >> void __init acpi_boot_table_init(void) > > The comment of this function needs to be updated. For instance, it > describes acpi_table_init(), which you just relocated. > > * acpi_table_init() is separate to allow reading SRAT without > * other side effects. > * Sure. But I don't quite understand this comment. It seems that acpi_table_init() has nothing to do with SRAT. Do you know anything about this ? > >> { >> - dmi_check_system(acpi_dmi_table); >> - >> - /* >> - * If acpi_disabled, bail out >> - */ >> - if (acpi_disabled) >> - return; > > I think this check is still necessary. > Yes. Will add it. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org