Re: [PATCH] mm/page_alloc: remove repetitious local_irq_save() in __zone_pcp_update()

["Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>]

On 06/19/2013 03:40 AM, Cody P Schafer wrote:
> __zone_pcp_update() is called via stop_machine(), which already disables
> local irq.
> 
> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat

> ---
>  mm/page_alloc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bac3107..b46b54a 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6179,7 +6179,7 @@ static int __meminit __zone_pcp_update(void *data)
>  {
>  	struct zone *zone = data;
>  	int cpu;
> -	unsigned long batch = zone_batchsize(zone), flags;
> +	unsigned long batch = zone_batchsize(zone);
> 
>  	for_each_possible_cpu(cpu) {
>  		struct per_cpu_pageset *pset;
> @@ -6188,12 +6188,10 @@ static int __meminit __zone_pcp_update(void *data)
>  		pset = per_cpu_ptr(zone->pageset, cpu);
>  		pcp = &pset->pcp;
> 
> -		local_irq_save(flags);
>  		if (pcp->count > 0)
>  			free_pcppages_bulk(zone, pcp->count, pcp);
>  		drain_zonestat(zone, pset);
>  		setup_pageset(pset, batch);
> -		local_irq_restore(flags);
>  	}
>  	return 0;
>  }
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>