From: Dave Hansen <dave.hansen@intel.com>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com,
akpm@linux-foundation.org, tj@kernel.org, trenn@suse.de,
yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com,
laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
mgorman@suse.de, minchan@kernel.org, mina86@mina86.com,
gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com,
lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com,
prarit@redhat.com, x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [Part3 PATCH v2 2/4] mem-hotplug: Skip LOCAL_NODE_DATA pages in memory offline procedure.
Date: Thu, 13 Jun 2013 10:17:02 -0700 [thread overview]
Message-ID: <51B9FE8E.9000109@intel.com> (raw)
In-Reply-To: <1371128636-9027-3-git-send-email-tangchen@cn.fujitsu.com>
On 06/13/2013 06:03 AM, Tang Chen wrote:
> +static inline bool is_local_node_data(struct page *page)
> +{
> + return (unsigned long)page->lru.next == LOCAL_NODE_DATA;
> +}
page->lru is already in a union. Could you please just add a new entry
to the union with a nice associated comment instead of reusing it this way?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-13 17:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 13:03 [Part3 PATCH v2 0/4] Support hot-remove local pagetable pages Tang Chen
2013-06-13 13:03 ` [Part3 PATCH v2 1/4] bootmem, mem-hotplug: Register local pagetable pages with LOCAL_NODE_DATA when freeing bootmem Tang Chen
2013-06-13 14:16 ` Michal Nazarewicz
2013-06-14 5:37 ` Tang Chen
2013-06-13 13:03 ` [Part3 PATCH v2 2/4] mem-hotplug: Skip LOCAL_NODE_DATA pages in memory offline procedure Tang Chen
2013-06-13 17:17 ` Dave Hansen [this message]
2013-06-14 5:45 ` Tang Chen
2013-06-13 13:03 ` [Part3 PATCH v2 3/4] mem-hotplug: Skip LOCAL_NODE_DATA pages in memory online procedure Tang Chen
2013-06-13 13:03 ` [Part3 PATCH v2 4/4] mem-hotplug: Do not free LOCAL_NODE_DATA pages to buddy system in hot-remove procedure Tang Chen
2013-06-17 1:58 ` [Part3 PATCH v2 0/4] Support hot-remove local pagetable pages Jianguo Wu
2013-06-17 2:07 ` Tang Chen
2013-06-18 17:05 ` Vasilis Liaskovitis
2013-06-18 23:59 ` Toshi Kani
2013-06-19 2:58 ` Yasuaki Ishimatsu
2013-06-19 15:32 ` Toshi Kani
2013-06-19 7:29 ` Tang Chen
2013-06-19 10:00 ` Vasilis Liaskovitis
2013-06-19 15:18 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9FE8E.9000109@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=jweiner@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=trenn@suse.de \
--cc=vasilis.liaskovitis@profitbricks.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox