From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx159.postini.com [74.125.245.159]) by kanga.kvack.org (Postfix) with SMTP id 8B91C6B0036 for ; Tue, 11 Jun 2013 11:16:12 -0400 (EDT) Received: by mail-lb0-f178.google.com with SMTP id y6so6014785lbh.23 for ; Tue, 11 Jun 2013 08:16:10 -0700 (PDT) Message-ID: <51B73F38.6040802@kernel.org> Date: Tue, 11 Jun 2013 18:16:08 +0300 From: Pekka Enberg MIME-Version: 1.0 Subject: Re: [PATCH] slab: prevent warnings when allocating with __GFP_NOWARN References: <1370891880-2644-1-git-send-email-sasha.levin@oracle.com> <51B62F6B.8040308@oracle.com> <0000013f3075f90d-735942a8-b4b8-413f-a09e-57d1de0c4974-000000@email.amazonses.com> <51B67553.6020205@oracle.com> <51B72323.8040207@oracle.com> <0000013f33cdc631-eadb07d1-ef08-4e2c-a218-1997eb86cde9-000000@email.amazonses.com> In-Reply-To: <0000013f33cdc631-eadb07d1-ef08-4e2c-a218-1997eb86cde9-000000@email.amazonses.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Sasha Levin , "linux-mm@kvack.org" , Andrew Morton , LKML On Tue, 11 Jun 2013, Sasha Levin wrote: >> I think that leaving the warning makes sense to catch similar >> things which are actually bugs - we had a similar issue with >> /dev/kmsg (if I remember correctly) which actually pointed to >> a bug. On 6/11/13 6:14 PM, Christoph Lameter wrote: > Right. Requesting an allocation larger than even supported by the page > allocator from the slab allocators that are specializing in allocations of > small objects is usually an indication of a problem in the code. So you're OK with going forward with Sasha's patch? It's needed because __GFP_NOWARN was specifically added there to fix this issue earlier. Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org