On 06/06/2013 06:48 AM, Andrew Morton wrote: > On Thu, 6 Jun 2013 11:45:09 +1000 Dave Chinner wrote: > >> Andrew, if you want to push the changes back to generic per-cpu >> counters through to Linus, then I'll write the patches for you. But >> - and this is a big but - I'll only do this if you are going to deal >> with the "performance trumps all other concerns" fanatics over >> whether it should be merged or not. I have better things to do >> with my time have a flamewar over trivial details like this. > > Please view my comments as a critique of the changelog, not of the code. > > There are presumably good (but undisclosed) reasons for going this way, > but this question is so bleeding obvious that the decision should have > been addressed up-front and in good detail. > > And, preferably, with benchmark numbers. Because it might have been > the wrong decision - stranger things have happened. > I have folded the attached patch here. Let me know if it still needs more love.