From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx156.postini.com [74.125.245.156]) by kanga.kvack.org (Postfix) with SMTP id 579A96B0037 for ; Mon, 3 Jun 2013 11:53:17 -0400 (EDT) Message-ID: <51ACBBEA.2040804@sr71.net> Date: Mon, 03 Jun 2013 08:53:14 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCHv4 23/39] thp: wait_split_huge_page(): serialize over i_mmap_mutex too References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-24-git-send-email-kirill.shutemov@linux.intel.com> <519BEFAE.1080800@sr71.net> <20130603150214.54C34E0090@blue.fi.intel.com> In-Reply-To: <20130603150214.54C34E0090@blue.fi.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On 06/03/2013 08:02 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >> On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: >>> From: "Kirill A. Shutemov" >> -#define wait_split_huge_page(__anon_vma, __pmd) \ >>> +#define wait_split_huge_page(__vma, __pmd) \ >>> do { \ >>> pmd_t *____pmd = (__pmd); \ >>> - anon_vma_lock_write(__anon_vma); \ >>> - anon_vma_unlock_write(__anon_vma); \ >>> + struct address_space *__mapping = \ >>> + vma->vm_file->f_mapping; \ >>> + struct anon_vma *__anon_vma = (__vma)->anon_vma; \ >>> + if (__mapping) \ >>> + mutex_lock(&__mapping->i_mmap_mutex); \ >>> + if (__anon_vma) { \ >>> + anon_vma_lock_write(__anon_vma); \ >>> + anon_vma_unlock_write(__anon_vma); \ >>> + } \ >>> + if (__mapping) \ >>> + mutex_unlock(&__mapping->i_mmap_mutex); \ >>> BUG_ON(pmd_trans_splitting(*____pmd) || \ >>> pmd_trans_huge(*____pmd)); \ >>> } while (0) ... >> Could you also describe the lengths to which you've gone to try and keep >> this macro from growing in to any larger of an abomination. Is it truly >> _impossible_ to turn this in to a normal function? Or will it simply be >> a larger amount of work that you can do right now? What would it take? > > Okay, I've tried once again. The patch is below. It looks too invasive for > me. What do you think? That patch looks great to me, actually. It really looks to just be superficially moving code around. The diffstat is even too: > include/linux/huge_mm.h | 35 ++++++++++++++-------------- > include/linux/mm.h | 24 +++++++++++++++++-- > include/linux/mm_types.h | 37 +++++++++++++++++++++++++++++ > include/linux/rmap.h | 58 ----------------------------------------------- > mm/memory.c | 8 +++--- > 5 files changed, 81 insertions(+), 81 deletions(-) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org