Re: [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages

[Liu Jiang <liuj97@gmail.com>]

On 05/26/2013 09:16 AM, KOSAKI Motohiro wrote:
>> ---
>>  mm/page_alloc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 98cbdf6..23b921f 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -6140,6 +6140,8 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
>>  		list_del(&page->lru);
>>  		rmv_page_order(page);
>>  		zone->free_area[order].nr_free--;
>> +		if (PageHighMem(page))
>> +			totalhigh_pages -= 1 << order;
>>  		for (i = 0; i < (1 << order); i++)
>>  			SetPageReserved((page+i));
>>  		pfn += (1 << order);
> 
> memory hotplug don't support 32bit since it was born, at least, when the system has highmem. 
> Why can't we disable memory hotremove when 32bit at compile time?
Hi KOSAKI,
	Could you please help to give more information on the background
about why 32bit platforms with highmem can't support memory hot-removal?
We are trying to enable memory hot-removal on some 32bit platforms with
highmem, really appreciate your help here!
Thanks!
Gerry

> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>