From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D36B0C369C2 for ; Fri, 25 Apr 2025 19:56:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E86E6B000C; Fri, 25 Apr 2025 15:56:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BF096B000D; Fri, 25 Apr 2025 15:56:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 538BA6B000E; Fri, 25 Apr 2025 15:56:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 347056B000C for ; Fri, 25 Apr 2025 15:56:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C998B808A7 for ; Fri, 25 Apr 2025 19:56:41 +0000 (UTC) X-FDA: 83373623802.11.65924E1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 39620180010 for ; Fri, 25 Apr 2025 19:56:39 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UAULLfte; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745610999; a=rsa-sha256; cv=none; b=Skup6AFzYlviThVnG/6M2GJ/6Ym+PhuBlo2oGNeYqhieJiB+Z5sLvbilcA4TsoTDdLHy1O Y3XW5ZSPXBcc4vsGGxgH2yxVv+XpMlf9c+2gXuKCAFQgSWB37vL14Jd3E6HF/ni0s7AHep 6gaoZWPI/0pA+7YM/kaPK0UC6fBnZKc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UAULLfte; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745610999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bE2Dp5Yo0pObZA0Gc62tH8dA81bjnFJ9ScY4Xen6Glg=; b=lJO0SK4ji30Um7k4ZHRAGo2jGHl8tQWTK9kcbDLhCtg4u3l9rbtoEOWikDIG7WcQwZOO8T eNw/w6WLUqPt9G9ywqkTEk8rk03ytYbIilZrC1nar+u9qK5YTy67KQ8WhkK7v6+MJEO+gs qb7cuTer7DbrEJAw9SP+/FWfEMzgY08= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745610998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bE2Dp5Yo0pObZA0Gc62tH8dA81bjnFJ9ScY4Xen6Glg=; b=UAULLfteh0HWaVIQ9RhjgnIveRioHIiJVDk5zWR80Wr72A4b1nnJFLG9y9npYNJM4QYFiO dAbdwUrVmhAoGlxIYau1sLTWQe0i/8evUuGiEZ+mznmEWD3fiMWZxSuyOodo4nPcKlt3wO wBpmHD/WTvMLp0E0jfMCOnzVS9bSXUc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-xFES1D0UO2KuuXfPYU78hg-1; Fri, 25 Apr 2025 15:56:37 -0400 X-MC-Unique: xFES1D0UO2KuuXfPYU78hg-1 X-Mimecast-MFC-AGG-ID: xFES1D0UO2KuuXfPYU78hg_1745610996 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ce8f82e66so12880975e9.3 for ; Fri, 25 Apr 2025 12:56:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745610996; x=1746215796; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bE2Dp5Yo0pObZA0Gc62tH8dA81bjnFJ9ScY4Xen6Glg=; b=Ej0ihtbIUzAgNHPaYM0xFTfGcURUeo7B5/iyb+q9p0GW1Nvt47jBYOR6CIxibnEqKZ Diu0wv0WE27hY9tBrYvQNyFRNrxtxXAnF4l6JH9kv/CIHOQPc+8YFnQGAY7cx9ntnSRv WxHtPzrtq0vHDeOIYtNJPIy4AsvhKraxOFbb5mGP9cxR6iXQOpkm2fILhrAoMbPyXxUc EYsBMq0HJ2CfhczRR3dAbZdH3P7+qIH0Zk7u2DepZI+bdMzvQ4EsZPucRddrH19lqMrm vmP0tfcXl74wU8BOm4c2BjJjDq8MTpWm3I+u2HJuRmD0gD2ahP4249mVMWH6xUCYVu0V x/MA== X-Forwarded-Encrypted: i=1; AJvYcCXIJvtwZPHJFt+p8YwQ8GTpG85Cog9LpEVXhi+1q0nCByQi29nem5KTMxHiBvZTx4J5/lYY4L/s4w==@kvack.org X-Gm-Message-State: AOJu0YxeEo8nnNQl2MM+3Iq+IXBCl1aNX69FQLLhQ4n+e+6n4bwCVZ7w mbS2iO/5BPtJt8p7jOT9zdU2pDJ1Ss6roJwv/YScie7N9VUWj+5m5lw7PtrF5wIOmWYs0/ccDOq eQVWl8/W+nrzZFqa++/MN52nrINJU0UtV6JbFq7LDnEAbrV6B X-Gm-Gg: ASbGncvdagRaDY2uJjx1+plGmpHQ/ZwelxvcJFajra8skzbyyEg6MSDTu8Je5GObEfC o1zvli1WDjM/IllkbtaGPvvlyOeswoQn2iKN1YkdIFMusVCauMVW4HtukPMkG37jpnagEtMt/OL iJroDVPKWfPTjyIptFLqw0pDpWIgFtEehiz8MyGlgtv64L3NwliHqKZAQd3yFk3xWn1Uso+f2WA sFAVsaMaxT4pHmD4QV2zROnyMNo6p6bDq9BzzE0gN/QBaKbg4VasY1fZXWZ/i+zg60VvMXkuYp0 jgq/pl2YDja98NkCkeexPePOaT4UqjwgDTPcjQc2php1PMeH42nUbCfpIQdd3Ui6mtBTE3jsgmv YKIg7gzZB8dZOCVquhwDLw361/LHF50hicRhc X-Received: by 2002:a05:600c:a4d:b0:440:68db:9fef with SMTP id 5b1f17b1804b1-440a669b52cmr29619705e9.20.1745610996271; Fri, 25 Apr 2025 12:56:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDTvNhYItxE+4Y0RI+qao1NGVdbXY23J5yiDp5FychjNVZxG0vly/CBGVBOu3qdA9XOIO6hw== X-Received: by 2002:a05:600c:a4d:b0:440:68db:9fef with SMTP id 5b1f17b1804b1-440a669b52cmr29619355e9.20.1745610995912; Fri, 25 Apr 2025 12:56:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c70f:6900:6c56:80f8:c14:6d2a? (p200300cbc70f69006c5680f80c146d2a.dip0.t-ipconnect.de. [2003:cb:c70f:6900:6c56:80f8:c14:6d2a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2d86f7sm66114125e9.32.2025.04.25.12.56.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 12:56:34 -0700 (PDT) Message-ID: <519e3bbf-b198-4e55-81e8-0a77d8ab03d3@redhat.com> Date: Fri, 25 Apr 2025 21:56:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot() To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Rb9FFnkrRxe3Nz2q7_B8sB406MG4D72AI_7d2vVBvBA_1745610996 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 39620180010 X-Stat-Signature: zmtpb9ky8gfqq3t674j83hmtgt6i1p5o X-Rspam-User: X-HE-Tag: 1745610999-144514 X-HE-Meta: U2FsdGVkX18agFL+WmkervtqpFxEgjqM9QgR4A1gFEXdJwX+jQjLjo/NMfGoPxaL8hsdtCkMUNPIPiLWjiS2d7JAlgsQh7AJHOCYSJorxz2lLEb8tx2vwVczCpVfwCBaKD1Jc1SvAlQH3gi35NhQ2vDAqBOinau6onDuS0uOpk8OvOwqGk78H0kwizIaW0GZ9369o7LKJW1NDMtmzoGT/ySXR/X6Do7qP6TZCu78n+c9kcAYcfcUmbcM4H6rpeGHK9Ah2mZ3k1aWYPybynwUmN2RjP2fExuXIwJg6H03nrp7INefU7GpliP25aKMU724jffZ09XSdn1ZATu5pB6SvreFDmYK3V/ne/hkK5U4/x0w5c9qhzjCks1O33a99VUFmqRQWvcXL7gyNq7C8NR3X4PW/X/JL1LJgnl74bDkMHbz8/n0q+Vm54fA8tadpQRtkD5iLELlG57wL32ItVrRMEU1WEGMMLn7vAZrWk4n9/yYRccXt53cXf3T77Ql1YL06NLsQOol/UAtrNaMNfgjVU4m0soq0vlS565zyMatl6CezdacD8Q2UnDt7DqszlmB+pGYE3LOSr6F9qyF5C6HwzEA9me1e+zxCZmqUJNYxzi1aOI83G1Bidxice8j1k8fPbqyuBCVMdGkgo/QRiI56grHupC4uSKaiyHePLGJnxeNPPlKHDphPUpy0fTd1aAB+0VQ0Nu+LHT0xtTAtjlaqfn17h2EZKXZIrDS0QoNvjl/9FtKPRktFgts/TAsy6Ir2SvjqaAzuN8G5SsSKLNM9eHh9HIly+2eI3sUW/q/fcncnv7NjrJbAaMu8C9JaIjRtoSspG4bzV9iCzNjk7caEUdPRrBYYkBgL/dH6CiuZwK7f3zkWcGwyK2+NEvlN2lAtfnhQq6j3zXTQx6D84C6nqVepOrS1V4IXwgxdr7HdsAel51817IyyySt3f+uMo60OeoiLpWBzUm0fVor48+ D1YH+qLp R7wQcfG8YXh1fJdXEladp0NoYdvGfKNxYjam2D+1yWpeFtmoE7VL56UGWb3InKXmwcvFrsDm5jowEFGMJBDesPOXHp/dKMuzP6RI9xd6zM2Rr4ICHtoHZrC6XyEiikI2geiweJRLQHMMifFHT85xfnGgYqHfO3wTAt/CA1NKWR17ZjNVMudcsyIHwvSsIC8UxpI10PqMl+qilkXiH7QHPYn9omFamDrEgi11g8wvozLmcmqu9x7+CTV6JNBM0vrzJHsTx9sPAskZq5wpDBTToMrz8lXLIjmpxLwi0U6+WdBh3/07TsE2qGEraQ8gcrqT0AtMGMV/nF74v5SHvJScIxEIvakZ6hIuICWCaY/L1rM4G5ZNUIYyjjc3B/YwuEnJ4X/sTqXtnWt5T2rGc0rHIPYZep5OFw8YBvx+aQg60hFxxasMYqcAnArEMrqXW48OvZ+phKbUxbei5UVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> - track_pfn_insert(vma, &pgprot, pfn); >> + if (pfnmap_sanitize_pgprot(pfn_t_to_pfn(pfn), PAGE_SIZE, &pgprot)) >> + return VM_FAULT_FALLBACK; > > Would "pgtable" leak if it fails? If it's PAGE_SIZE, IIUC it won't ever > trigger, though. Missed that comment. I can document that pgprot will only be touched if the function succeeds. -- Cheers, David / dhildenb