From: Dave Hansen <dave.hansen@intel.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>,
Babu Moger <babu.moger@amd.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, luto@kernel.org,
shuah@kernel.org, linuxram@us.ibm.com, bauerman@linux.ibm.com,
bigeasy@linutronix.de
Subject: Re: [PATCH 4/5] x86/pkeys: replace PKRU modification infrastructure
Date: Tue, 1 Jun 2021 15:49:34 -0700 [thread overview]
Message-ID: <519bbb92-8744-9da2-a8c1-c0c64fbd8005@intel.com> (raw)
In-Reply-To: <5617bb6d-2202-53f4-8b4d-7b3e72ca0158@oracle.com>
On 6/1/21 3:43 PM, Dave Kleikamp wrote:
> On 6/1/21 4:54 PM, Babu Moger wrote:
>> Hi Dave,
>> Thanks for the patches and trying to address the issues.
>>
>> I know these patches are in early stages and there is still a discussion
>> on different ways to address these issues. But I wanted to give a try
>> anyway.
>>
>> Tried to boot the system with these patches. But system did not come up
>> after this patch(#4). System fails very early in the boot process. So, I
>> could'nt collect much logs. It failed both on AMD and Intel machines.
>> I will try to collect more logs.
>> Thanks
>> Babu
>
> Same here. Hitting this line in arch/x86/include/asm/fpu/xstate.h
>
> BUG_ON(!(xstate->header.xcomp_bv & BIT_ULL(xfeature_nr)));
>
> [ 0.384929] kernel BUG at arch/x86/include/asm/fpu/xstate.h:177!
Thanks for the report. I am, indeed, reworking this code a bit. I'll
pay close attention if this code remains in some form.
next prev parent reply other threads:[~2021-06-01 22:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 23:51 [PATCH 0/5] x86/pkeys: PKRU manipulation bug fixes and cleanups Dave Hansen
2021-05-27 23:51 ` [PATCH 1/5] x86/pkeys: move read_pkru() and write_pkru() Dave Hansen
2021-05-27 23:51 ` [PATCH 2/5] x86/pkeys: rename write_pkru() Dave Hansen
2021-05-27 23:51 ` [PATCH 3/5] x86/pkeys: skip 'init_pkru' debugfs file creation when pkeys not supported Dave Hansen
2021-05-27 23:51 ` [PATCH 4/5] x86/pkeys: replace PKRU modification infrastructure Dave Hansen
2021-05-28 1:17 ` Mika Penttilä
2021-05-28 17:00 ` Dave Kleikamp
2021-06-01 21:54 ` Babu Moger
2021-06-01 22:43 ` Dave Kleikamp
2021-06-01 22:49 ` Dave Hansen [this message]
2021-05-27 23:51 ` [PATCH 5/5] selftests/vm/pkeys: exercise x86 XSAVE init state Dave Hansen
2021-05-28 15:32 ` [PATCH 0/5] x86/pkeys: PKRU manipulation bug fixes and cleanups Thomas Gleixner
2021-05-28 16:11 ` Dave Hansen
2021-05-28 17:13 ` Andy Lutomirski
2021-05-28 17:19 ` Thomas Gleixner
2021-05-28 17:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519bbb92-8744-9da2-a8c1-c0c64fbd8005@intel.com \
--to=dave.hansen@intel.com \
--cc=babu.moger@amd.com \
--cc=bauerman@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dave.kleikamp@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox