From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx186.postini.com [74.125.245.186]) by kanga.kvack.org (Postfix) with SMTP id 8425D6B0002 for ; Thu, 23 May 2013 11:49:16 -0400 (EDT) Message-ID: <519E3A79.5070803@sr71.net> Date: Thu, 23 May 2013 08:49:13 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCHv4 07/39] thp, mm: basic defines for transparent huge page cache References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-8-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On 05/23/2013 03:36 AM, Hillf Danton wrote: > On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov > wrote: >> > From: "Kirill A. Shutemov" > Better if one or two sentences are prepared to show that the following > defines are necessary. ... >> > >> > +#define HPAGE_CACHE_ORDER (HPAGE_SHIFT - PAGE_CACHE_SHIFT) >> > +#define HPAGE_CACHE_NR (1L << HPAGE_CACHE_ORDER) >> > +#define HPAGE_CACHE_INDEX_MASK (HPAGE_CACHE_NR - 1) Yeah, or just stick them in the patch that uses them first. These aren't exactly rocket science. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org