linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ignacio Moreno Gonzalez <Ignacio.MorenoGonzalez@kuka.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Ignacio.MorenoGonzalez@kuka.com, Liam.Howlett@oracle.com,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, willy@infradead.org,
	yang@os.amperecomputing.com
Subject: Re: [PATCH] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled
Date: Tue, 6 May 2025 14:26:09 +0200	[thread overview]
Message-ID: <51997572-3575-4fad-9636-cca5178c561a@kuka.com> (raw)
In-Reply-To: <ee95ddf9-0d00-4523-ad2a-c2410fd0e1a3@lucifer.local>

Hi all,

Thanks for your comments and sorry for the late reply.

On 5/3/2025 11:50 AM, Lorenzo Stoakes wrote:
> In which case, Ignacio - could you apply both Matthew's change and address
> the nit below and send a v2?
> 
> Thanks!
> 
> [0]: https://lore.kernel.org/linux-mm/aBTCtOXBhUK_FLU6@casper.infradead.org/

Sure! I will separate the changes into two patches, since the first one will include the 'Fixes' tag (as discussed here). I also think it is a good approach to keep the patches separated since they address different issues:

- The mman.h (calc_vm_flag_bits) patch addresses mapping MAP_STACK to VM_NOHUGEPAGE on !THP kernels.
- The huge_mm.h (madvice) patch addresses the issue that VM_NOHUGEPAGE should be a no-op on !THP kernels.

Regards,
Ignacio


  parent reply	other threads:[~2025-05-06 12:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02  9:31 Ignacio Moreno Gonzalez via B4 Relay
2025-05-02 12:46 ` Lorenzo Stoakes
2025-05-02 20:53   ` Yang Shi
2025-05-03  9:50     ` Lorenzo Stoakes
2025-05-05 17:53       ` Yang Shi
2025-05-06 12:26       ` Ignacio Moreno Gonzalez [this message]
2025-05-02 13:03 ` Matthew Wilcox
2025-05-02 13:12   ` Lorenzo Stoakes
2025-05-02 14:16     ` Matthew Wilcox
2025-05-02 14:24       ` Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51997572-3575-4fad-9636-cca5178c561a@kuka.com \
    --to=ignacio.morenogonzalez@kuka.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=willy@infradead.org \
    --cc=yang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox