From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id BD3B06B0032 for ; Wed, 15 May 2013 23:29:50 -0400 (EDT) Message-ID: <5194529C.2040200@redhat.com> Date: Thu, 16 May 2013 11:29:32 +0800 From: Zhouping Liu MIME-Version: 1.0 Subject: Re: [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node' References: <1368637812-7329-1-git-send-email-sanweidaying@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Zhouping Liu , "linux-mm@kvack.org" , Christoph Lameter , Matt Mackall , LKML On 05/16/2013 02:10 AM, Pekka Enberg wrote: > On Wed, May 15, 2013 at 8:10 PM, Zhouping Liu wrote: >> From: Zhouping Liu >> >> commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc()) >> forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'. >> >> Signed-off-by: Zhouping Liu >> --- >> mm/slab.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/slab.c b/mm/slab.c >> index 8ccd296..8efb5f7 100644 >> --- a/mm/slab.c >> +++ b/mm/slab.c >> @@ -3339,7 +3339,7 @@ done: >> } >> >> /** >> - * kmem_cache_alloc_node - Allocate an object on the specified node >> + * slab_alloc_node - Allocate an object on the specified node >> * @cachep: The cache to allocate from. >> * @flags: See kmalloc(). >> * @nodeid: node number of the target node. > The point of the comment is to document kernel API and whereas > slab_alloc_node() is internal to the slab allocator. Can you please > just move it on top of kmem_cache_alloc_node() definition in the same > file? OK, thanks for reviewing, please check V2. Thanks, Zhouping -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org