From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787DBC4332F for ; Mon, 7 Mar 2022 17:11:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6F4E8D0002; Mon, 7 Mar 2022 12:11:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1E578D0001; Mon, 7 Mar 2022 12:11:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D818D0002; Mon, 7 Mar 2022 12:11:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id B0E888D0001 for ; Mon, 7 Mar 2022 12:11:03 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7B4B022F1D for ; Mon, 7 Mar 2022 17:11:03 +0000 (UTC) X-FDA: 79218230406.06.9797FAC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id C920F40019 for ; Mon, 7 Mar 2022 17:11:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6C4A21F37C; Mon, 7 Mar 2022 17:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646673061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PEjkUspmy19fLDLs9qhqoOiHf6dLn/m7lz0Ro537UFY=; b=SGQpSG6FzpDZMOPddCVGoePKHtyUeF4pRtnjW4Oh4VDNuZSzlgf5I3UY6tuuGuBn8b14R8 /REcmMJJ9r+1Qmmlnk9AbjlblcEVLiVG+QqpgdN7f4BVFdGiXUY8UvMvWA9k5IjPBonybH n5ArVPoS/A8igJOW8H+T3xcOomnT230= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646673061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PEjkUspmy19fLDLs9qhqoOiHf6dLn/m7lz0Ro537UFY=; b=W0GN8J/6A7tq1LavfKCI1Z9CvtFTxKS/4KtjUz7Bi5H+PbAQdTNCsHmzasuclFRzHXPVkp Sdr2oehH9pfteQBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 434B513BA5; Mon, 7 Mar 2022 17:11:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tNY4D6U8JmJUWgAAMHmgww (envelope-from ); Mon, 07 Mar 2022 17:11:01 +0000 Message-ID: <5192817a-ed77-50c9-7bca-86d85b4b91dd@suse.cz> Date: Mon, 7 Mar 2022 18:11:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] mm/slub: helper macro __ATTR_XX to make code more clear Content-Language: en-US To: David Rientjes , Lianjie Zhang Cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220306073818.15089-1-zhanglianjie@uniontech.com> <88c427-faec-ba5f-4ed4-bc2dd0873ec0@google.com> From: Vlastimil Babka In-Reply-To: <88c427-faec-ba5f-4ed4-bc2dd0873ec0@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C920F40019 X-Stat-Signature: den7xyy9aaizixhiyofsqdsb6ccy1j9j Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SGQpSG6F; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="W0GN8J/6"; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646673062-530648 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/6/22 23:11, David Rientjes wrote: > On Sun, 6 Mar 2022, Lianjie Zhang wrote: > >> Signed-off-by: Lianjie Zhang > > And VERIFY_OCTAL_PERMISSIONS() can help validate any future change. > > Acked-by: David Rientjes Ok, adding with adjusted subject and non-empty message: mm/slub: use helper macro __ATTR_XX_MODE for SLAB_ATTR(_RO) This allows more concise code, and VERIFY_OCTAL_PERMISSIONS() can help validate any future change.