From: majianpeng <majianpeng@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] mm/kmemleak.c: Merge the consecutive scan-areas.
Date: Tue, 14 May 2013 19:49:51 +0800 [thread overview]
Message-ID: <519224DF.3070807@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]
If the scan-areas are adjacent,it can merge in order to reduce memomy.
And using pr_warn instead of pr_warning.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
mm/kmemleak.c | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index f0ece93..9590a57 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -746,24 +746,36 @@ static void add_scan_area(unsigned long ptr, size_t size, gfp_t gfp)
return;
}
- area = kmem_cache_alloc(scan_area_cache, gfp_kmemleak_mask(gfp));
- if (!area) {
- pr_warning("Cannot allocate a scan area\n");
- goto out;
- }
-
spin_lock_irqsave(&object->lock, flags);
if (ptr + size > object->pointer + object->size) {
kmemleak_warn("Scan area larger than object 0x%08lx\n", ptr);
dump_object_info(object);
- kmem_cache_free(scan_area_cache, area);
goto out_unlock;
}
+ hlist_for_each_entry(area, &object->area_list, node) {
+ if (ptr + size == area->start) {
+ area->start = ptr;
+ area->size += size;
+ goto out_unlock;
+ } else if (ptr == area->start + area->size) {
+ area->size += size;
+ goto out_unlock;
+ }
+
+ }
+ spin_unlock_irqrestore(&object->lock, flags);
+
+ area = kmem_cache_alloc(scan_area_cache, gfp_kmemleak_mask(gfp));
+ if (!area) {
+ pr_warn("Cannot allocate a scan area\n");
+ goto out;
+ }
INIT_HLIST_NODE(&area->node);
area->start = ptr;
area->size = size;
+ spin_lock_irqsave(&object->lock, flags);
hlist_add_head(&area->node, &object->area_list);
out_unlock:
spin_unlock_irqrestore(&object->lock, flags);
--
1.8.3.rc1.44.gb387c77
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-mm-kmemleak.c-Merge-the-consecutive-scan-areas.patch --]
[-- Type: text/x-patch; name="0003-mm-kmemleak.c-Merge-the-consecutive-scan-areas.patch", Size: 0 bytes --]
next reply other threads:[~2013-05-14 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 11:49 majianpeng [this message]
2013-05-24 17:06 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519224DF.3070807@gmail.com \
--to=majianpeng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox