From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747CBC761AF for ; Wed, 29 Mar 2023 14:39:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E62D728000B; Wed, 29 Mar 2023 10:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E12F5280008; Wed, 29 Mar 2023 10:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8C4828000B; Wed, 29 Mar 2023 10:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B6F37280008 for ; Wed, 29 Mar 2023 10:39:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6078340D1C for ; Wed, 29 Mar 2023 14:39:47 +0000 (UTC) X-FDA: 80622194814.28.201FABB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 80C95C001F for ; Wed, 29 Mar 2023 14:39:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H1gL32Xd; spf=pass (imf28.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680100784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eOGvCBK3xTc7UhN8iQW8f99rBt5fCj0lar0/GGKSAUo=; b=WMUZPO+h90AjTYydCZLR6ZAPY40UVUhqpdPZD1SpJ13WqWCBc1ZGaK/dustXJnEStNPNb4 7528eTFrFoceIl73s41kR0Jd+WIV9L46MuusxVuUIStYW6nZ8pUXhWPmMJi6M6JVI7flpJ VXdocY+tTwmi/v4jwTPzg0iBtTxKgHE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H1gL32Xd; spf=pass (imf28.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680100784; a=rsa-sha256; cv=none; b=mbfy0WWojg2wBIVYfqwjKZOzca35gHuM+Bf2fHGNN+gahYE8jWhUf8HbMOJF155xwE/Tc/ wy+QPNL3+FmEqlff3W+QClwyyTOZQDz80vbmO9CWMw7lFEpG0zBBqFlpBKwIPR7e1UYM0g aJ9uOq57of/WF4okNNNyJCwcvotaMss= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680100783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eOGvCBK3xTc7UhN8iQW8f99rBt5fCj0lar0/GGKSAUo=; b=H1gL32Xd8l9r+stE1zqaSSIkEvool+TK9K3ywF5RPyJqZ4sgmRtPTgRVYnmlMTGYU/8nou 8Olg5i+vH8R7M1uuLjxAiD5odE14uqNlBNiK7W8L7rnAQzOAyH6DFlZh0/s476DBoVL3yC XRVleiX1YtKOUEaKP7JcDg7WRS3eQ6M= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-OX_M3mnhOyOLIjTwhOpgsw-1; Wed, 29 Mar 2023 10:39:40 -0400 X-MC-Unique: OX_M3mnhOyOLIjTwhOpgsw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 52F783C10ED2; Wed, 29 Mar 2023 14:39:38 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 900FA2166B33; Wed, 29 Mar 2023 14:39:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-49-dhowells@redhat.com> To: Hannes Reinecke cc: David Howells , Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, linux-afs@lists.infradead.org, rds-devel@oss.oracle.com, linux-x25@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, Christoph Hellwig , linux-wpan@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, Marc Kleine-Budde , Al Viro , linux-hams@vger.kernel.org, mptcp@lists.linux.dev, Jens Axboe , Christian Brauner , netdev@vger.kernel.org, Jeff Layton , linux-kernel@vger.kernel.org, Chuck Lever III , tipc-discussion@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, Linus Torvalds Subject: Re: [RFC PATCH v2 48/48] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <518630.1680100773.1@warthog.procyon.org.uk> Date: Wed, 29 Mar 2023 15:39:33 +0100 Message-ID: <518631.1680100773@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 80C95C001F X-Stat-Signature: hbaj9dhwnjnmctaj1ufnjfx4nqw9dexm X-Rspam-User: X-HE-Tag: 1680100784-889447 X-HE-Meta: U2FsdGVkX1/ZkpCC3Ux0EVCLChoB68TAqv1tShGr9d56U/y6hHoabshEDE35sc4gzde7DlJQBQ8hTzbEnjpWDL87XvSvPNwQDdzSCoQCUdtr+ubGgin57a6aI53cyO68HqKA2V6udxwj1Z2ma9y8Xk+syfU63umMAAaTIyTOMYEWPdzq0lWAflw3qa3JANsdcKyxYPDlG2hN6Kp0jNDsQ+lNK/PyNWOuIh3LJwgdcWjr24C3lm6jjiW3BE5kXmaqI8zyymdlhBNvxfcRv/T1a3WwW0l/in4/L/Huz2n/FOC86djEoChyEIr89MLV0pS5iu7WS+E6sG94sO3aCDmabjs1GS0rqyZV1Ixp63SQu3AlOeE82+rvZMOdeAvbytEgIsVuqjkF4n/xeVmYQVyUVsq8acIIV2gjN+d7IRl5WLXHPR1ngFsYEZgnnOTadLZWj6tbTv5/ol3zDLBkpvYRtP02u+1BygYL7UWs05TrRxtp3tJVmDyoXysvmCtLNUrqI/KVSRZqbHHBE84dAUGgcATXEfgmeKm8z6r+jT9d0U+EGM1QTxXtxu+1NA1OSowtG0H/y4eg6KcR43bxMnY881MoKIaOfvwld475bpHOTYGmbp2wJMMb0ijuqueqif1ZrzcplIGi2qh3qHQkQRzRJ1qPijalLJv1r+SvrNhC8M0np8UthnALQ3FCVCurfyAba/uriCOo6mghTjbizWXs4IUd//b3EkCy7c5l22GXkJATTsw3mdLmup006ORtMYmc/gKrRRiQOA+cCqmkPoyFXX0ICsgtCTXd0aQacRpf8FniCWmShV+wn20WR6IJJxbiH/38cHgSDhEnDhfbTHGlz3lldJQY/baI7TYvatNydcrgGGrHbuJLPnAOIwLACU5MhJe2wL/lyEZXRJgFaYlm6Dswt9XWfIzvdXorAP71G06XXKGND7Z/wym2rdW78ebHnF4POyJWAVsdFPbCIk7 U8mU36M1 +2cqRtiac0mbywhmz2SYG2RYaZFu9WwcaJf4SlNM9/isOXp+0EQRsUJ19jfZcPR8LbTT6YjgpaBUiipXDLDZ7Poz8410/vbTeO/jb3hWzJzgHuUjZScPm697NPlISrGpZdoa9XSi4zzdeWKw7rRxIwBYu17DOmA1U6yKTEKNaRMAvuEV5zR1Bum8qX+45o5etHq3ZdwAeYGwot9Gvu+tXhs5fqkpO3+7xDNCedZAEEJZp0/t8glKH/jXqpk1JJu6zWAN0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hannes Reinecke wrote: > > [!] Note: This is a work in progress. At the moment, some things won't > > build if this patch is applied. nvme, kcm, smc, tls. Actually, that needs updating. nvme and smc now build. > Weelll ... what happens to consumers of kernel_sendpage()? > (Let's call them nvme ...) > Should they be moved over, too? Patch 42 should address NVMe, I think. I can't test it, though, as I don't have hardware. There should be no callers of kernel_sendmsg() by the end of this patchset, and the only remaining implementors of sendpage are Chelsio-TLS, AF_TLS and AF_KCM, which as stated in the cover, aren't yet converted and won't build. > Or what is the general consensus here? > > (And what do we do with TLS? It does have a ->sendpage() version, too ...) I know. There are three things left that I need to tackle, but I'd like to get opinions on some of the other bits and I might need some help with AF_TLS and AF_KCM. That said, should I just remove tls_sw_do_sendpage() since presumably the data is going to get copied(?) and encrypted and the source pages aren't going to be held onto? David