From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Glauber Costa <glommer@parallels.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Matt Mackall <mpm@selenic.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH 4/5] mm: soft-dirty bits for user memory changes tracking
Date: Fri, 03 May 2013 19:36:23 +0800 [thread overview]
Message-ID: <5183A137.4060808@linux.vnet.ibm.com> (raw)
In-Reply-To: <517FED64.4020400@parallels.com>
On 05/01/2013 12:12 AM, Pavel Emelyanov wrote:
> +static inline void clear_soft_dirty(struct vm_area_struct *vma,
> + unsigned long addr, pte_t *pte)
> +{
> +#ifdef CONFIG_MEM_SOFT_DIRTY
> + /*
> + * The soft-dirty tracker uses #PF-s to catch writes
> + * to pages, so write-protect the pte as well. See the
> + * Documentation/vm/soft-dirty.txt for full description
> + * of how soft-dirty works.
> + */
> + pte_t ptent = *pte;
> + ptent = pte_wrprotect(ptent);
> + ptent = pte_clear_flags(ptent, _PAGE_SOFT_DIRTY);
> + set_pte_at(vma->vm_mm, addr, pte, ptent);
> +#endif
It seems that TLBs are not flushed and mmu-notification is not called?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-03 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 16:10 [PATCH 0/5] mm: Ability to monitor task memory changes (v4) Pavel Emelyanov
2013-04-30 16:11 ` [PATCH 1/5] clear_refs: sanitize accepted commands declaration Pavel Emelyanov
2013-04-30 16:11 ` [PATCH 2/5] clear_refs: introduce private struct for mm_walk Pavel Emelyanov
2013-04-30 16:12 ` [PATCH 3/5] pagemap: introduce pagemap_entry_t without pmshift bits Pavel Emelyanov
2013-04-30 16:12 ` [PATCH 4/5] mm: soft-dirty bits for user memory changes tracking Pavel Emelyanov
2013-05-03 11:36 ` Xiao Guangrong [this message]
2013-05-03 19:09 ` Pavel Emelyanov
2013-07-11 18:46 ` Andy Lutomirski
2013-07-12 18:38 ` Pavel Emelyanov
2013-04-30 16:12 ` [PATCH 5/5] pagemap: Prepare to reuse constant bits with page-shitf Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5183A137.4060808@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=mtosatti@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox