From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EADCC433FE for ; Wed, 13 Oct 2021 07:35:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26A6F60E74 for ; Wed, 13 Oct 2021 07:35:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 26A6F60E74 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A171294000B; Wed, 13 Oct 2021 03:35:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C72A940007; Wed, 13 Oct 2021 03:35:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B66B94000B; Wed, 13 Oct 2021 03:35:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 7C5C0940007 for ; Wed, 13 Oct 2021 03:35:37 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 32DDE1839C023 for ; Wed, 13 Oct 2021 07:35:37 +0000 (UTC) X-FDA: 78690604314.38.09245FA Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf27.hostedemail.com (Postfix) with ESMTP id C21C170000A0 for ; Wed, 13 Oct 2021 07:35:36 +0000 (UTC) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4HTkpb11MYz9sSS; Wed, 13 Oct 2021 09:35:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KISzn_mNvu5e; Wed, 13 Oct 2021 09:35:35 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4HTkpb079hz9sRn; Wed, 13 Oct 2021 09:35:35 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E0E038B77E; Wed, 13 Oct 2021 09:35:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id UMXHteUt4-Xt; Wed, 13 Oct 2021 09:35:34 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (unknown [172.25.230.103]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AF3C08B763; Wed, 13 Oct 2021 09:35:34 +0200 (CEST) Subject: Re: [PATCH v1 09/10] lkdtm: Fix lkdtm_EXEC_RODATA() To: Kees Cook Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: <7da92e59e148bd23564d63bdd8bcfaba0ba6d1f1.1633964380.git.christophe.leroy@csgroup.eu> <202110130008.EC5E957D4A@keescook> From: Christophe Leroy Message-ID: <5181d261-fe93-5e21-5013-321d85e22354@csgroup.eu> Date: Wed, 13 Oct 2021 09:35:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202110130008.EC5E957D4A@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr-FR X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C21C170000A0 X-Stat-Signature: zezc18idbzemwhhc343cokao3pycoxre Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu X-HE-Tag: 1634110536-403018 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 13/10/2021 =C3=A0 09:09, Kees Cook a =C3=A9crit=C2=A0: > On Mon, Oct 11, 2021 at 05:25:36PM +0200, Christophe Leroy wrote: >> Behind a location, lkdtm_EXEC_RODATA() executes a real function, >> not a copy of do_nothing(). >> >> So do it directly instead of using execute_location(). >=20 > I don't understand this. Why does the next patch not fix this? Well, probably it would, but it looked incorrect in my mind. lkdtm_rodata_do_nothing() is a function which has its own function=20 descriptor, it is not a copy of do_nothing(). If we use execute_location() as modified by next patch, then we will=20 execute it using the function descriptor of do_nothing(). Allthough it=20 most likely works (at least on powerpc as it uses the same TOC) it looks=20 odd to me to do so. Am I missing something ? Christophe >=20 > -Kees >=20 >> >> And fix displayed addresses by dereferencing the function descriptors. >> >> Signed-off-by: Christophe Leroy >> --- >> drivers/misc/lkdtm/perms.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/misc/lkdtm/perms.c b/drivers/misc/lkdtm/perms.c >> index 442d60ed25ef..da16564e1ecd 100644 >> --- a/drivers/misc/lkdtm/perms.c >> +++ b/drivers/misc/lkdtm/perms.c >> @@ -153,7 +153,14 @@ void lkdtm_EXEC_VMALLOC(void) >> =20 >> void lkdtm_EXEC_RODATA(void) >> { >> - execute_location(lkdtm_rodata_do_nothing, CODE_AS_IS); >> + pr_info("attempting ok execution at %px\n", >> + dereference_symbol_descriptor(do_nothing)); >> + do_nothing(); >> + >> + pr_info("attempting bad execution at %px\n", >> + dereference_symbol_descriptor(lkdtm_rodata_do_nothing)); >> + lkdtm_rodata_do_nothing(); >> + pr_err("FAIL: func returned\n"); >> } >> =20 >> void lkdtm_EXEC_USERSPACE(void) >> --=20 >> 2.31.1 >> >=20