Re: [Bug fix PATCH v5] Reusing a resource structure allocated by bootmem

[Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>]

2013/04/24 6:05, Toshi Kani wrote:
> On Tue, 2013-04-23 at 10:37 +0900, Yasuaki Ishimatsu wrote:
>   :
>> The reason why the messages are shown is to release a resource structure,
>> allocated by bootmem, by kfree(). So when we release a resource structure,
>> we should check whether it is allocated by bootmem or not.
>>
>> But even if we know a resource structure is allocated by bootmem, we cannot
>> release it since SLxB cannot treat it. So for reusing a resource structure,
>> this patch remembers it by using bootmem_resource as follows:
>>
>> When releasing a resource structure by free_resource(), free_resource() checks
>> whether the resource structure is allocated by bootmem or not. If it is
>> allocated by bootmem, free_resource() adds it to bootmem_resource. If it is
>> not allocated by bootmem, free_resource() release it by kfree().
>>
>> And when getting a new resource structure by get_resource(), get_resource()
>> checks whether bootmem_resource has released resource structures or not. If
>> there is a released resource structure, get_resource() returns it. If there is
>> not a releaed resource structure, get_resource() returns new resource structure
>> allocated by kzalloc().
>> ---
>> v5:
>> Define bootmem_resource_free as static and poiner for saving memory
>> Fix slab check in free_resource()
>> Move memset outside of spin lock in get_resource()
>
> Please add your "Signed-off-by".  Otherwise the changes look good.
>
> Reviewed-by: Toshi Kani <toshi.kani@hp.com>

Thank you for your review.
I'll resend a patch with my "Signed-off-by" and your "Reviewed-by".

Thanks,
Yasuaki Ishimatsu

>
> Thanks,
> -Toshi
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>