From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9AA7C6FD20 for ; Wed, 22 Mar 2023 01:05:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1F986B007B; Tue, 21 Mar 2023 21:05:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACFCA6B007D; Tue, 21 Mar 2023 21:05:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 996CD900002; Tue, 21 Mar 2023 21:05:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8B09F6B007B for ; Tue, 21 Mar 2023 21:05:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5B5368026C for ; Wed, 22 Mar 2023 01:05:40 +0000 (UTC) X-FDA: 80594741640.28.59B37A9 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf28.hostedemail.com (Postfix) with ESMTP id E3E18C0007 for ; Wed, 22 Mar 2023 01:05:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679447138; a=rsa-sha256; cv=none; b=mw7WXfUlh2nOr6rY3W6EkGFkiWvS6Cs7UwtJ57BbVjlW8Qje5ut9YtcWrRtoj0JOA/rRPC xYXwOkxKllfEvEcvZtoRQ5HgY9ViFhnD+GdDib3hL1cRwAlObkLqo8G8l/exn8FrPBjn9h mUQN2q72EFWK7O+Arcyp7UI3pF0KcEc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679447138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vvz8apu6xrkwX2iSi9VJoC7a/jMTebRcyIZ5GqGtil4=; b=v6lJ4P9tje8wmie/CrDIrQ3Rdhf/QzACYPd6O2VfSBjc9Gj2cXl/ctwmFDF05G/dKz18Gw jmIqORp58bhz5TY3UgeaS+Zz6aL2zlCkxDdJyW2F4Bt4rGGTLs8BjFRnRVdIKu0g7tIFj1 6HyfSzqcDLbFmyvQoqJjRtjtmlR8hSM= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Ph9GY1Fr1zrW1T; Wed, 22 Mar 2023 09:04:05 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 22 Mar 2023 09:05:05 +0800 Message-ID: <51651742-8c48-73c7-b283-4465b28fc0a0@huawei.com> Date: Wed, 22 Mar 2023 09:05:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: next-20230321: arm64: Unable to handle kernel paging request at virtual address Content-Language: en-US To: Luis Chamberlain , Nathan Chancellor CC: Petr Mladek , Naresh Kamboju , open list , Linux-Next Mailing List , , linux-mm , Andrew Morton , Arnd Bergmann , Anders Roxell , Stephen Rothwell , Steven Rostedt , Naoya Horiguchi References: <20230321155626.GA3765079@dev-arch.thelio-3990X> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: E3E18C0007 X-Rspamd-Server: rspam01 X-Stat-Signature: 8kuofyanrwzhcopjm1fr3o8dogtafg4e X-HE-Tag: 1679447134-482739 X-HE-Meta: U2FsdGVkX1/m1ecG78qMyaeloFI4MeCiN+8OYdL8rfqhNCdWYfBdWlOZWfJ7QbFHS+z7vNeBF9bzqeJZ+HoDNbYc/3YrjKL9Qwp5WXNxfpR8tfnkM4DTk2AyXakG5Kq3WRy8U0p3DS4h/KtyXkbStJ/owTApZ15YVidXSlBixZlbZKvI+2MU0NIV/RLrtalWPq4CwaMyWASSvVMBJ81QxX14oyb69MO/LIK4ZnP4N6Blkzl/MjmUcuDBWoOloChoZdU4sV6iwsDcKVEcAV+R4WjJEz5VdntRtc8N4EjBi5l6VNC7U0mrDuerbGXfOQQD9rSk1yPS0SOoyK2vfEwATe7BGenHT4Ij35gB9o9i3jJY6IhzFUx31poMXVu3uGTHHj+f+his6ZaYASf+oP7e6YYRxs87GqSAVkhU3HvyHf89zm6URXvpJLGLDyYTvpYMifh3JZdzo0GQnw1cTO9B1ZZK+cqwm5/W7/KPe9+to23pZkx9kkwDjvKqHD9yvVR2mAtwPfZykjamkj8pAj1SosjJd2jdLxY6UEbnrEEza7xslDBFfimFh/Rl/J3PtO/5Vm3wMhtZ4IpV0LTvoF+2bpfqoeFnX0ca1bphOTgoFwpuLaTcFok9rKB5RIDzRAXJOTr8wVO2oChy4KpNKQWx3LqmeEiDa+uE9/ZjjM9jy1KtK6xZJbp0sB8Ec30ZWkd3PmP2WMZnXD2FlQtGUatasMLB1Er6eyA0/yJeDoACs00UL7HJtrELea4oBSUXRa/pqfKHcxROtm9ibJiA2EKx5pg03AtxL16/Iei2NJXPkUcunrZ1QzlOk0ELVOJIyJgzKuYPOe0oWV+71JtHZPfzYkmI7zlQLKkW1H2eFeobpU111QCvhQXEJCTS4YnJAYlWJoYh3Xz69aqi5tkurhuLe4OKzhvJ93e4/pIloCT8kOx8We7gQUTcoYHFad7jZAGZqtTb3EXMqCLSMsdn2Cc i4OZU1bw Pbah2u11+IDzbbF4zXHXfcSA+GbBf1vj0Su+h6UxwMXRMXaYl4Rx25qxnKY6tPbEhPuPdJySPPygpxau5HsGzyeu/nUc7yKvTWu9tp8jnoWmgvSCFxiJAEbCDx/xlwqamOW55rxfUUsI4CvnvLbaq/M1lpsRGru2zTYaJe5qCZ5AxNgnkhHEILzLlSiSbeLmmVeymJklhWHDQhlB3CmhzaBuQWFd2X0TTUT6t099kIAfRY7d2m1WCobgvAWOz0vvrhfJYUypRkw27eYDawYeoOV7PIWRhqIWg27nu3bdFQAHtPgUaAgyyIiAc5l1BJZGfFD4eCaXq9cIqAH5zL2+7K8AKDfAImGifEVm4Hh7Ogo9C7Tgkfuq9TRHOmKHzGO8gdOe6WUlJ0IjSrng= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/22 0:59, Luis Chamberlain wrote: > On Tue, Mar 21, 2023 at 08:56:26AM -0700, Nathan Chancellor wrote: >> On Tue, Mar 21, 2023 at 10:27:02AM +0100, Petr Mladek wrote: >>> Hi, >>> >>> I add Luis into Cc. >>> >>> On Tue 2023-03-21 11:42:56, Naresh Kamboju wrote: >>>> The following kernel crash was noticed on arm64 Juno-r2 and Raspberry Pi 4 >>>> Model B on Linux next-20230321. >>>> >>>> Reported-by: Linux Kernel Functional Testing >>>> >>>> log: >>>> ---- >>>> [ 3.071500] Unable to handle kernel paging request at virtual >>>> address 0000000000001000 >>> >>> I guess that this is exactly PAGE_SIZE (4k). >>> >>>> [ 3.079432] Mem abort info: >>>> [ 3.082225] ESR = 0x0000000096000004 >>>> [ 3.085977] EC = 0x25: DABT (current EL), IL = 32 bits >>>> [ 3.091295] SET = 0, FnV = 0 >>>> [ 3.094350] EA = 0, S1PTW = 0 >>>> [ 3.097491] FSC = 0x04: level 0 translation fault >>>> [ 3.102373] Data abort info: >>>> [ 3.105252] ISV = 0, ISS = 0x00000004 >>>> [ 3.109089] CM = 0, WnR = 0 >>>> [ 3.112055] [0000000000001000] user address but active_mm is swapper >>>> [ 3.114230] usb 1-1: new high-speed USB device number 2 using ehci-platform >>>> [ 3.118418] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP >>>> [ 3.118426] Modules linked in: >>>> [ 3.134717] CPU: 1 PID: 1 Comm: swapper/0 Not tainted >>>> 6.3.0-rc3-next-20230321 #1 >>>> [ 3.142126] Hardware name: ARM Juno development board (r2) (DT) >>>> [ 3.148052] pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) >>>> [ 3.155027] pc : string (lib/vsprintf.c:644 lib/vsprintf.c:726) >>>> [ 3.158443] lr : vsnprintf (lib/vsprintf.c:2817) >>>> [ 3.162196] sp : ffff80000b34b8f0 >>>> [ 3.165511] x29: ffff80000b34b8f0 x28: ffff800009d7b1ca x27: ffff80000b34bab0 >>>> [ 3.172666] x26: ffff800009d7b1ca x25: 0000000000000020 x24: 0000000000000008 >>>> [ 3.179820] x23: 00000000ffffffd8 x22: ffff8000099858a0 x21: ffff80000b34bc30 >>>> [ 3.186973] x20: ffff80000b34ba90 x19: ffff80000b34ba98 x18: 000000003c98bfdd >>>> [ 3.194127] x17: 000000000000001c x16: 00000000eec48da2 x15: 00000000a9dbdd17 >>>> [ 3.201280] x14: ffff80000b0242e8 x13: 0000000057a049ef x12: 00000000cfa47237 >>>> [ 3.208433] x11: 0000000000000001 x10: 00000000bd5b8780 x9 : ffff80000812cbec >>>> [ 3.215586] x8 : 00000000ffffffff x7 : 0000000000000002 x6 : ffff80000b34ba98 >>>> [ 3.222739] x5 : ffffffffffffffff x4 : 0000000000000000 x3 : ffff0a00ffffff04 >>>> [ 3.229891] x2 : 0000000000001000 x1 : 0000000000000000 x0 : ffff80000b34bab0 >>>> [ 3.237044] Call trace: >>>> [ 3.239489] string (lib/vsprintf.c:644 lib/vsprintf.c:726) >>> >>> This is the line where vsprintf() reads a string to be printed: >>> >>> static char *string_nocheck(char *buf, char *end, const char *s, >>> struct printf_spec spec) >>> { >>> int len = 0; >>> int lim = spec.precision; >>> >>> while (lim--) { >>> ----> char c = *s++; >>> >>> >>>> [ 3.242551] vsnprintf (lib/vsprintf.c:2817) >>>> [ 3.245954] vprintk_store (kernel/printk/printk.c:2200) >>>> [ 3.249712] vprintk_emit (kernel/printk/printk.c:2297) >>>> [ 3.253381] vprintk_default (kernel/printk/printk.c:2328) >>>> [ 3.257137] vprintk (kernel/printk/printk_safe.c:50) >>>> [ 3.260198] _printk (kernel/printk/printk.c:2341) >>>> [ 3.263257] sysctl_err (fs/proc/proc_sysctl.c:1109) >>>> [ 3.266577] __register_sysctl_table (fs/proc/proc_sysctl.c:1140 >>>> fs/proc/proc_sysctl.c:1383) >>>> [ 3.271202] __register_sysctl_init (fs/proc/proc_sysctl.c:1462) >>> >>> The has been done some reractoring/modification of this code >>> by the patchset ("[PATCH 00/11] sysctl: deprecate >>> register_sysctl_paths()"), see >>> https://lore.kernel.org/lkml/20230302202826.776286-1-mcgrof@kernel.org/ >>> >>> Luis, does it trigger any bell, please? >>> Do you have an idea where this code could pass a pointer PAGE_SIZE >>> as string to printk("%s")? >> >> My bisect actually landed on commit cfe7e6ea5ee2 ("mm: memory-failure: >> Move memory failure sysctls to its own file"). The new sysctl table is >> missing a sentinel. The following diff resolves it for me. >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 6367714af61d..b2377f12f062 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -143,6 +143,7 @@ static struct ctl_table memory_failure_table[] = { >> .extra1 = SYSCTL_ZERO, >> .extra2 = SYSCTL_ONE, >> }, >> + { } >> }; > Sorry, I don't know why this is removed after v1[1] when resend :( thanks for your fix. [1] https://lkml.org/lkml/2023/3/8/1644 > Thanks pushed this fix in to sysctl-next. > > Luis