linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@parallels.com>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: Linux MM <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matt Mackall <mpm@selenic.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Glauber Costa <glommer@parallels.com>,
	Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [RFC PATCH 1/1] mm: Another attempt to monitor task's memory changes
Date: Tue, 09 Apr 2013 18:52:10 +0400	[thread overview]
Message-ID: <51642B1A.9000203@parallels.com> (raw)
In-Reply-To: <51634E58.4080104@gmail.com>

On 04/09/2013 03:10 AM, KOSAKI Motohiro wrote:
>> This approach works on any task via it's proc, and can be used on different
>> tasks in parallel.
>>
>> Also, Andrew was asking for some performance numbers related to the change.
>> Now I can say, that as long as soft dirty bits are not cleared, no performance
>> penalty occur, since the soft dirty bit and the regular dirty bit are set at 
>> the same time within the same instruction. When soft dirty is cleared via 
>> clear_refs, the task in question might slow down, but it will depend on how
>> actively it uses the memory.
>>
>>
>> What do you think, does it make sense to develop this approach further?
> 
> When touching mmaped page, cpu turns on dirty bit but doesn't turn on soft dirty.

Yes. BTW, I've just thought that "soft" in soft dirty should be read as softWARE,
i.e. this bit is managed by kernel, rather than CPU.

> So, I'm not convinced how to use this flag. Please show us your userland algorithm
> how to detect diff.

It's like this:

1. First do "echo 4 > /proc/$pid/clear_refs".
   At that point kernel clears the soft dirty _and_ the writable bits from all ptes
   of process $pid. From now on every write to any page will result in #pf and the
   subsequent call to pte_mkdirty/pmd_mkdirty, which in turn will set the soft dirty
   flag.

2. Then read the /proc/$pid/pagemap (well, /proc/$pid/pagemap2 when it will appear)
   and check the soft-dirty bit reported there (in this RFC patch it's the
   PM_SOFT_DIRTY one). If set, the respective pte was written to since last call
   to clear refs. 

Thanks,
Pavel

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2013-04-09 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 17:06 Pavel Emelyanov
2013-04-08 22:30 ` Andrew Morton
2013-04-09 15:08   ` Pavel Emelyanov
2013-04-08 23:10 ` KOSAKI Motohiro
2013-04-09 14:52   ` Pavel Emelyanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51642B1A.9000203@parallels.com \
    --to=xemul@parallels.com \
    --cc=akpm@linux-foundation.org \
    --cc=glommer@parallels.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox