From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D31C433F5 for ; Mon, 21 Mar 2022 16:09:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B55306B0071; Mon, 21 Mar 2022 12:09:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B055C6B0073; Mon, 21 Mar 2022 12:09:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A5FD6B0074; Mon, 21 Mar 2022 12:09:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 8C69D6B0071 for ; Mon, 21 Mar 2022 12:09:15 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5C261228A6 for ; Mon, 21 Mar 2022 16:09:15 +0000 (UTC) X-FDA: 79268877870.12.953CA1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 930F3120029 for ; Mon, 21 Mar 2022 16:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647878954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sfGTEmUWEu/FuJm8rv4KxXhPR+l0i9Uc8G4IxOhNPME=; b=X2fStYiGZGu28IzGz94/X4Qix5z/Hr13kjipABSXwtnFEVPKtoB3jGKKQOEvvv7EUMobrc CAKxHClMNNbRxvOb6qvEgQIXUDwbnmNOnpiRhzPWC8bbpRr5GzxnEtDNJQwKuicIey3F1e JEYO2hCnaXljuwhs2HJxk+XCrcv+W5E= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-57-vjGOi4cRMCC8kx_JrxozNQ-1; Mon, 21 Mar 2022 12:09:12 -0400 X-MC-Unique: vjGOi4cRMCC8kx_JrxozNQ-1 Received: by mail-wm1-f72.google.com with SMTP id v184-20020a1cacc1000000b0038a12dbc23bso10463510wme.5 for ; Mon, 21 Mar 2022 09:09:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=sfGTEmUWEu/FuJm8rv4KxXhPR+l0i9Uc8G4IxOhNPME=; b=VEADVb2BiMTEIPb91ueLgVvV1+9OSBkuBo8M61zXzlr/ptJ7vWcTosVC1SmXEdwhEy NJngKtPMrPWeFTRtzt/gpV69GDd/YoIY3GnR5g81pnKSn/+u7v4I7Q0uw6CBOg5qopxo MhgLnWkkPlfEkqGQcRNmIUudY8FsPgKbq7l1s2/+iGkYHsCxZsY7aLMSE9g7PYD0HhpJ Qo5ohlnIOm94sJiJ8JrN/yRJCOvRD81meqo1uCNZD5BlO72rIoFOHJWm+X1VZlD6ZAjR iVs/gcYDmb9EGpAh9fNzZxHnQIDy0H+cxywpkuJxvDr2RsK57xPPdmZs598VMjiryo0e PtiA== X-Gm-Message-State: AOAM531o127STw5yYuwH/ezglRLdTsnBBAV+tB+5hxpC+HMQ5o+zu1kd O3EqBQRyrma2u/oqMrlG/+PNkjv6dcj6BA3W+QM6wgZzKyfaz4xHTWKDBDJRelGD3vTEgVrNZ3e w5BP7ZTKjsOk= X-Received: by 2002:adf:a4ce:0:b0:203:fce0:755e with SMTP id h14-20020adfa4ce000000b00203fce0755emr11044482wrb.510.1647878951692; Mon, 21 Mar 2022 09:09:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxP8tnNpWfcqHVPmFM+7jTdPf3u8hsTPKsNtKPW9hZQPytRSq0aasePBoKmg+nUJ/TirjdyGQ== X-Received: by 2002:adf:a4ce:0:b0:203:fce0:755e with SMTP id h14-20020adfa4ce000000b00203fce0755emr11044467wrb.510.1647878951397; Mon, 21 Mar 2022 09:09:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:4900:849b:f76e:5e1f:ff95? (p200300cbc7044900849bf76e5e1fff95.dip0.t-ipconnect.de. [2003:cb:c704:4900:849b:f76e:5e1f:ff95]) by smtp.gmail.com with ESMTPSA id f11-20020a7bcc0b000000b0037e0c362b6dsm14376699wmh.31.2022.03.21.09.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 09:09:10 -0700 (PDT) Message-ID: <51635f15-0f43-0f9d-e66f-9cd651431f81@redhat.com> Date: Mon, 21 Mar 2022 17:09:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH V5 1/2] selftests: vm: bring common functions to a new file To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, krisman@collabora.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20220317103323.94799-1-usama.anjum@collabora.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220317103323.94799-1-usama.anjum@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 930F3120029 X-Stat-Signature: xergd5qm8sa5tw3rsby8m17e3g6jjawx Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X2fStYiG; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf29.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1647878954-636979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001168, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/tools/testing/selftests/vm/vm_util.h b/tools/testing/selftests/vm/vm_util.h > new file mode 100644 > index 0000000000000..e9f5a0f2be196 > --- /dev/null > +++ b/tools/testing/selftests/vm/vm_util.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#include > +#include > +#include "../kselftest.h" Are that latter two really required in this header? IMHO they should be moved to the respective files that need them. If you return "bool" below, you might want to include here as well. > + > +uint64_t pagemap_get_entry(int fd, char *start); > +bool pagemap_is_softdirty(int fd, char *start); > +void clear_softdirty(void); > +uint64_t read_pmd_pagesize(void); > +uint64_t check_huge(void *addr); Apart from that, LGTM. -- Thanks, David / dhildenb